From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B83FD1CA30 for ; Tue, 5 Nov 2024 05:48:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5BA8B6B0095; Tue, 5 Nov 2024 00:48:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 569C56B0099; Tue, 5 Nov 2024 00:48:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 458A56B009B; Tue, 5 Nov 2024 00:48:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2B3C86B0095 for ; Tue, 5 Nov 2024 00:48:48 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C39581C6FF4 for ; Tue, 5 Nov 2024 05:48:47 +0000 (UTC) X-FDA: 82750960068.20.9687780 Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) by imf11.hostedemail.com (Postfix) with ESMTP id AAEAE40002 for ; Tue, 5 Nov 2024 05:48:05 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="AC53r+/S"; spf=pass (imf11.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.222.170 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730785542; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ooqt3aT7M74jfvw+mVC6zloUKxBr6BbudJQSo3zOUiw=; b=71yQ+dfqPTysmcMP1jjobVX4LWtjYnDpN0G2pbx9jkmwv68CyQzGut/L77gMlkca1VgfiG CW9tK27/AUQSP25wIBFeDuQvA714PLyNs4634yweeYZuHCY96HriqFjiKBtHB5npicH6Ex mDE7YDEbHSbvP20J/iIxMADivSCxRkc= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="AC53r+/S"; spf=pass (imf11.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.222.170 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730785542; a=rsa-sha256; cv=none; b=BeETmrLx3WMtqUrPnAd7as2Yixgn87FloWb2Ax25ndoSttlun6sK+PtAp29ZREX7QFcNFv 798Fdi369yaJe34zBAxDbZqb+XSvR9xKh8vuqRdhxwWneQ64mfiq4lutsWlMozu0dq+NI4 t+pNyp5nPhR5Rgbgs8OE4et36GzsAtE= Received: by mail-qk1-f170.google.com with SMTP id af79cd13be357-7b15467f383so363700885a.3 for ; Mon, 04 Nov 2024 21:48:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730785725; x=1731390525; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ooqt3aT7M74jfvw+mVC6zloUKxBr6BbudJQSo3zOUiw=; b=AC53r+/SW3/gJGcC4/p6VfYD02wOw8wNdJFsediw/0L93dq6Vwg/Ofonw9yWikeI9h wEo4C8aEI7FLZo61mvPbodtdwmUc7E/7GaVzxX2/gIXbqZC2e/DugxITN9XpUFYJ7UZY cbSQx9x9deHZtFaluMpjm49K/RDLYXGeULz3kqft9/d5+bSn5ho3bVOpl7UVfmj1tInc 5jXwlsuhYnjyVbmCzetDBEE8uBRUtKDHLV+PmwmC0cbFx1evlhk0vC4FnoEbkrJODaJ9 xGcoJfOkzPjvvFEkIIK0BDeFAFA1GJwSNK8yYdMNpVzNW+a+84X0svubkWRBaoGz/Cwq B4PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730785725; x=1731390525; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ooqt3aT7M74jfvw+mVC6zloUKxBr6BbudJQSo3zOUiw=; b=sxQQs005wp37SkThdyEXgyCYrzB1vyjqxXl1tP3baDXGhWT7cN615LsS2nH4l4FxEk Pcuzz6gZCHE6h3sQ6/hYqqBZT/Ls20xgWqisix3i5Nm+SSVAv+NTSXWYpx7EAKB51I38 3FFyz+9G8gW/Nb5vO2uNQHn4G1TTSNhOWgzYvD4AU8QJS3lXEdcgVQVTsZopRfL7dVz1 /F0PwUBLNw8frvRdnVohLUzIEpojDEzsX8rItspRhaoyp5igns5UAyLqNgX7PGXJkxfr 6lWndfzGPCCYROZJlTNkp4p9rcEUPtPTN+z5R4QDdKEQLyuZEb95IjMRQMOzIT/FIg6v ijYw== X-Forwarded-Encrypted: i=1; AJvYcCX1r1cfDRVzbe7v14AcrRUCNQ1wQ7wpaRuIWOV01WGl8bF6pEAEKoJKux29j0ktkkSScMId7dKkPA==@kvack.org X-Gm-Message-State: AOJu0Yx+o+Ydb0edPP95SLpj8Evl9ujjAo/rNvL3cAb8guW+mCPUZhm7 nBwBRtGoJxawntOBvP3wWTxS+1yUbhkiAu0N4xW1FK/kHAZlggATt27WZiJL3UYsNjT8z+ffWHa 6gYKopsGsEoxQJR6pxZMiEpFfTyg= X-Google-Smtp-Source: AGHT+IGsUoImaC6tu5IZuk3q0QOWemdUDlF++5PhS7RFQpW0Vci3pvngzxBxByrS2QF44hBld8irTmyaOA+pZBQ0+v8= X-Received: by 2002:a05:6214:2f85:b0:6cb:9636:8f78 with SMTP id 6a1803df08f44-6d351a8f12cmr247688806d6.8.1730785724976; Mon, 04 Nov 2024 21:48:44 -0800 (PST) MIME-Version: 1.0 References: <20241104143015.34684-1-laoar.shao@gmail.com> In-Reply-To: From: Yafang Shao Date: Tue, 5 Nov 2024 13:48:08 +0800 Message-ID: Subject: Re: [RFC PATCH] mm: Add large folio support for async readahead To: Matthew Wilcox Cc: akpm@linux-foundation.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: AAEAE40002 X-Stat-Signature: b8acdum8usjupcssu977rs3jtgpfoh59 X-Rspam-User: X-HE-Tag: 1730785685-846064 X-HE-Meta: U2FsdGVkX18qfHWL4jhfgWXaa0dRGLUBVujaMNn1L1gc8/AyUC9WuAa+IyV9IXE+LOgWuNuTOR1euHuTGpg9gXqNUq8GOxqRjriD89UY/YN2psoSuSpsE20rjyhEW/bYgqVAK2662gBFQa5uUmm7ptZN3nqs3FxEtYh+G2Zgo7FJPy3QS0D9pTQSY4YrboLtT12HVXymijPrDsEzANPq3A1eGDahdfu3zP3ZlUuG8Tc5oVATIYmvhr/YEU8KkNBqBh5Vey5Q40izcVEgmgUp4sSJ6ekGMMoW//eTTtxG4H7VIuaoR3ZHdqRDMXwU0jZ+ZivHJ38w50qxKmh9/omq2h4F41+14QJyXdbjkyiIUIEs246ouTnkFx2TfhIbw0MaICElxkm7MW9dePsrsCsJNocV0s5vjSpKV1TjbspAT44Vtxy8hR1Xbb+ORQRPYmY08vh2bmGtUQ13YL9xLNrRCUwsxJXsmigSicNrkVaaU1isuVTvmTLix/7ZCuw6a1yAmXyfBfe94QDVUcEhae4UFxbOyu2HSsyGQLvHnKWwmbgsqHvPFOK3b07m96gQVCCFeYrpKrLrEqh2Y34giK9z/4IugSMEYx8j8NwVuXxrDJLCkL1G50nl8pt9N+H4WybcTU34Zh9To3CTQU9h8n2ezLQSzPNpOtGXd5PPXDo0tdS32QB37ogk7Gb1B+4P5bLYwPUpql7MQTPXERZ2gmRbxD1VCJGFrB38QPOpDBaNbkDVx0rV2O9lywYwr0zn80jipKecYW8zsNgCEs5LDq8g/akYzLTGDD8rqcdAXI+tpmlr3lSW6ZZmQyYmYpCfsPm+hOpcvt+6Ylf/O76wgwn1PKUmCXX8ULAgnQyNNhM26ni6pjt9/mCvzawz2IUTIRCifkT42lllBzCtGWqbHb8MQiR0IOglVi5l/AjAcw7aZO2gv59rHrDRP1cgLDRkp2uCtBtLlJUcqHtSYvo8+Jc nMDchd/1 VD8OvDaTddIIAVncLXVFbyEUnIZlRFA+CfHo7hgfNLL3Q2kKsMp2gPtou9QXR4gvunxSMGVD7EfmMF2Dw/Jkm83ZCuliDX7ArMogoAM7RiNar4yS6ekDDdi/Ix7d4imt7PExSHadNurEX8olByHtALsIUDWID6GpyGrncTgHTAaq52pm0o6JcC1H2Ea7XqQEUsfaFzCfEdJRrYLxwLIVVo96v9iFXw0PgRFmV6T4KPuuj69RPDyhfE467PFgM4BE61MCcvvkieLxZleyD/+gxH8vjplCn60xjYGLAbYOQNMuOQFlDugQcgj9A2qbYxzJ64cbEaNKcdGzkxKYI+9OKZJGBbXOqAxJZJq+jOapwUq8XSbmA984CVfl3WeEIYSPBrnySBNvqkRdDDDL0Y9bAMghywjU2VKahVqKv X-Bogosity: Ham, tests=bogofilter, spamicity=0.001590, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 5, 2024 at 12:21=E2=80=AFPM Matthew Wilcox wrote: > > On Tue, Nov 05, 2024 at 11:01:01AM +0800, Yafang Shao wrote: > > Upon further analysis, it appears that the behavior depends on the > > /sys/block/*/queue/read_ahead_kb setting. On my test server, this > > parameter is set to 128KB. For the current approach to work without > > modification, it would need to be 2MB-aligned. > > > > However, I believe MADV_HUGEPAGE behavior should not be dependent on > > the value of read_ahead_kb. It would be more robust if the kernel > > automatically aligned it to 2MB when MADV_HUGEPAGE is enabled. The > > following changes ensure compatibility with non-2MB-aligned > > read_ahead_kb values: > > or maybe: > > static unsigned long get_next_ra_size(struct file_ra_state *ra, > unsigned long max) > { > unsigned long cur =3D ra->size; > > if (cur < max / 16) > return 4 * cur; > if (cur <=3D max / 2) > return 2 * cur; > + if (cur > max) > + return cur; > return max; > } > It is better. Thanks for your suggestion. --=20 Regards Yafang