From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0887EC54E65 for ; Thu, 22 May 2025 06:18:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 84DC96B0085; Thu, 22 May 2025 02:18:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 826686B0088; Thu, 22 May 2025 02:18:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 73BED6B0089; Thu, 22 May 2025 02:18:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5CEBE6B0085 for ; Thu, 22 May 2025 02:18:47 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 168E95A037 for ; Thu, 22 May 2025 06:18:47 +0000 (UTC) X-FDA: 83469540294.22.C597D82 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by imf14.hostedemail.com (Postfix) with ESMTP id 2195110000C for ; Thu, 22 May 2025 06:18:44 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=dNaA53GJ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747894725; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZAiWBeRbrCxTSOGaCOh6cmRAxFgzgObkS3PNJgd3CaA=; b=YK093CbpGeYbmbq7TDMQKZJYRtESD2xC9EHgTXQ4YzlV4jehTY7Q77hbVVnW6NQNI8Um/I aB8I5D2om9u0N+TbISXY7/b6Gs7SctDZ9ioZCMtbnhUkL37bgqKZTwA+8z6BOV1n7VjScX dW/nL692eWT/DJq/nusMYNPEYjNt1iI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747894725; a=rsa-sha256; cv=none; b=2kP4ejnPfRx8oEsH4DqsEgg4ad+Dx+6N5UwGxccmq931fyXP32uAsYw7hj12P64rVGZ+wk wvFLi8i0fUO5epSwvtAJzDoKXVsFWmZBLcgmcrySnENAglw9gIpxDI8OFACmhSnsR0wcKn Q72OntV8cXrFEsAeaYqZSTFlSUu3N60= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=dNaA53GJ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-4772f48f516so91490291cf.1 for ; Wed, 21 May 2025 23:18:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747894724; x=1748499524; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ZAiWBeRbrCxTSOGaCOh6cmRAxFgzgObkS3PNJgd3CaA=; b=dNaA53GJLN/V49QCn0befTyaprWBhuW2kj87H7VViaQpxRpyZWWHhmGttvd+Vx30AO rzi8MBreGu5BjUjeabg8/vD3Vj6ZC0rj+8jzIAZ08h+DRp+bWfT3AHM3NXO/4lG3E+wT 5XvJokJ4ux443N3Ylb+ID5tnPAu4CLzE8VoPyL2PYpC+APtZ5HwkYuP+r8CarEvX1J8Z 1gNd9l+dJmi8lWJRNqkBC/PniJAoyZ5HFeK6EKAuypLJVrBBqBZ1xRl0t1oG6GkdoB9s vwdBQAPzTDjgiWlSmPPogV2G1WUZ2LeG8ZNgtLSLG+BJlZb07BNZW8Gva/OixE5y8Bqr 5WQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747894724; x=1748499524; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZAiWBeRbrCxTSOGaCOh6cmRAxFgzgObkS3PNJgd3CaA=; b=PTL7yzyby+XNs8aZOs8xC/U3HIjd9lw9SbxXxAwrRVxewn3pOHtEtpzckBjmldFFjb 7pd1KUSYYNSvJ+3o7RJ2mCCd7PH7FfeRMhSdLwH4SRsedPbBodaa73uqQh+Amr+c2VRS MB+WLva1u8h33E/y31mkk6oBKyB7e/4aeZ19I1b0iDblcQhTsLQlxEONOXXsKZGJRRla 0dPPL6V3Y7vwV+h0l/rcwSgj0vAlxtyzpJDi6zqcszKspzclRZlmbTGKJehj7Nou8Oq2 Vk7d2gjJhOGia9BnhOmjQl6yW9TfWedArghzorRtUE+Ge7dZMtahkxOu+EBUs5zEnj4u eFvA== X-Forwarded-Encrypted: i=1; AJvYcCXRLQcoWrGQozGo8FQXEfaWgk5oLbBqaPK8BGr9/S5c937YXhi1egsLA5b2c7vNTtVrRcrbyTUPGw==@kvack.org X-Gm-Message-State: AOJu0Yx+fp/p1obeFjSmpZY3tvMUGaHC6hSuE+QvXxqZLz1SPtMA6/LH UpUIlCu6L3rGoMyPg/p2oq9PEVsNHehX5T+/cMd4TwitnWDYxGuTte4YTYqDYYbWmnYpcuV6QHi ZZ+xQT+oUIzUvatEDY2WFke5QQLRsv8I= X-Gm-Gg: ASbGncsiMZWi0i40EnlRaW21SIO0NbeUPC0GaXROi2v0zlVJIFabO98s4bb6O1mgOta lyYJ+pFPTCOVoRGTtJYtX23I+DeBRHR1FILjRLWn8jS6hkYe1GSUVPtASPN892juNefR21kZIiU deoRjXesxjJf3JN7WVBSLmzvcaM27oQ+qt6Q== X-Google-Smtp-Source: AGHT+IF095o7KgziV/OiFOYLZCRqF+WnHMajqtqVaevy/ymBVxl78I9yj22rngIrp0rCYHfgWrpJMft76skDMOt1D4U= X-Received: by 2002:ad4:5aa3:0:b0:6e4:2e5b:8d3f with SMTP id 6a1803df08f44-6f8b12bab99mr292229976d6.14.1747894724203; Wed, 21 May 2025 23:18:44 -0700 (PDT) MIME-Version: 1.0 References: <20250521062337.53262-1-bhupesh@igalia.com> <20250521062337.53262-2-bhupesh@igalia.com> In-Reply-To: <20250521062337.53262-2-bhupesh@igalia.com> From: Yafang Shao Date: Thu, 22 May 2025 14:18:08 +0800 X-Gm-Features: AX0GCFun7VcY0TRnwHC-yCRhsLLHNlgDgzjUoPDV-Se0yjKg_DkRUffEwpWoMp8 Message-ID: Subject: Re: [PATCH v4 1/3] exec: Remove obsolete comments To: Bhupesh Cc: akpm@linux-foundation.org, kernel-dev@igalia.com, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, oliver.sang@intel.com, lkp@intel.com, pmladek@suse.com, rostedt@goodmis.org, mathieu.desnoyers@efficios.com, arnaldo.melo@gmail.com, alexei.starovoitov@gmail.com, andrii.nakryiko@gmail.com, mirq-linux@rere.qmqm.pl, peterz@infradead.org, willy@infradead.org, david@redhat.com, viro@zeniv.linux.org.uk, keescook@chromium.org, ebiederm@xmission.com, brauner@kernel.org, jack@suse.cz, mingo@redhat.com, juri.lelli@redhat.com, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, linux-trace-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 2195110000C X-Stat-Signature: dqo9rbt5whpmosa58exrz6drrej6qauf X-Rspam-User: X-HE-Tag: 1747894724-931281 X-HE-Meta: U2FsdGVkX1+nchw+YhtkzoZ7CiIyH6dyAvtvfvDw42CiYCd9C1+ZurXXmOYEqQhhrlmJ9RO79kwdkxfDBI7Rv3LHX/iPuKnqa83AEauQDN4e48dIefGaHSwLBOixf3rap8Hh5rJ9XXt5v4G2FBnm/0P6VBya0W9apEaJ73kPsaWYhE0WzqpN3wq3G1gH+7zM/tGpCWZCGTQBxrcenyK6DN0kfKK7dj4h21FExfVOSrfbizaWLlE8gqwknyWIt1woBSsYEjqjAcaeQACy28m4KRb0f4NHBRi1hE6iMIWKSpz3tKv00Hp+ifDcuYtv/TMAouZ5XklfKazt1vg3SJ8qGf5zNnhv54PbdKLmsdLHFqF+X5akXHSLxXu+gtZpGasK9M8h5mqhnO4+HYzP78WLw+WCabsAT76Z71p+CUqis4iaYwfnuiUa9nSaQ0Z2VH2zCxLv7wBoKkmHk38+WBVpikvl7TG3Q2DBSJfChE7wHta4MPuAse/FMUNsquE5gboQIV7CXhBxrnBsPemOzoV6iihCOFsTd4ddmPLSBE2fvodWaq3fCqEZUuPnrjzQGnUc4CBa4kmI3f6asDEV1LY1QvlFLubiVZR935jZrZBm9d29kIW3pIWro46BaP+R/YeDBNP6tk+O5npZUfEQnbl07TxeWIN5VB79BLubhw7XNQMuBgELsynwE840FHeQ+YCNaphKRCqIIkZL2OTKGPqv04RjIwtLWme4/WuGYkUfax46Fv9mQZy4RIDpLlXsNCB0ZKFnkZGxBdGdI5b1k/XUeRR0VIL3vV3hQ5cgetoahDmFIU+O+c4tFHDQgV/lgSFLZvAmk6C28nQPVrrdc/4rRzmfEmY3YbAGjl7hVixsDo4SsdSeCMc708+i99DCg5SX1I/RicIVy5xEhz58A6O9arUZoN65Ha0DG+B/x/tBb3S+NpdThx0vsazb85xJoj3Ey7URReVC5pu2PXUNyX0 rICUcxRP s6KyJ+ni+oEoY8bp6mkLhR38l44/DIophBlGA7TaOUYnl5PI7iTUUztW13SFkX5ebhir/AvGX9idpyTP4STcm07Ytx6Iil1Dhh9JNGubEeR2D8m3h0GFuRcSMXRSyGgiutcpE12AYve1gCbxe5kk/KbSvvuNGldCAIP5p1yhM1Sd+KpeGmO5n091kNILvC3Jgm6PUAOrRDrkf2AFW4y4ZleZxkAshcYdCBSazdFBGcF7YOn5ru+rlpRTzADbg8Os4/SbDX3D0ebxZHU7jUIYzWVVRxd7ONc21uDWegmm/QPqR+89wgKiXa4YL3/KTyKB+A4gPXIzCahnAj73mDl+AzJSLdkj4cAkCUybc/TkXjcFVU5Tg5lCR7R0YrzbAaaoifawDs9CWAsnKipYCYenM3cHhi+YrbRTy88Xm+M8WRFRs25Im1i8vt4N609eOs5+KQ4lbNhCw/KzgBvTuEPWQGg4kUJnAeBYMEcXTlVa0RvrrXEXCLT2H5bkZZBxwiGm18P6s X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 21, 2025 at 2:24=E2=80=AFPM Bhupesh wrote: > > Patch 3a3f61ce5e0b ("exec: Make sure task->comm is always NUL-terminated"= ), > replaced 'strscpy_pad()' with 'memcpy()' implementations inside > '__set_task_comm()'. > > However a few left-over comments are still there, which mention > the usage of 'strscpy_pad()' inside '__set_task_comm()'. > > Remove those obsolete comments. > > While at it, also remove an obsolete comment regarding 'task_lock()' > usage while handing 'task->comm'. > > Signed-off-by: Bhupesh Acked-by: Yafang Shao > --- > include/linux/sched.h | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/include/linux/sched.h b/include/linux/sched.h > index 8c60a42f9d00..704222114dcc 100644 > --- a/include/linux/sched.h > +++ b/include/linux/sched.h > @@ -1162,10 +1162,8 @@ struct task_struct { > * > * - normally initialized begin_new_exec() > * - set it with set_task_comm() > - * - strscpy_pad() to ensure it is always NUL-terminated and > + * - logic inside set_task_comm() will ensure it is always NUL-= terminated and > * zero-padded > - * - task_lock() to ensure the operation is atomic and the name= is > - * fully updated. > */ > char comm[TASK_COMM_LEN]; > > @@ -1997,7 +1995,7 @@ extern void __set_task_comm(struct task_struct *tsk= , const char *from, bool exec > * User space can randomly change their names anyway, so locking for r= eaders > * doesn't make sense. For writers, locking is probably necessary, as = a race > * condition could lead to long-term mixed results. > - * The strscpy_pad() in __set_task_comm() can ensure that the task com= m is > + * The logic inside __set_task_comm() should ensure that the task comm= is > * always NUL-terminated and zero-padded. Therefore the race condition= between > * reader and writer is not an issue. > * > -- > 2.38.1 > --=20 Regards Yafang