linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Yafang Shao <laoar.shao@gmail.com>
To: Chris Down <chris@chrisdown.name>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@kernel.org>,
	 Vladimir Davydov <vdavydov.dev@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	 Cgroups <cgroups@vger.kernel.org>, Linux MM <linux-mm@kvack.org>,
	shaoyafang@didiglobal.com
Subject: Re: [PATCH] mm/memcontrol: split pgscan into direct and kswapd for memcg
Date: Tue, 9 Apr 2019 22:04:39 +0800	[thread overview]
Message-ID: <CALOAHbA9+D-GGq4Z76s_wOKmmDKnTZzefvHLTn8JxmXThAmiDw@mail.gmail.com> (raw)
In-Reply-To: <20190409132551.GA1570@chrisdown.name>

On Tue, Apr 9, 2019 at 9:25 PM Chris Down <chris@chrisdown.name> wrote:
>
> Hey Yafang,
>
> Yafang Shao writes:
> >-      seq_printf(m, "pgscan %lu\n", acc.vmevents[PGSCAN_KSWAPD] +
> >-                 acc.vmevents[PGSCAN_DIRECT]);
> >+      seq_printf(m, "pgscan_direct %lu\n", acc.vmevents[PGSCAN_DIRECT]);
> >+      seq_printf(m, "pgscan_kswapd %lu\n", acc.vmevents[PGSCAN_KSWAPD]);
>
> I don't think we can remove the overall pgscan counter now, we already have
> people relying on it in prod. At least from my perspective, this patch would be
> fine, as long as pgscan was kept.
>

HI Chirs,

Thanks for your feedback.
I will keep 'pgscan' and only introduce 'pgscan_kswapd'.

Thanks
Yafang


  reply	other threads:[~2019-04-09 14:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-09 13:13 Yafang Shao
2019-04-09 13:25 ` Chris Down
2019-04-09 14:04   ` Yafang Shao [this message]
2019-04-09 17:55 ` Johannes Weiner
2019-04-10  1:16   ` Yafang Shao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALOAHbA9+D-GGq4Z76s_wOKmmDKnTZzefvHLTn8JxmXThAmiDw@mail.gmail.com \
    --to=laoar.shao@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=cgroups@vger.kernel.org \
    --cc=chris@chrisdown.name \
    --cc=hannes@cmpxchg.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=shaoyafang@didiglobal.com \
    --cc=vdavydov.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox