From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80010C433E3 for ; Thu, 27 Aug 2020 02:13:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 310EC2075B for ; Thu, 27 Aug 2020 02:13:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Pp8+YLOq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 310EC2075B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 944E76B0002; Wed, 26 Aug 2020 22:13:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F5976B0003; Wed, 26 Aug 2020 22:13:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 80B2B6B0006; Wed, 26 Aug 2020 22:13:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0204.hostedemail.com [216.40.44.204]) by kanga.kvack.org (Postfix) with ESMTP id 6B2086B0002 for ; Wed, 26 Aug 2020 22:13:53 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 1D4BA181AEF1E for ; Thu, 27 Aug 2020 02:13:53 +0000 (UTC) X-FDA: 77194727946.06.snail95_250c60327069 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id E52B91004C9CE for ; Thu, 27 Aug 2020 02:13:52 +0000 (UTC) X-HE-Tag: snail95_250c60327069 X-Filterd-Recvd-Size: 4359 Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Thu, 27 Aug 2020 02:13:52 +0000 (UTC) Received: by mail-io1-f65.google.com with SMTP id b16so4291669ioj.4 for ; Wed, 26 Aug 2020 19:13:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Y0s1W1iJV2XuChfP2d7BeiUo6HMX4XicrVqEnqcngi4=; b=Pp8+YLOqTTy7srKgjeb7eXXw1grJfCZgpDx1cBai5zNF2tTnfguoD0e5uH/A+E2po4 JDOipdc860vl3vw7Mlua80WD0R4zgpuojdbfKbzCpSuWB2dBs3uWCySSUNTjkgIA03vD sc835JSXIPKCp1thJWUDwLcLET5TCQAhYkUy7TKPzoSCsBFV++/JsWF1yKOJBlFVdzoL Ayo3r453/UbWvP5xPQOKIWEr/YGKXvwZKAT4vIVJm7Ad3ltow0b51CS60auuyUgXuRz4 Z9BPOLLInPOLa75vq4hZWZb1n+ODDeFK6fOgQ+L10f7FvpjbHml7ukIM138t8go1qInU YnBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Y0s1W1iJV2XuChfP2d7BeiUo6HMX4XicrVqEnqcngi4=; b=Qvzjuk7t9y0Lc6qOYM6PwLzbrsMWu2CZ3I03aPL+gk6RIPYITFPvCLRoPGU2f2TMOw o4+c1WjgMciXRb/x0bkx4yrtAVUJ8Xwz4Pa+lAiJgNAf9P6ljBd1XbqfzlHYOyxHUekl SEoI03Yu68fk5cM04IZhCC+yOgzyksEiEOwwNNcwb+FQFKAyNh+6CL97cNloiZBX2X0c EP1qQ3iKM29cdns6hXomXqdB2qVNxMlS5/pMqldeThIibMUPSCXcbAcIB7IIk8YVDISj 8Naca0N4Hyv+Gco+dp9hJDVAhdwecfLZ3VrqqsDfR6eNFY+F9Lr6mFID1HuxQuSDf1SZ c31Q== X-Gm-Message-State: AOAM533wf+4/baoL/Trd8zIir6E/MpRAwzUHSiRnQ2TU4E9xgeDdS8Xt t9+ZousikSc9QWG/WqFbrsXKXpkw9AE/d7oFVIc= X-Google-Smtp-Source: ABdhPJz2kOS+Qm+C2GfIr6X48vPMyNiHCcyKrtJ8LrqYGcnBsXC0ivmQfPY4jinJpdNFBIy0WySnImNVkZjGPXq1XRI= X-Received: by 2002:a05:6602:26c1:: with SMTP id g1mr15544424ioo.10.1598494431915; Wed, 26 Aug 2020 19:13:51 -0700 (PDT) MIME-Version: 1.0 References: <20200827013444.24270-1-laoar.shao@gmail.com> <20200827013444.24270-3-laoar.shao@gmail.com> <20200827015853.GA14765@casper.infradead.org> In-Reply-To: <20200827015853.GA14765@casper.infradead.org> From: Yafang Shao Date: Thu, 27 Aug 2020 10:13:15 +0800 Message-ID: Subject: Re: [PATCH v7 2/2] xfs: avoid transaction reservation recursion To: Matthew Wilcox Cc: Dave Chinner , Christoph Hellwig , "Darrick J. Wong" , Michal Hocko , Andrew Morton , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, Linux MM Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: E52B91004C9CE X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 27, 2020 at 9:58 AM Matthew Wilcox wrote: > > On Thu, Aug 27, 2020 at 09:34:44AM +0800, Yafang Shao wrote: > > @@ -1500,9 +1500,9 @@ iomap_do_writepage(struct page *page, struct writeback_control *wbc, void *data) > > > > /* > > * Given that we do not allow direct reclaim to call us, we should > > - * never be called in a recursive filesystem reclaim context. > > + * never be called while in a filesystem transaction. > > */ > > - if (WARN_ON_ONCE(current->flags & PF_MEMALLOC_NOFS)) > > + if (WARN_ON_ONCE(wbc->fstrans_recursion)) > > goto redirty; > > Erm, Dave said: > > > I think we should just remove > > the check completely from iomap_writepage() and move it up into > > xfs_vm_writepage() and xfs_vm_writepages(). > > ie everywhere you set this new bit, just check current->journal_info. I can't get you. Would you pls. be more specific ? I move the check of current->journal into xfs_vm_writepage() and xfs_vm_writepages(), and I think that is the easiest way to implement it. /* we abort the update if there was an IO error */ @@ -564,6 +565,9 @@ xfs_vm_writepage( { struct xfs_writepage_ctx wpc = { }; + if (xfs_trans_context_active()) + wbc->fstrans_recursion = 1; <<< set for XFS only. + return iomap_writepage(page, wbc, &wpc.ctx, &xfs_writeback_ops); } -- Thanks Yafang