From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23E13C433EF for ; Sun, 12 Dec 2021 16:27:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4314E6B0071; Sun, 12 Dec 2021 11:26:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E0E86B0073; Sun, 12 Dec 2021 11:26:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A9116B0074; Sun, 12 Dec 2021 11:26:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0132.hostedemail.com [216.40.44.132]) by kanga.kvack.org (Postfix) with ESMTP id 18A586B0071 for ; Sun, 12 Dec 2021 11:26:54 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id C9341181AEF1F for ; Sun, 12 Dec 2021 16:26:43 +0000 (UTC) X-FDA: 78909670686.22.A69889A Received: from mail-qv1-f44.google.com (mail-qv1-f44.google.com [209.85.219.44]) by imf17.hostedemail.com (Postfix) with ESMTP id 5DBF940002 for ; Sun, 12 Dec 2021 16:26:39 +0000 (UTC) Received: by mail-qv1-f44.google.com with SMTP id gu12so12480953qvb.6 for ; Sun, 12 Dec 2021 08:26:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bNwHjQhCMbCngDQX0H2Ckug8Srm3laq1CXvl0Hu0lM4=; b=TN+GNEmKaM7kZ83XqRhVGt6qR97dFjj2J2am6DzEXDqdOCFKNJ7/f4op+u4uknQvtE LZMq3wH8qQk3WE/BcbZe6Zh2Xhm2Miy2dnLuy/5/Y7ITxSNSuq+4TZS18qpuJLXdSKBr FNBky3Sz17QI0vaTJ7y/T6uPtk5gnjBw8/2eCvmn+F+xjesAV3S9r9kKWHksA8CvznMZ AqpH69+Y7r82RSNyl3AWz7cAnVodlsuk68rVVfbXtiAdcW9gv9CaV3YuNxaV+SXM+eq+ mHbJZeSN/yoT8a4L9dkv7793323d86qrOZzQUbPVv8NKNF5sCT2DDPPt8WOCh0FC0LEA IRLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bNwHjQhCMbCngDQX0H2Ckug8Srm3laq1CXvl0Hu0lM4=; b=qfuRRC8scnncFrDGiWj04R60tBYi80/sAisZoNncCzMHVKnGu0+6QsrHqswoszpbFk D+/zkVpuYmf+NK8TKyhxSPnEhiVU+4Fk+pkWFsdGMzKC3jXELZYNh6Tld9Pt7QRV+hlE JSXTZVfpxuWgvn2BrFUEXHyzGuEoH8ar8A2/LxTh73v8LT7DsEQA7qhZ3yQLaTvwhaYC 7mwstaI0OkXmQ/P+F/w1ir8pmcXFOtggwkcN4K6Db58r+j7UY0kRSlHu2fPa35DY7vSl r5D/G1sg2P+H/PUgq7+8EbDiP8/YgIXzMj8H5CcGNU2dnCtQGvmZwdTRfI89VmmlkfDt LvBQ== X-Gm-Message-State: AOAM53292WLbkFqHlx06rLJx5f6Wbn3NTogcyRCuuO7XncqqTiAfIZqd +WLrykwab37klCUsxkcSeeV5Qvm9wmsHQ2JLuY4= X-Google-Smtp-Source: ABdhPJz5keJkRw3D5mHm9P4v597lE0nNgF4GdVDHC/Rk0AvaTN8JHYTdOZU++IiRJNA0ndiLIg1li+HMZ/66oZZqZeE= X-Received: by 2002:a05:6214:3019:: with SMTP id ke25mr36724071qvb.69.1639326402741; Sun, 12 Dec 2021 08:26:42 -0800 (PST) MIME-Version: 1.0 References: <20211211063949.49533-1-laoar.shao@gmail.com> <20211211063949.49533-3-laoar.shao@gmail.com> In-Reply-To: From: Yafang Shao Date: Mon, 13 Dec 2021 00:26:04 +0800 Message-ID: Subject: Re: [PATCH -mm v2 2/3] cn_proc: replaced old hard-coded 16 with TASK_COMM_LEN_16 To: Michal Miroslaw Cc: Andrew Morton , Steven Rostedt , Kees Cook , Petr Mladek , David Hildenbrand , Arnaldo Carvalho de Melo , Andrii Nakryiko , Alexei Starovoitov , Linux MM , bpf , "linux-perf-use." , Linux-Fsdevel , LKML , Mathieu Desnoyers , Peter Zijlstra , Matthew Wilcox , Al Viro Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 5DBF940002 X-Stat-Signature: 5wn5fxi5cgoufyqtjptq7ra5z7b4qekd Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=TN+GNEmK; spf=pass (imf17.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.219.44 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1639326399-343961 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Dec 12, 2021 at 2:10 PM Michal Miroslaw wrote: > > On Sat, Dec 11, 2021 at 06:39:48AM +0000, Yafang Shao wrote: > > This TASK_COMM_LEN_16 has the same meaning with the macro defined in > > linux/sched.h, but we can't include linux/sched.h in a UAPI header, so > > we should specifically define it in the cn_proc.h. > [...] > > index db210625cee8..6dcccaed383f 100644 > > --- a/include/uapi/linux/cn_proc.h > > +++ b/include/uapi/linux/cn_proc.h > > @@ -21,6 +21,8 @@ > > > > #include > > > > +#define TASK_COMM_LEN_16 16 > > Hi, > > Since this is added to UAPI header, maybe you could make it a single > instance also used elsewhere? Even though this is constant and not > going to change I don't really like multiplying the sources of truth. > Hmm, what about defining it in include/uapi/linux/sched.h ? Then include "sched.h" in cn_proc.h And we also define it in tools/include/uapi/linux/sched.h for the usage in tools. -- Thanks Yafang