From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72703C4829A for ; Sat, 10 Feb 2024 07:06:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CEDF96B0078; Sat, 10 Feb 2024 02:06:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C9DC76B007B; Sat, 10 Feb 2024 02:06:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B658C6B007E; Sat, 10 Feb 2024 02:06:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A82136B0078 for ; Sat, 10 Feb 2024 02:06:22 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1AC881A0571 for ; Sat, 10 Feb 2024 07:06:22 +0000 (UTC) X-FDA: 81775010604.25.9023596 Received: from mail-yb1-f178.google.com (mail-yb1-f178.google.com [209.85.219.178]) by imf09.hostedemail.com (Postfix) with ESMTP id 2DBC8140015 for ; Sat, 10 Feb 2024 07:06:19 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=umich.edu header.s=google-2016-06-03 header.b=pNcqnNEY; dmarc=pass (policy=none) header.from=umich.edu; spf=pass (imf09.hostedemail.com: domain of tmgross@umich.edu designates 209.85.219.178 as permitted sender) smtp.mailfrom=tmgross@umich.edu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707548780; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IVNAIhFgu3wzuB+0TCn1gIA0o9jgzX3mBnlxu6KTrrg=; b=pu7tWlAxrXBbEdcAUCjnzDgKI7usBpai9HC+sCHBxyIfWO74ZXi50zYBV2dRTXUzV5o7Gc 3WD2ilFmezj4z6zZiAMBLbLPJtBrUYFQjOZ5VZKV+IpV7oDvoE+eTRuzWifbU9TFjX0q3u OD+n88pQ3yIQ4rbywRJJbbh+Lw88iLE= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=umich.edu header.s=google-2016-06-03 header.b=pNcqnNEY; dmarc=pass (policy=none) header.from=umich.edu; spf=pass (imf09.hostedemail.com: domain of tmgross@umich.edu designates 209.85.219.178 as permitted sender) smtp.mailfrom=tmgross@umich.edu ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707548780; a=rsa-sha256; cv=none; b=5WpOyFtPMfnqM8eJAzBGo8lmpkOjdYyzM5sgHHKfpemPyqwCOhzSjZ/hjljULV3QHMXBqe QobYKf3kIh4o9hQA6IYmTeJe3/MBN4SoX5NY0v/8QefXaaF/uCjZ9lKYviz5mLVN3E50bD Dwjif9rgCgznuKgTIdj+RfaBmm2iFrM= Received: by mail-yb1-f178.google.com with SMTP id 3f1490d57ef6-db3a09e96daso1554788276.3 for ; Fri, 09 Feb 2024 23:06:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umich.edu; s=google-2016-06-03; t=1707548779; x=1708153579; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=IVNAIhFgu3wzuB+0TCn1gIA0o9jgzX3mBnlxu6KTrrg=; b=pNcqnNEYde3IXfOfTJoj95uvzqzYBHtqx12Fo79Qv14TggqM1oy9GsGO3LczHPXTfx 98nT6UIQvQ9/+szRIbeJsj84GVuxFwOU6PUNwls3Cz8HKQjve5H4KXBmZdSemQEEKJrP EYvuxdr49t/KJN4rBOvIEXu0SdM2zvdOTH+OyrLTCM8gmjP6ZmaLQ1q6qmJBIFe1rDmW Aatgd/BnrZKKoL0p8qYtg1fpwoB0CtvwjDMwUpU7RLqiB5jGiyxwr16+f6FbKATRrXoZ XZCv1XphhjLeJKBLaeqRqEkyZbunnIE62s6OVSLt3xO+VGhsAJzzd5miU1eeruYj1dUq frYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707548779; x=1708153579; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IVNAIhFgu3wzuB+0TCn1gIA0o9jgzX3mBnlxu6KTrrg=; b=SUNuLdAg4fAFCiJlD7zvPvyNRH4bOUtyVSqJ5e014UY4ikPMSH2qNR24yxr0Rnsnri 2atPBPp2U985tJiTBYMWJsoGfOODQUxDEE1b7o88Xglbqo0Ek4TOzWDikwP5kEZ3p4Zz ai2ZIkkq+b71mHWf+pRnIDfixT/A0tKeFfr93C18KrI7qSP8il9fwMCDlf8U21gRUdZF FIDf0zq1nlZ+gEJd02kS6R1YV3SuoWeBhWtHS1F8m9inRRqAYJUvGEUsCMrVo8cimKwR e34HIaic6bK/XRSTRptDXi9o9i8ZzUC0bXvlh3isqDyl21ra5j0UG+wwF1lnIrJBDwek s5Xw== X-Forwarded-Encrypted: i=1; AJvYcCUiWSCGbdtfXK6Fi3f4tuva3IatuA63Wke13uy29XfVz6O+TxnQgdW/murSjhdUp9RFoueQ5ko06K8x7CEKLQJKT3E= X-Gm-Message-State: AOJu0YzqUVnzBOd358dcgezXAr1DyL7MaB7bHKMutHMFmC5MAbsBR8vT kct6IWgDankym8ZZaz/tQlFc0ep3FmgXHi09bX4WHLYF117ep2IaQ1q7ujFIQffUW9+Uas2kDfs vxeA2ujjGNWPHSnLkGKanN1UzRH/4Cj3DsuDf6w== X-Google-Smtp-Source: AGHT+IG6aq7ApN6uXPaXdmvOo/2SytSpE9H3XIU0AGh0g/v0Eo5l0YahD/aLAQHmUK/A4sGozgfxiPqCLqsf4fk2r2g= X-Received: by 2002:a5b:b4e:0:b0:dc6:d313:c621 with SMTP id b14-20020a5b0b4e000000b00dc6d313c621mr1122754ybr.47.1707548779165; Fri, 09 Feb 2024 23:06:19 -0800 (PST) MIME-Version: 1.0 References: <20240124-alice-mm-v1-0-d1abcec83c44@google.com> <20240124-alice-mm-v1-1-d1abcec83c44@google.com> In-Reply-To: From: Trevor Gross Date: Sat, 10 Feb 2024 01:06:07 -0600 Message-ID: Subject: Re: [PATCH 1/3] rust: add userspace pointers To: Alice Ryhl Cc: Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Kees Cook , Al Viro , Andrew Morton , Greg Kroah-Hartman , =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Carlos Llamas , Suren Baghdasaryan , Arnd Bergmann , linux-mm@kvack.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Christian Brauner Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 2DBC8140015 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: yeqts8smzx17p6yxri5s4jy8yf3suosg X-HE-Tag: 1707548779-515310 X-HE-Meta: U2FsdGVkX19d75/b2UvjYAck9TgI/4N+/ONbc8DEz41fWsXrAb0e4QHPm7AYsV/KJ3PdEo/FdlakT7KhnpOxlWw7G7CXWZUl2q4Q/kbdZFWa7m70Ii7VG56+BH7ki2EDRwMbB7FQ2MHj0ewHXEJsN7CZLqrV1bYyBgX1u16AnctUolGY3bk5YvTL5YV92j7aLExvAeADssS6sM21LDOb4yRGYWQFXviHOZDzDMPTT1di1945xwJI1q3h7UJW6xYNaaBz5aJ3og3XOUIQ+FKV2FvSJymhW9twPlxVtTbYFFDH6d7q3NcvgHs9Y5m4LoGoajUChfOI/4i3B8pI2V016hRfYwVxrhcTtfDZBCdDogq7+ZHg7zbS/ybwDDrpsCM5yDfa6yjkfUzA03XkiTAtQ7IaqH9OdibGB2Oo8EQmE+ajuQDGrOtrWbk6SD08IGdwHr27F4SwxuyHeIZCRsTrEGAcvjroa/bvVx0/Py27XhrFChKZFuKRPEMuLUwb1KCfu6CUflHpdFwDPTTXXamRsLju5fLc9W6sbClpSEbLEbOYQCVNKy153EtiOkOhqLIIkR3xjErAFRX/ZL4xz+nRSSMo2gl5fIGXP//RPQdmpcL7surUVmMP9pFC8PawLKwOTkkE0xFFOHcscVj6xsAiBM4iUg8hnCrdWq2R/b6YL7yTZRQwcpPBDK1Yagt7coGjqY/qhCKEnkl70uNpx4vXH2HVNc+Eh9eOoO8bdqfgKj4LPXWS0tuL5akZnJzbzdNQ+fnherViFMlYUvmYy7ZYwAQqM50tjzh3Da9YXpqHcCPYrvrtR/lOpKEJYTHPDHteR7DAkzIZA+KcWzhdFUV0wAqpuf5csf2C8GHbBD+uVaI+AB2Tv+mSdWS8+OVkSJa+StWUpIM78fA2iKd037v8wEMCPx4rAf3QPGhhoq4Fqd4hw6Q/COVGyXaPFdCxYSwFNq9ROKbKkokW7QgG4vI 9E+JzFSj Ff//p9Pjf8YqpGDk0iTriWKirL3zzyb3DBkBU2Uuow7GQm6oZ5siCZYJTdIOhHNxsHPGURS3ycmdatCgW6SNcINi9yx3p4ctoq3t5Fpiy1WWNO6Pv0VDOYUN75+OGVWKSTEF6oa08RPXp+n/HV7IN2bLbPgx1oXkIWjeH8Tccfdt4Iw/7Q964O5rshK8S+BHMiI5AP+ARrXl5LA9m2VR/K1lvHXNXWgni97JTeat+O0t9kIGSsCiqTRvHiFHkQpOiAwIQg7Ek7EKySaEMtA2ifVXlWFrkQremJ5gIN8e2dty8EitxICUbMsTuINV9328rznP/ICH4xDv7lSAnhPmjrGiZqciSF0Ww7z81 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 8, 2024 at 6:53=E2=80=AFAM Alice Ryhl wr= ote: > Leaking pointer addresses in logs is frowned upon in the kernel, so I > don't think we should include that. Sounds like the very correct decision from what Greg and Kees said. If we add an impl in the future (to be able to `#[derive(Debug)]` on anything containing this type) it could just print `0x****************`.