From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01F38C47084 for ; Mon, 24 May 2021 23:01:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 70CCE61415 for ; Mon, 24 May 2021 23:01:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 70CCE61415 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C99716B006C; Mon, 24 May 2021 19:01:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C48946B006E; Mon, 24 May 2021 19:01:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC1736B0070; Mon, 24 May 2021 19:01:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0129.hostedemail.com [216.40.44.129]) by kanga.kvack.org (Postfix) with ESMTP id 7BE7D6B006C for ; Mon, 24 May 2021 19:01:15 -0400 (EDT) Received: from smtpin39.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 0DFBC99BF for ; Mon, 24 May 2021 23:01:15 +0000 (UTC) X-FDA: 78177647310.39.DD916E4 Received: from mail-oi1-f180.google.com (mail-oi1-f180.google.com [209.85.167.180]) by imf30.hostedemail.com (Postfix) with ESMTP id 99886E00080C for ; Mon, 24 May 2021 23:01:10 +0000 (UTC) Received: by mail-oi1-f180.google.com with SMTP id c196so20350229oib.9 for ; Mon, 24 May 2021 16:01:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PSD9aky6k9bGsVcfR0vPvHg999974ELdRM/Fh4rT3ZQ=; b=sv0PW37FhOwUmoDWupNNXFctJcn5NfGmvJvyli82uR0RUuDCsX3TpjoezawKD9lrl3 DSt/1hori90crTHqt6/dUe1jT4wCcB8yUtbvXAIrF14T0nTZpYgKKXnq9NTvtTstzPpT S3zRsK85tJM0zgIULolt9mnj5axhjsFapb2MshaniD1en9OFVmt2iNyGpL0wz0zBV/XW S2WQCxXhIGqyl+0FzRzLgBIRp6GHdm3ZEiwBZG0UIEuRHh28U9zhKdcHUf5U8/26dbZR QRf2rWZlF4tPXPpSMtZKRQKBFvhFCn1cGwnoA2mpLgoQlym7FzEfIi6pTsPyhK3QcB2L pHUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PSD9aky6k9bGsVcfR0vPvHg999974ELdRM/Fh4rT3ZQ=; b=WItkLU6zNwGhTwHjn1gR7D/Y/hWnJyAFQd56QvTsfOzu8veGWa5kLA23+CoH9wC4b9 ZaUuGZ0xqleUNsFxn5OOr19/eZWHRH713wdHZ/zqpP95Qp2lRCmMU7kBU7zhz8W7t3R5 YsBncyCkxxjRf/5frtEO+yrxcBPkcv6mCmIAN+cPfQNL6n474GNdmgf446WNpzqbw2Ci AryvH4KPUOc8olPOWJIDNb0uUe/Aqn30NixZc70hHMFqWgzOO7O4Wy4Oa+136n9FnZtL kqkjnAPv1GUpbAKFj7Xl8x1VSAewNkrs3SAVd13p2ZX+D8yqCxxshE4hhdxgFq7wKPfO W7xA== X-Gm-Message-State: AOAM530uIrQ8yQG8Qkf5zkhJYJSG01I0QhBR3nXwRBlixneBzUnBbwAV cgN2Q6XAdX8rM/WfeukBPWgonT2gmQzAWfAbOj5kiw== X-Google-Smtp-Source: ABdhPJzLOTEM8GLQe2KOR6TqCC2ZByezgmTfICW31/mQ5eoe92rVuDG/yXEf5P6jJxiWgYKVbom/HKB9DnfrVu4YTG8= X-Received: by 2002:aca:280a:: with SMTP id 10mr943354oix.13.1621897273701; Mon, 24 May 2021 16:01:13 -0700 (PDT) MIME-Version: 1.0 References: <20181031234928.144206-1-marcorr@google.com> <34bf7026-4f83-067e-f3d8-aad76f9cf624@redhat.com> In-Reply-To: From: Jim Mattson Date: Mon, 24 May 2021 16:01:02 -0700 Message-ID: Subject: Re: [kvm PATCH v6 0/2] shrink vcpu_vmx down to order 2 To: Sean Christopherson Cc: Paolo Bonzini , Marc Orr , kvm list , David Rientjes , Konrad Rzeszutek Wilk , linux-mm , Andrew Morton , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Matthew Wilcox , Dave Hansen , Wanpeng Li Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=sv0PW37F; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf30.hostedemail.com: domain of jmattson@google.com designates 209.85.167.180 as permitted sender) smtp.mailfrom=jmattson@google.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 99886E00080C X-Stat-Signature: fwjc4kk1j55pznmj7hn6d7e1pdhj4x95 X-HE-Tag: 1621897270-220272 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 24, 2021 at 3:44 PM Sean Christopherson wrote: > > On Mon, May 24, 2021, Paolo Bonzini wrote: > > On 21/05/21 22:58, Jim Mattson wrote: > > > On Wed, Oct 31, 2018 at 4:49 PM Marc Orr wrote: > > > > > > > > Compared to the last version, I've: > > > > (1) dropped the vmalloc patches > > > > (2) updated the kmem cache for the guest_fpu field in the kvm_vcpu_arch > > > > struct to be sized according to fpu_kernel_xstate_size > > > > (3) Added minimum FPU checks in KVM's x86 init logic to avoid memory > > > > corruption issues. > > > > > > > > Marc Orr (2): > > > > kvm: x86: Use task structs fpu field for user > > > > kvm: x86: Dynamically allocate guest_fpu > > > > > > > > arch/x86/include/asm/kvm_host.h | 10 +++--- > > > > arch/x86/kvm/svm.c | 10 ++++++ > > > > arch/x86/kvm/vmx.c | 10 ++++++ > > > > arch/x86/kvm/x86.c | 55 ++++++++++++++++++++++++--------- > > > > 4 files changed, 65 insertions(+), 20 deletions(-) > > > > > > > > -- > > > > > > Whatever happened to this series? > > > > There was a question about the usage of kmem_cache_create_usercopy, and a v7 > > was never sent. > > What's that go to do with anything? :-D > > b666a4b69739 ("kvm: x86: Dynamically allocate guest_fpu") > 240c35a3783a ("kvm: x86: Use task structs fpu field for user") So, that's what the series was trimmed down to. Thanks! Did we still manage to get down to order 2?