linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Chenyuan Yang <chenyuan0y@gmail.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
	 linux-kernel@vger.kernel.org, syzkaller@googlegroups.com,
	 Zijie Zhao <zzjas98@gmail.com>,
	John Hubbard <jhubbard@nvidia.com>
Subject: Re: [Linux Kernel Bug][mm/gup] 3 Warning Crashes: kmalloc bug in gup_test_ioctl, is_valid_gup_args, pin_user_pages_fast
Date: Fri, 26 Jan 2024 11:31:26 -0600	[thread overview]
Message-ID: <CALGdzuo7V-3-US9U+rjyBfmZD=d-gUfAxJejsTUsmnSZNDnh5A@mail.gmail.com> (raw)
In-Reply-To: <ZbPnsnwnVKvI1rQ4@casper.infradead.org>

Hello Matthew,

Thanks very much for your prompt response!

For `gup_test_ioctl`, we generate the descriptions for it for
interaction and testing:
```
openat$gup_test(fd const[AT_FDCWD], file ptr[in,
string["/sys/kernel/debug/gup_test"]], flags const[O_RDWR], mode
const[0]) fd_gup_test
ioctl$PIN_FAST_BENCHMARK(fd fd_gup_test, cmd
const[PIN_FAST_BENCHMARK], arg ptr[inout, gup_test])
...
gup_test {
    ...
    gup_flags int32
    ...
}
```

In this context, I would like to seek your valued opinion. Do you
believe it would be more prudent to avoid fuzz testing the
`gup_test_ioctl`, or are the warnings in `gup_test_ioctl` an
anticipated outcome?
It seems that `gup_test_ioctl` can indeed be exposed in the kernel by
accessing /sys/kernel/debug/gup_test.

Thank you once again for your time and expertise.

Best,
Chenyuan

On Fri, Jan 26, 2024 at 11:11 AM Matthew Wilcox <willy@infradead.org> wrote:
>
> On Fri, Jan 26, 2024 at 11:04:53AM -0600, Chenyuan Yang wrote:
> > Dear Developers for Linux Memory Management,
> >
> > We encountered 3 warning crashes when testing the memory management
> > with Syzkaller and our generated specifications:
>
> These all come in through gup_test_ioctl().  It's my impression
> that this is something you can enable to wreak havoc on your kernel
> and it's not something which should ever be exposed to fuzzers.
>
>
>
>
>


  reply	other threads:[~2024-01-26 17:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-26 17:04 Chenyuan Yang
2024-01-26 17:11 ` Matthew Wilcox
2024-01-26 17:31   ` Chenyuan Yang [this message]
2024-01-26 18:34     ` Matthew Wilcox
2024-01-26 19:08       ` John Hubbard
2024-01-26 19:23         ` Chenyuan Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALGdzuo7V-3-US9U+rjyBfmZD=d-gUfAxJejsTUsmnSZNDnh5A@mail.gmail.com' \
    --to=chenyuan0y@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=jhubbard@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=syzkaller@googlegroups.com \
    --cc=willy@infradead.org \
    --cc=zzjas98@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox