From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx159.postini.com [74.125.245.159]) by kanga.kvack.org (Postfix) with SMTP id 642826B0096 for ; Sat, 8 Sep 2012 09:26:06 -0400 (EDT) Received: by iec9 with SMTP id 9so817231iec.14 for ; Sat, 08 Sep 2012 06:26:05 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1346885323-15689-1-git-send-email-elezegarcia@gmail.com> <1346885323-15689-5-git-send-email-elezegarcia@gmail.com> Date: Sat, 8 Sep 2012 10:26:04 -0300 Message-ID: Subject: Re: [PATCH 5/5] mm, slob: Trace allocation failures consistently From: Ezequiel Garcia Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: JoonSoo Kim Cc: linux-mm@kvack.org, Pekka Enberg , Christoph Lameter On Fri, Sep 7, 2012 at 6:23 PM, JoonSoo Kim wrote: > Hi, Ezequiel. > > 2012/9/7 Ezequiel Garcia : >> Hi Joonso, >> >> On Thu, Sep 6, 2012 at 4:09 PM, JoonSoo Kim wrote: >>> 2012/9/6 Ezequiel Garcia : >>>> This patch cleans how we trace kmalloc and kmem_cache_alloc. >>>> In particular, it fixes out-of-memory tracing: now every failed >>>> allocation will trace reporting non-zero requested bytes, zero obtained bytes. >>> >>> Other SLAB allocators(slab, slub) doesn't consider zero obtained bytes >>> in tracing. >>> These just return "addr = 0, obtained size = cache size" >>> Why does the slob print a different output? >>> >> >> I plan to fix slab, slub in a future patchset. I think it would be nice to have >> a trace event reporting this event. But, perhaps it's not worth it. > > I think that output "addr = 0" is sufficient to trace out-of-memory situation. > Why do we need a output "addr = 0, obtained size = 0"? > You're absolutely right. Thanks, Ezequiel. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org