From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx143.postini.com [74.125.245.143]) by kanga.kvack.org (Postfix) with SMTP id 55ECE6B0114 for ; Wed, 12 Sep 2012 20:28:48 -0400 (EDT) Received: by iec9 with SMTP id 9so4965778iec.14 for ; Wed, 12 Sep 2012 17:28:47 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: Date: Wed, 12 Sep 2012 21:28:47 -0300 Message-ID: Subject: Re: [PATCH v2 0/10] mm: SLxB cleaning and trace accuracy improvement From: Ezequiel Garcia Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Pekka Enberg , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: JoonSoo Kim , Tim Bird , Steven Rostedt , David Rientjes , Christoph Lameter , Glauber Costa Hi Pekka, On Sat, Sep 8, 2012 at 5:49 PM, Ezequiel Garcia wrote: > Hi everyone, > > This is the second spin of my patchset to clean SLxB and improve kmem > trace events accuracy. > > For this v2, the most relevant stuff is: > > I've dropped two patches that were not very well received: > Namely this two are now gone: > mm, slob: Use only 'ret' variable for both slob object and returned pointer > mm, slob: Trace allocation failures consistently > I believe consistency is important but perhaps this is just me being paranoid. > > There's a lot of dumb movement and renaming. This might seem stupid > (and maybe it is) but it's necessary to create some common code between SLAB > and SLUB, and then factor it out. > > Also, there's a patch to add a new option to disable gcc auto-inlining. > I know we hate to add new options, but this is necessary to get > accurate call site > traces. Plus, the option is in "Kernel Hacking", so it's for kernel > developers only. > > This work is part of CELF Workgroup Project: > "Kernel_dynamic_memory_allocation_tracking_and_reduction" [1] > > Feedback, comments, suggestions are very welcome. > > Ezequiel Garcia (10): > mm: Factor SLAB and SLUB common code > mm, slub: Rename slab_alloc() -> slab_alloc_node() to match SLAB > mm, slab: Rename __cache_alloc() -> slab_alloc() > mm, slab: Match SLAB and SLUB kmem_cache_alloc_xxx_trace() prototype > mm, slab: Replace 'caller' type, void* -> unsigned long > mm, util: Use dup_user to duplicate user memory > mm, slob: Add support for kmalloc_track_caller() > mm, slab: Remove silly function slab_buffer_size() > mm, slob: Use NUMA_NO_NODE instead of -1 > Makefile: Add option CONFIG_DISABLE_GCC_AUTOMATIC_INLINING > Can you pick patches 2, 3, 4, and 5? Namely only those related to SLOB and to simple cleanups. I'll redo SLAB/SLUB commonization, as Christoph requested. Thanks, Ezequiel. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org