From: Ezequiel Garcia <elezegarcia@gmail.com>
To: David Rientjes <rientjes@google.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Tim Bird <tim.bird@am.sony.com>,
Pekka Enberg <penberg@kernel.org>, Matt Mackall <mpm@selenic.com>
Subject: Re: [PATCH 1/3] mm/slob: Drop usage of page->private for storing page-sized allocations
Date: Fri, 19 Oct 2012 09:31:39 -0300 [thread overview]
Message-ID: <CALF0-+VZ429FETTByhKQOi-FYnCHvUGTWX6eL0Zp2NSgD1LbbQ@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1210181544590.1439@chino.kir.corp.google.com>
On Thu, Oct 18, 2012 at 7:46 PM, David Rientjes <rientjes@google.com> wrote:
> On Thu, 18 Oct 2012, Ezequiel Garcia wrote:
>
>> This field was being used to store size allocation so it could be
>> retrieved by ksize(). However, it is a bad practice to not mark a page
>> as a slab page and then use fields for special purposes.
>> There is no need to store the allocated size and
>> ksize() can simply return PAGE_SIZE << compound_order(page).
>>
>> Cc: Pekka Penberg <penberg@kernel.org>
>
> Is Pekka Penberg the long distant cousin of Pekka Enberg? :) You should
> probably cc the author of slob, Matt Mackall <mpm@selenic.com>, on slob
> patches.
>
Ouch! ;-)
I found another typo so I'll just re-send the whole patchset.
Thanks for the review!
Ezequiel
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-10-19 12:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 22:41 Ezequiel Garcia
2012-10-18 22:41 ` [PATCH 2/3] mm/slob: Use object_size field in kmem_cache_size() Ezequiel Garcia
2012-10-18 22:50 ` David Rientjes
2012-10-18 22:41 ` [PATCH 3/3] mm/sl[aou]b: Move common kmem_cache_size() to slab.h Ezequiel Garcia
2012-10-18 22:46 ` [PATCH 1/3] mm/slob: Drop usage of page->private for storing page-sized allocations David Rientjes
2012-10-19 12:31 ` Ezequiel Garcia [this message]
2012-10-31 6:56 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALF0-+VZ429FETTByhKQOi-FYnCHvUGTWX6eL0Zp2NSgD1LbbQ@mail.gmail.com \
--to=elezegarcia@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=tim.bird@am.sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox