From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx118.postini.com [74.125.245.118]) by kanga.kvack.org (Postfix) with SMTP id 4F95A6B005D for ; Wed, 26 Sep 2012 06:09:18 -0400 (EDT) Received: by ied10 with SMTP id 10so1197474ied.14 for ; Wed, 26 Sep 2012 03:09:17 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1348571229-844-1-git-send-email-elezegarcia@gmail.com> <1348571229-844-2-git-send-email-elezegarcia@gmail.com> Date: Wed, 26 Sep 2012 07:09:17 -0300 Message-ID: Subject: Re: [PATCH] mm/slab: Fix kmem_cache_alloc_node_trace() declaration From: Ezequiel Garcia Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: David Rientjes Cc: kernel-janitors@vger.kernel.org, linux-mm@kvack.org, fengguang.wu@intel.com, Pekka Enberg Hi David, On Wed, Sep 26, 2012 at 1:18 AM, David Rientjes wrote: > On Tue, 25 Sep 2012, Ezequiel Garcia wrote: > >> The bug was introduced in commit 4052147c0afa >> "mm, slab: Match SLAB and SLUB kmem_cache_alloc_xxx_trace() prototype". >> > > This isn't a candidate for kernel-janitors@vger.kernel.org, these are > patches that are one of Pekka's branches and would never make it to Linus' > tree in this form. > >> Cc: Pekka Enberg >> Reported-by: Fengguang Wu >> Signed-off-by: Ezequiel Garcia > > Acked-by: David Rientjes > > So now we have this for SLAB: > > extern void *kmem_cache_alloc_node_trace(size_t size, > struct kmem_cache *cachep, > gfp_t flags, > int nodeid); > > and this for SLUB: > > extern void *kmem_cache_alloc_node_trace(struct kmem_cache *s, > gfp_t gfpflags, > int node, size_t size); > > Would you like to send a follow-up patch to make these the same? (My > opinion is that the SLUB variant is the correct order.) Yes. I just asked Pekka to revert this patch altogether. The original patch was meant to match SLAB and SLUB, and this fix should maintain that. But instead I fix it the wrong way. I'll send another one. Sorry for the mess, Ezequiel. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org