From: Ezequiel Garcia <elezegarcia@gmail.com>
To: David Rientjes <rientjes@google.com>
Cc: kernel-janitors@vger.kernel.org, linux-mm@kvack.org,
fengguang.wu@intel.com, Pekka Enberg <penberg@kernel.org>
Subject: Re: [PATCH] mm/slab: Fix kmem_cache_alloc_node_trace() declaration
Date: Wed, 26 Sep 2012 07:09:17 -0300 [thread overview]
Message-ID: <CALF0-+UZj-cunn-+AW0N6_oi1j9VFH8btKV1pvhjtVFiVsE1yQ@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1209252115000.28360@chino.kir.corp.google.com>
Hi David,
On Wed, Sep 26, 2012 at 1:18 AM, David Rientjes <rientjes@google.com> wrote:
> On Tue, 25 Sep 2012, Ezequiel Garcia wrote:
>
>> The bug was introduced in commit 4052147c0afa
>> "mm, slab: Match SLAB and SLUB kmem_cache_alloc_xxx_trace() prototype".
>>
>
> This isn't a candidate for kernel-janitors@vger.kernel.org, these are
> patches that are one of Pekka's branches and would never make it to Linus'
> tree in this form.
>
>> Cc: Pekka Enberg <penberg@kernel.org>
>> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
>> Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com>
>
> Acked-by: David Rientjes <rientjes@google.com>
>
> So now we have this for SLAB:
>
> extern void *kmem_cache_alloc_node_trace(size_t size,
> struct kmem_cache *cachep,
> gfp_t flags,
> int nodeid);
>
> and this for SLUB:
>
> extern void *kmem_cache_alloc_node_trace(struct kmem_cache *s,
> gfp_t gfpflags,
> int node, size_t size);
>
> Would you like to send a follow-up patch to make these the same? (My
> opinion is that the SLUB variant is the correct order.)
Yes. I just asked Pekka to revert this patch altogether.
The original patch was meant to match SLAB and SLUB, and this
fix should maintain that. But instead I fix it the wrong way.
I'll send another one.
Sorry for the mess,
Ezequiel.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-09-26 10:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 11:07 [PATCH] mm/slab: Fix typo _RET_IP -> _RET_IP_ Ezequiel Garcia
2012-09-25 11:07 ` [PATCH] mm/slab: Fix kmem_cache_alloc_node_trace() declaration Ezequiel Garcia
2012-09-26 4:18 ` David Rientjes
2012-09-26 6:34 ` Dan Carpenter
2012-09-26 10:09 ` Ezequiel Garcia [this message]
2012-09-26 10:42 ` Pekka Enberg
2012-09-26 10:46 ` Ezequiel Garcia
2012-09-26 10:04 ` Ezequiel Garcia
2012-09-26 4:13 ` [PATCH] mm/slab: Fix typo _RET_IP -> _RET_IP_ David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALF0-+UZj-cunn-+AW0N6_oi1j9VFH8btKV1pvhjtVFiVsE1yQ@mail.gmail.com \
--to=elezegarcia@gmail.com \
--cc=fengguang.wu@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox