From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3F6BEB64DC for ; Mon, 17 Jul 2023 12:44:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E05F88D0001; Mon, 17 Jul 2023 08:44:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DDBF86B0074; Mon, 17 Jul 2023 08:44:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA3A18D0001; Mon, 17 Jul 2023 08:44:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id BBEAF6B0072 for ; Mon, 17 Jul 2023 08:44:32 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8429B402CE for ; Mon, 17 Jul 2023 12:44:32 +0000 (UTC) X-FDA: 81021072384.27.0317BCA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 46EBC180014 for ; Mon, 17 Jul 2023 12:44:30 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=amWrORrO; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of dwysocha@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dwysocha@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689597870; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cPBr5P6RMAc5J6eRrRxygG6j4FumvyTiuWHqCKdLMWY=; b=I0RsLkWOAjvBOjc2Hm+T3if0XIuftNCQAqjyMMnOO4Ba67UQqikYhVl62WaKTZudintYG3 bUnM5uZMfGJbp9Ua8Mgvyg2fEBfy4yBn3pnr6BWWSdCzC1d7tj7HbmgpC2Zdwkuoo9y+Xw jvo85tQ8u5D0qGdX0bJ1NmpuY4L9OyM= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=amWrORrO; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of dwysocha@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dwysocha@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689597870; a=rsa-sha256; cv=none; b=oKV/VAtLifwc9u+mibb5VQtvCNVNoHxb6KeatXPo6lLtHpAmo6TQ16r9bykvi6EuyPygd+ j1TuBgT3t3niz+b3PQNadSxq+VQogGr7AYUaEOeGMubQuYsNPMnFca4LgMZXxhyJBp87p0 iHvtGwxuz8kVEvUkKrmvD7R+RjfH80g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689597869; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cPBr5P6RMAc5J6eRrRxygG6j4FumvyTiuWHqCKdLMWY=; b=amWrORrOnZDCpgMvWWcfqvT5UBD+kLHaCmiF3/RT7fDu722plwiokyTY7EBjZJGwscPdNm nfHkyF/HgQcPBYOepd8HYymECqRxSzc6+hi7qpo1osSuqZYc0p9GF/hleM6tWihHbJugU6 oUZW3lYcK3qsHmoorx6+8Ilc3RCtiqU= Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-45-5H46B2pwN5eFx_VSKQw_sw-1; Mon, 17 Jul 2023 08:44:28 -0400 X-MC-Unique: 5H46B2pwN5eFx_VSKQw_sw-1 Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-55c072efe78so1884723a12.3 for ; Mon, 17 Jul 2023 05:44:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689597867; x=1692189867; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cPBr5P6RMAc5J6eRrRxygG6j4FumvyTiuWHqCKdLMWY=; b=K3+7eG+9oDtnynvWa1e8xTQLNBxBpxfQbLt6SRhIyY7l1X+0BuJMCOWZFKHYq55ZdY G+EUkte8DQZffgCMX21lH/yTKHXogreNw9QrSC2YXj91ZUuePFGzCkSkZ6fMWM8UohjQ NKHbzQ4vZMAcGEj8AEXtaMJOy3FAID9SjDRSwRyXytharZbuL98WfYMTvYPcZhcF1R1P f5c2x2z6VogP4O678UOecCdhaPS97Lqcynz8y2bGzaIFIDFfI606UuKQhRLpCVcu2J14 XsHvtk/HfAtZSw53qmAu1rm+Kiu1pDinP5lgEE0jfgwYEVazlFssFHoXUARHaSdL9Mwg ROGQ== X-Gm-Message-State: ABy/qLaOzG6ovG+3NrXT7qdFSpPfQcNVm16e/TuOVDhQsiDwmt9qCCou 94vLRjn5WIKK8Wx/BYzobEcaxVWZ3U6solXnRjiQQ23DnrcDbAp1LW8vPVRBcE5wuErVjnaeueK LDqzbW8JbeDjNPr52Rw4gDCZ7+2c= X-Received: by 2002:a17:90a:5902:b0:263:ea6a:1049 with SMTP id k2-20020a17090a590200b00263ea6a1049mr10021677pji.2.1689597867250; Mon, 17 Jul 2023 05:44:27 -0700 (PDT) X-Google-Smtp-Source: APBJJlHasnKG+SNiDONa+CP1OSdvJTohPXX69WzDE7nIpw5fYJbI1G9ilrC2Cj9qoIe3xkPsQOURqnSvBH8qP+XIJY0= X-Received: by 2002:a17:90a:5902:b0:263:ea6a:1049 with SMTP id k2-20020a17090a590200b00263ea6a1049mr10021649pji.2.1689597866936; Mon, 17 Jul 2023 05:44:26 -0700 (PDT) MIME-Version: 1.0 References: <20230628104852.3391651-3-dhowells@redhat.com> <202307171548.7ab20146-oliver.sang@intel.com> In-Reply-To: <202307171548.7ab20146-oliver.sang@intel.com> From: David Wysochanski Date: Mon, 17 Jul 2023 08:43:50 -0400 Message-ID: Subject: Re: [PATCH v7 2/2] mm, netfs, fscache: Stop read optimisation when folio removed from pagecache To: kernel test robot Cc: David Howells , oe-lkp@lists.linux.dev, lkp@intel.com, Rohith Surabattula , Matthew Wilcox , Linus Torvalds , Steve French , Shyam Prasad N , Dominique Martinet , Ilya Dryomov , v9fs@lists.linux.dev, linux-afs@lists.infradead.org, linux-cachefs@redhat.com, ceph-devel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Jeff Layton , Christoph Hellwig , v9fs-developer@lists.sourceforge.net, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 46EBC180014 X-Stat-Signature: xtmmewbzoq6c65r9ikj4gwii9yfnon9i X-HE-Tag: 1689597870-458821 X-HE-Meta: U2FsdGVkX194DEM8XJDSeyzKAqAWiqPKy9JNaTZjuESN9EhCJ+PonqLCm3OlcJxbOZQBlYu+MnkRYqQLiK/1uhqLXSrJYCZ6MDYKDNQM+COWRvU/1Qiv6+8J0wAbiMag2D1A1ZIFa7YrjgjuAhpyzk5dEQ28wfZ4aREMcHnbpDDPlbgqjRKnmB/OK7V8I5cPTxVctYzUOdjxvdz/2JW+ftag7B0zVrSg0XIzUYGk80OyDZkUiQzPLIBUTs9Hw86IjqTlrxeDVc3u3kga6fvRLQtB7FX1KC1SLaIymaCIjMNW+MnzwIfMiP+6dJA1AxoUlLnGKTv+OAtyeKLoYMGJUMogDOslFH1VYWK5WuK7cqYWK38og83LrQcXmLwf+qPFEigzD2oiGxII70SrgmqXGat10AyH30Ni43TURriWfYZmQoHgb4eI2808WlAGhybUNV6dV1KIERWsFiE1ODVO9yaD25MGQr5i5zvWjkidnXd1fDumjNw9YezDgm3QTXIMtp/f579EQ0QTOTkD+pgkRk2YhndPJjuabfzyoIK5dHTG7nG6IaKkqW60jtfpdTWzkYRY/sgon1dbEFNg7cIR68Or63qaseZZkfsZAnFJixiTGBuNL73nO2r+8O4RzsFHNWo1rxl9+Wybg6UH3yqesfK6hd0ycT6pgwNGiInRMCRxQ1snUlNuSjv0ueeU0U91WJ9keJR8Mwl1v16BzR9AySCpqDGIpF/7BwqlV73SQfdwm2Sf9PSFRj4lM3r0IXGiuVYA/AZEfpNH1PecevDHglxWP241lekQpwXmiymask4btBD+ocgv6/ImAmlNl1fGN4P4JYbBvY49uA8+9u7Hiw7hFjOD4o102mnsyeCfarFeh3xr8JuQa4SWun6c8XcKgqf9XSGLUIuLcel+whQzQUSdg/+6rA1iCVvCzoXpOmwLEo47XeUpi37ilenA0va/XPCPMgF3faNOb90lXX1 S+BXr5dU g46xiKHqVwY2wOvdig6sTIVak7rI3BxDOb0uEP72IutzIuvsQT4hBGXIlEtrLK8Wjmif599dg+Cuyihuo6CHrPY8sdyOfdjEqU/Z2LqeY6GmUClrdvLK2GJb9W4t9DVD5DoVq3DaMH1WbjnyKMzzuO+PbCycvs1TUf3eZGEjw7fBG+oW20Sfay6or3JXW5BPVLIW7S532+5W4DWbUdx0WpkiT2tZpuoPj2Wklk/CzPfRyL3hC+rQbejBX2OuVDkg1yiIZxjMZixHps0WmSWrwBAlymKGn02hhIm7YvL+WOjXE263UZmYgde+M+GJ08Gr7YvEGJOzyQEGW1MSPRzyshzMZ6wuDsClIHOJytmkSSyEv8ReKhUMEcn0zKXBaiLjxvl6zzLM48e2g/O4+j9uI+K2mEsG93pwFrC0jGdZTJFE5/icYRck9LWZkkr38JEntPUx9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 17, 2023 at 3:35=E2=80=AFAM kernel test robot wrote: > > > > Hello, > > kernel test robot noticed "canonical_address#:#[##]" on: > > commit: 830503440449014dcf0e4b0b6d905a1b0b2c92ad ("[PATCH v7 2/2] mm, net= fs, fscache: Stop read optimisation when folio removed from pagecache") > url: https://github.com/intel-lab-lkp/linux/commits/David-Howells/mm-Merg= e-folio_has_private-filemap_release_folio-call-pairs/20230628-185100 > base: https://git.kernel.org/cgit/linux/kernel/git/akpm/mm.git mm-everyth= ing > patch link: https://lore.kernel.org/all/20230628104852.3391651-3-dhowells= @redhat.com/ > patch subject: [PATCH v7 2/2] mm, netfs, fscache: Stop read optimisation = when folio removed from pagecache > > in testcase: vm-scalability > version: vm-scalability-x86_64-1.0-0_20220518 > with following parameters: > > runtime: 300 > thp_enabled: always > thp_defrag: always > nr_task: 32 > nr_ssd: 1 > priority: 1 > test: swap-w-rand > cpufreq_governor: performance > > test-description: The motivation behind this suite is to exercise functio= ns and regions of the mm/ of the Linux kernel which are of interest to us. > test-url: https://git.kernel.org/cgit/linux/kernel/git/wfg/vm-scalability= .git/ > > > compiler: gcc-12 > test machine: 128 threads 2 sockets Intel(R) Xeon(R) Platinum 8358 CPU @ = 2.60GHz (Ice Lake) with 128G memory > > (please refer to attached dmesg/kmsg for entire log/backtrace) > > > > If you fix the issue in a separate patch/commit (i.e. not just a new vers= ion of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-lkp/202307171548.7ab20146-oliver.san= g@intel.com > This has already been fixed with https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/commit/?h=3Dmm-= everything&id=3Daf18573471db5c5c9b96ec95208c340ae7c00e64 > > [ 45.898720][ T1453] > [ 45.907480][ T1453] 2023-07-16 00:36:07 ./case-swap-w-rand > [ 45.907481][ T1453] > [ 45.917873][ T1453] 2023-07-16 00:36:07 ./usemem --runtime 300 -n 32 = --random 8048142432 > [ 45.917876][ T1453] > [ 47.348632][ T973] general protection fault, probably for non-canonic= al address 0xf8ff1100207778e6: 0000 [#1] SMP NOPTI > [ 47.359787][ T973] CPU: 123 PID: 973 Comm: kswapd1 Tainted: G S = 6.4.0-rc4-00533-g830503440449 #3 > [ 47.370301][ T973] Hardware name: Intel Corporation M50CYP2SB1U/M50CY= P2SB1U, BIOS SE5C620.86B.01.01.0003.2104260124 04/26/2021 > [ 47.382201][ T973] RIP: 0010:filemap_release_folio (kbuild/src/x86_64/mm= /filemap.c:4063 (discriminator 1)) > [ 47.388172][ T973] Code: 00 48 8b 07 48 8b 57 18 83 e0 01 74 4f 48 f7 07= 00 60 00 00 74 22 48 8b 07 f6 c4 80 75 32 48 85 d2 74 34 48 8b 82 90 00 00= 00 <48> 8b 40 48 48 85 c0 74 24 ff e0 cc 66 90 48 85 d2 74 15 48 8b 8a > All code > =3D=3D=3D=3D=3D=3D=3D=3D > 0: 00 48 8b add %cl,-0x75(%rax) > 3: 07 (bad) > 4: 48 8b 57 18 mov 0x18(%rdi),%rdx > 8: 83 e0 01 and $0x1,%eax > b: 74 4f je 0x5c > d: 48 f7 07 00 60 00 00 testq $0x6000,(%rdi) > 14: 74 22 je 0x38 > 16: 48 8b 07 mov (%rdi),%rax > 19: f6 c4 80 test $0x80,%ah > 1c: 75 32 jne 0x50 > 1e: 48 85 d2 test %rdx,%rdx > 21: 74 34 je 0x57 > 23: 48 8b 82 90 00 00 00 mov 0x90(%rdx),%rax > 2a:* 48 8b 40 48 mov 0x48(%rax),%rax <-- trapp= ing instruction > 2e: 48 85 c0 test %rax,%rax > 31: 74 24 je 0x57 > 33: ff e0 jmpq *%rax > 35: cc int3 > 36: 66 90 xchg %ax,%ax > 38: 48 85 d2 test %rdx,%rdx > 3b: 74 15 je 0x52 > 3d: 48 rex.W > 3e: 8b .byte 0x8b > 3f: 8a .byte 0x8a > > Code starting with the faulting instruction > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > 0: 48 8b 40 48 mov 0x48(%rax),%rax > 4: 48 85 c0 test %rax,%rax > 7: 74 24 je 0x2d > 9: ff e0 jmpq *%rax > b: cc int3 > c: 66 90 xchg %ax,%ax > e: 48 85 d2 test %rdx,%rdx > 11: 74 15 je 0x28 > 13: 48 rex.W > 14: 8b .byte 0x8b > 15: 8a .byte 0x8a > [ 47.408103][ T973] RSP: 0018:ffa00000094f7b28 EFLAGS: 00010246 > [ 47.414266][ T973] RAX: f8ff11002077789e RBX: ffa00000094f7c08 RCX: 9= 8ff110020777898 > [ 47.422337][ T973] RDX: ff11002077788f71 RSI: 0000000000000cc0 RDI: f= fd4000042870d00 > [ 47.430417][ T973] RBP: ffa00000094f7b98 R08: ff110001ba106300 R09: 0= 000000000000028 > [ 47.438497][ T973] R10: ff110010846bd080 R11: ff1100207ffd4000 R12: f= fd4000042870d00 > [ 47.446575][ T973] R13: ffa00000094f7e10 R14: ffa00000094f7c1c R15: f= fd4000042870d08 > [ 47.454658][ T973] FS: 0000000000000000(0000) GS:ff110020046c0000(00= 00) knlGS:0000000000000000 > [ 47.463703][ T973] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > [ 47.470406][ T973] CR2: 00007fddcaf308f8 CR3: 00000001e1a82003 CR4: 0= 000000000771ee0 > [ 47.478496][ T973] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0= 000000000000000 > [ 47.486594][ T973] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0= 000000000000400 > [ 47.494696][ T973] PKRU: 55555554 > [ 47.498372][ T973] Call Trace: > [ 47.501795][ T973] > [ 47.504870][ T973] ? die_addr (kbuild/src/x86_64/arch/x86/kernel/dumpsta= ck.c:421 kbuild/src/x86_64/arch/x86/kernel/dumpstack.c:460) > [ 47.509153][ T973] ? exc_general_protection (kbuild/src/x86_64/arch/x86/= kernel/traps.c:783 kbuild/src/x86_64/arch/x86/kernel/traps.c:728) > [ 47.514826][ T973] ? asm_exc_general_protection (kbuild/src/x86_64/arch/= x86/include/asm/idtentry.h:564) > [ 47.520679][ T973] ? filemap_release_folio (kbuild/src/x86_64/mm/filemap= .c:4063 (discriminator 1)) > > > To reproduce: > > git clone https://github.com/intel/lkp-tests.git > cd lkp-tests > sudo bin/lkp install job.yaml # job file is attached in= this email > bin/lkp split-job --compatible job.yaml # generate the yaml file = for lkp run > sudo bin/lkp run generated-yaml-file > > # if come across any failure that blocks the test, > # please remove ~/.lkp and /lkp dir to run from a clean state. > > > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests/wiki > >