From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C865EC5B552 for ; Mon, 9 Jun 2025 21:15:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4CEBE6B0088; Mon, 9 Jun 2025 17:15:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 47F3A6B008C; Mon, 9 Jun 2025 17:15:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3955B6B0092; Mon, 9 Jun 2025 17:15:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1ABEE6B0088 for ; Mon, 9 Jun 2025 17:15:45 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C4894B923B for ; Mon, 9 Jun 2025 21:15:44 +0000 (UTC) X-FDA: 83537119008.12.ACF3446 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by imf22.hostedemail.com (Postfix) with ESMTP id 9FAC3C0002 for ; Mon, 9 Jun 2025 21:15:42 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=purestorage.com header.s=google2022 header.b="Cbuu/APg"; spf=pass (imf22.hostedemail.com: domain of cachen@purestorage.com designates 209.85.215.179 as permitted sender) smtp.mailfrom=cachen@purestorage.com; dmarc=pass (policy=reject) header.from=purestorage.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749503743; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sYtPlwOvxwZJ7eCzqIujLb/MovyBtoZYHfx5cemKdQY=; b=vY0JZrG2kdx8ub0q39qzO5ugC/g7HmIcOx6VRFp3AM8CMqtUQZSCWgMrDm89nnQv8Dm+iL VfZhnpi1vFf+lGe1ZQ078tezqAaUDqjmB+exFY6ND1fIy/TG418FyR7DJ53FBNZftjnlW6 L4D/z1O2LhwOUTQlrtIp/JbDTEyBCQ8= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=purestorage.com header.s=google2022 header.b="Cbuu/APg"; spf=pass (imf22.hostedemail.com: domain of cachen@purestorage.com designates 209.85.215.179 as permitted sender) smtp.mailfrom=cachen@purestorage.com; dmarc=pass (policy=reject) header.from=purestorage.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749503743; a=rsa-sha256; cv=none; b=C9AKjkisJ/O5b3iBgsxhPnaRac5gaU46tq3FxKdF5XIlg1w99chEKfMS/oupz9NkeZIZ2+ 4FjYYnZ3J2T+mRrU611rQbtns7l3VaOEVe/4h1cVKdhVscPs7CWwgyTZNjomIyAag98ut3 Ar9lN41cUlOa/dWsoRMfdwDzY081S/c= Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-b26ed340399so520135a12.2 for ; Mon, 09 Jun 2025 14:15:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1749503741; x=1750108541; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=sYtPlwOvxwZJ7eCzqIujLb/MovyBtoZYHfx5cemKdQY=; b=Cbuu/APgqfksOyGux3p+M/dYzfJqcNKkxanbqU/JMokr2hdfKTm7uxA2/7fgFIM8OF Kr/BoOPecfQqdzYce3MkRHRZKWmYNM8XzrFoiHwYakE20k1A6l7xio8ew2/h+IRnpnYC 3cer1v3SBslBG7jveCFy5kcUaTeP7+jOoJLMJdwwxW8pN7fE1h5yk30ZH3Rs29ZtDjI4 JJuTc/tQVHuoJ3H/Yql1Cj0rUsKAeadDGJiL72e3s6OJB/cIdaKZcngxLhcj/MoVdaai o5pTVqg1TyOugZomiJ8n1fOxK7OdtF2DL+jNoxhEG0ePy1mFcM8w0/QvwmeXIzgDGNXl W8wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749503741; x=1750108541; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sYtPlwOvxwZJ7eCzqIujLb/MovyBtoZYHfx5cemKdQY=; b=ReTsEXpocP3jGo4qCXlot4OTTVGVsUTZHjJAF4wW2mn8+1JKfOJzaUJ9/olNQq27yN CyKsLAI2JlgGxu1JqqQSzWTUU67JzIL3edCB2b/a7wlevA09TBhMNlZ/BIM8nNdLNkpA Ld65jvUIxlnm26DbJ+uX7r8jPRtTGHe+PS2e8DxZpgT1c1MSvu5sZYx/KwsY0XQ2jSf5 nfYsmWya8XCc0r2obh+d+jjyEVaWvBXDJd6r1dRR8EvZjs8DDeLkUhdYMaCF/uW3ViJQ DICx57xWuP8RgPmpdWvv3VD7SoMedx/drNty/ik+tgdctK0B4gavYR14atiuSZve6zlE u+Pw== X-Gm-Message-State: AOJu0Yz8P02hDj7y7eTFpwOLArqMVK219IrzvcjcDwHPFQ30xd51ywNm v7JhkEdvGCeYhxCKadLPwBgkFgev6IFiQWkhLs3HkKUA50eYzyimx8NptPIggfYSIGry0pmAmbg Qd6HpRqDyb7R8CFU+UAwBVB/9ngeZq+6UPqYwXJTpHw== X-Gm-Gg: ASbGncuboAosmEB0Cn8qco6yrSxryST0/pu/eB8uW6tSxU0JasMpasE2eaK2aLx6hv6 /OpONKnqHhZ0POpysNwB79k/E9tOmjKNuWaKY5appjetRwA0sryDDhZoss4YSbN2NXE3yT8xfOc N4dILSeHw1pAeFX+Z7Og2tEQAXwbt6EQrPRb80/0vTAxI= X-Google-Smtp-Source: AGHT+IGfmKU5H2L/IbvVzMqwH7QSLE8+f4tpWz0tcfj4FVNChmMOqd3ZR6btPznVFL/9MoAX36tms5W2dS+XybVnwBk= X-Received: by 2002:a17:90b:350f:b0:311:c939:c855 with SMTP id 98e67ed59e1d1-3134e415d0amr7088145a91.3.1749503741266; Mon, 09 Jun 2025 14:15:41 -0700 (PDT) MIME-Version: 1.0 References: <20250605190128.2287011-1-cachen@purestorage.com> <20250605190128.2287011-2-cachen@purestorage.com> In-Reply-To: From: Casey Chen Date: Mon, 9 Jun 2025 14:15:30 -0700 X-Gm-Features: AX0GCFuAzT7K8ujiMF-ZvZ4JLS0RoPZir5gh1GIygJbvi4dqWjr4i0Uh00PzY7o Message-ID: Subject: Re: [PATCH 1/1] alloc_tag: remove empty module tag section from linker script To: Suren Baghdasaryan Cc: linux-mm@kvack.org, kent.overstreet@linux.dev, yzhong@purestorage.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: niuu436ns8ijy3rr3tdqyid6pm9n6msz X-Rspamd-Queue-Id: 9FAC3C0002 X-Rspamd-Server: rspam11 X-HE-Tag: 1749503742-632147 X-HE-Meta: U2FsdGVkX1/8FikB19ixdxd1YAFXCIF0N+WORlef5N60UFByuelYktIxpWMwW98OhXMB9EssIQnVD7FbrxlE47V89AXvwcr/NgF6eLKwb1zutCe50NAq7oJEcHi6saXVFuinagyUBZxJ7icRZjW7Wzr9Ulu1HMmZg6SGMLYmluLpvB8CehjTPNmXH2R9f+yfheU7wkqniol80WApRMDdVQ+aVtZR6xQApWdmrlTO5rLqFzM7pIafrlqKf7mlvyNGBFQ7GjwJrCtoE/FPLzTa0j2udCTrG1V55NudFIMCxqG4NcEoGb82qvCOQ7HkBHJCeFrrRBpW/F03njKHJ0/pjeDVgyBDZ7JmyJSE+Q0XsAgvsjDtGKVEjhKzXl807iZlka7H2kg7L8GtxRFx5i6hDYEaE9J8zm7RburaZbqR/ro2LS5slBkH4HF4TApfl7oTBylHK1wOqJYfzIitF1+D+u5OCyW1QBwEhrQHkM3bGt8B1pHWg5u8/OIn8U/FQ4QuXovSWKoFaLS69wksqPFtCCRb2/JI67njWZxJgi20J/b8y+08fMemxj32SPzbLW4ZearKjHCKj+mHaa0VOKevkuhGEL3oyj+yiZSQdKIO1GGkWMAEV1IU0ToggfQHmW/JzQ1bcFHZIo8yINDyCWFe1l3RsWYmDu7fdXgDwafeI0kbXRkV2HNucfAx6HNwsBaN4yGxe9qRysdfWplDQjKpqO1US78x1NaH1zwh/fuTIb9tPy6tViPsckmxFEvnD9RlXq/q26yEMP7GsB934rUdZkoJsRQsg6OzoKbSQrMwmhz6q52B2iLx8OzfDNjIueL/rlWXT6avBYOj12gIudR7zqnIvPM1/rz/VJ/5b6ds3E76yvTXaMBT/DFFtBXhXMdJPCa4f0NBB5Tw110/bN7zJm3MalCIKwEdWd0krGHEW3jx9+auSO4msrQ/5q/txOMCKN+r34O4kMLnwu0hTLy qeinGhii HfGsSnpT/rXHqA7IEmgk60JM8lpri4wK/OK1o8PTB774VZ7ZMSxJ68auR6mPJSBbFGc4t4R0FvcrWEbEGr3zKAFl/NSLXSNpkdUjtiS56ob9MH12iDchJwumvq/0n5YXtAt/tYkddzi+8/lI2HDyTLsFbd7ox91zTrxsbny3ezWZAqM7WAymxJt3iHqzFyi+9JsyMBEIkuT7TgZfn+mVU7EmpGhu2NlQx1U496CNwK2WBAXRy7oXcuCJDsSRPLaMKvYH0zL8nyqaos/7i2eSZMgpfftLHDNErv4uNa+XyS0JDk89rS6lL+FvbY+lEbkeZvg4VLUq5xKQHkRelfmtW8HXjgg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 5, 2025 at 1:07=E2=80=AFPM Suren Baghdasaryan wrote: > > On Thu, Jun 5, 2025 at 12:01=E2=80=AFPM Casey Chen wrote: > > > > The empty MOD_CODETAG_SECTIONS() macro added an incomplete .data > > section in module linker script, which caused symbol lookup tools > > like gdb to misinterpret symbol addresses e.g., __ib_process_cq > > incorrectly mapping to unrelated functions like below. > > > > (gdb) disas __ib_process_cq > > Dump of assembler code for function trace_event_fields_cq_schedule: > > > > Removing the empty section restores proper symbol resolution and > > layout, ensuring .data placement behaves as expected. > > Hmm. I'm not sure why an empty .data section would cause such an > issue. Is that expected behavior? > I'm not sure that's why I am posting this to ask for ideas. It looks like gdb failed to disassemble function. > To clarify, codetags are designed to support different types of tags, > not only allocation tags which we currently use. It so happens that > allocation tags can be still used after module unload, therefore they > are placed into MOD_SEPARATE_CODETAG_SECTIONS(). If some other tags > are added in the future and their lifecycle is the same as modules > (IOW after module unload they can be unloaded too), then they would be > added into MOD_CODETAG_SECTIONS() but until then this section is > empty. > Could we remove the empty data section with MOD_CODETAG_SECTIONS() for now until we really need it ? > > > > Fixes: 22d407b164ff ("lib: add allocation tagging support for memory al= location profiling") > > Signed-off-by: Casey Chen > > Reviewed-by: Yuanyuan Zhong > > --- > > scripts/module.lds.S | 5 ----- > > 1 file changed, 5 deletions(-) > > > > diff --git a/scripts/module.lds.S b/scripts/module.lds.S > > index 711c6e029936..c071ca4beedd 100644 > > --- a/scripts/module.lds.S > > +++ b/scripts/module.lds.S > > @@ -50,17 +50,12 @@ SECTIONS { > > .data : { > > *(.data .data.[0-9a-zA-Z_]*) > > *(.data..L*) > > - MOD_CODETAG_SECTIONS() > > } > > > > .rodata : { > > *(.rodata .rodata.[0-9a-zA-Z_]*) > > *(.rodata..L*) > > } > > -#else > > - .data : { > > - MOD_CODETAG_SECTIONS() > > - } > > #endif > > MOD_SEPARATE_CODETAG_SECTIONS() > > } > > -- > > 2.34.1 > >