From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f70.google.com (mail-oi0-f70.google.com [209.85.218.70]) by kanga.kvack.org (Postfix) with ESMTP id E1EAF6B02FD for ; Thu, 22 Jun 2017 14:10:32 -0400 (EDT) Received: by mail-oi0-f70.google.com with SMTP id 6so12951346oik.11 for ; Thu, 22 Jun 2017 11:10:32 -0700 (PDT) Received: from mail.kernel.org (mail.kernel.org. [198.145.29.99]) by mx.google.com with ESMTPS id c63si743489oih.390.2017.06.22.11.10.32 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Jun 2017 11:10:32 -0700 (PDT) Received: from mail-ua0-f178.google.com (mail-ua0-f178.google.com [209.85.217.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 79E9F22B6C for ; Thu, 22 Jun 2017 18:10:31 +0000 (UTC) Received: by mail-ua0-f178.google.com with SMTP id g40so23432334uaa.3 for ; Thu, 22 Jun 2017 11:10:31 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: From: Andy Lutomirski Date: Thu, 22 Jun 2017 11:10:10 -0700 Message-ID: Subject: Re: [PATCH v3 11/11] x86/mm: Try to preserve old TLB entries using PCID Content-Type: text/plain; charset="UTF-8" Sender: owner-linux-mm@kvack.org List-ID: To: Nadav Amit Cc: Andy Lutomirski , X86 ML , "linux-kernel@vger.kernel.org" , Borislav Petkov , Linus Torvalds , Andrew Morton , Mel Gorman , "linux-mm@kvack.org" , Rik van Riel , Dave Hansen , Arjan van de Ven , Peter Zijlstra On Thu, Jun 22, 2017 at 9:09 AM, Nadav Amit wrote: > Andy Lutomirski wrote: > >> >> --- a/arch/x86/mm/init.c >> +++ b/arch/x86/mm/init.c >> @@ -812,6 +812,7 @@ void __init zone_sizes_init(void) >> >> DEFINE_PER_CPU_SHARED_ALIGNED(struct tlb_state, cpu_tlbstate) = { >> .loaded_mm = &init_mm, >> + .next_asid = 1, > > I think this is a remainder from previous version of the patches, no? It > does not seem necessary and may be confusing (ctx_id 0 is reserved, but not > asid 0). Hmm. It's no longer needed for correctness, but init_mm still lands in slot 0, and it seems friendly to avoid immediately stomping it. Admittedly, this won't make any practical difference since it'll only happen once per cpu. > > Other than that, if you want, you can put for the entire series: > > Reviewed-by: Nadav Amit > Thanks! -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org