From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx195.postini.com [74.125.245.195]) by kanga.kvack.org (Postfix) with SMTP id 7CE8A6B0068 for ; Sat, 22 Dec 2012 03:43:51 -0500 (EST) Received: by mail-vc0-f179.google.com with SMTP id p1so5886083vcq.24 for ; Sat, 22 Dec 2012 00:43:50 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20121222082933.GA26477@infradead.org> References: <6b22b806806b21af02b70a2fa860a9d10304fc16.1356124965.git.luto@amacapital.net> <20121222082933.GA26477@infradead.org> From: Andy Lutomirski Date: Sat, 22 Dec 2012 00:43:30 -0800 Message-ID: Subject: Re: [PATCH v2 2/3] mm: Update file times when inodes are written after mmaped writes Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Linux FS Devel , Dave Chinner , Jan Kara , Al Viro On Sat, Dec 22, 2012 at 12:29 AM, Christoph Hellwig wrote: > NAK, we went through great trouble to get rid of the nasty layering > violation where the VM called file_update_time directly just a short > while ago, reintroducing that is a massive step back. > > Make sure whatever "solution" for your problem you come up with keeps > the file update in the filesystem or generic helpers. > There's an inode operation ->update_time that is called (if it exists) in these patches to update the time. Is that insufficient? I could add a new inode operation ->modified_by_mmap that would be called in mapping_flush_cmtime if that would be better. The original version of this patch did the update in ->writepage and ->writepages, but that may have had lock ordering issues. (I wasn't able to confirm that there was any actual problem.) --Andy -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org