From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ve0-f173.google.com (mail-ve0-f173.google.com [209.85.128.173]) by kanga.kvack.org (Postfix) with ESMTP id 80A936B0036 for ; Thu, 15 May 2014 15:46:56 -0400 (EDT) Received: by mail-ve0-f173.google.com with SMTP id pa12so1932552veb.18 for ; Thu, 15 May 2014 12:46:56 -0700 (PDT) Received: from mail-ve0-f172.google.com (mail-ve0-f172.google.com [209.85.128.172]) by mx.google.com with ESMTPS id rn1si1107495vec.186.2014.05.15.12.46.55 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 15 May 2014 12:46:56 -0700 (PDT) Received: by mail-ve0-f172.google.com with SMTP id oz11so1951443veb.3 for ; Thu, 15 May 2014 12:46:55 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20140515084558.GI28328@moon> References: <53739201.6080604@oracle.com> <20140514132312.573e5d3cf99276c3f0b82980@linux-foundation.org> <5373D509.7090207@oracle.com> <20140514140305.7683c1c2f1e4fb0a63085a2a@linux-foundation.org> <5373DBE4.6030907@oracle.com> <20140514143124.52c598a2ba8e2539ee76558c@linux-foundation.org> <20140514221140.GF28328@moon> <20140515084558.GI28328@moon> From: Andy Lutomirski Date: Thu, 15 May 2014 12:46:34 -0700 Message-ID: Subject: Re: mm: NULL ptr deref handling mmaping of special mappings Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Cyrill Gorcunov Cc: Andrew Morton , Sasha Levin , "linux-mm@kvack.org" , Dave Jones , LKML , Pavel Emelyanov On Thu, May 15, 2014 at 1:45 AM, Cyrill Gorcunov wrote: > On Wed, May 14, 2014 at 03:23:27PM -0700, Andy Lutomirski wrote: >> I can summarize: >> >> On 3.14 and before, the vdso is just a bunch of ELF headers and >> executable data. When executed by 64-bit binaries, it reads from the >> fixmap to do its thing. That is, it reads from kernel addresses that >> don't have vmas. When executed by 32-bit binaries, it doesn't read >> anything, since there was no 32-bit timing code. >> >> On 3.15, the x86_64 vdso is unchanged. The 32-bit vdso is preceded by >> a separate vma containing two pages worth of time-varying read-only >> data. The vdso reads those pages using PIC references. > > Andy, could you please point me where is the code which creates a second vma? > latest 3.15 master branch Search for _install_special_mapping in arch/x86/vdso. It's in a different place in 3.15-rc and -next. > > [root@fc ~]# cat /proc/self/maps > ... > 7fff57b6e000-7fff57b8f000 rw-p 00000000 00:00 0 [stack] > 7fff57bff000-7fff57c00000 r-xp 00000000 00:00 0 [vdso] > ffffffffff600000-ffffffffff601000 r-xp 00000000 00:00 0 [vsyscall] > [root@fc ~]# > What version and bitness is this? > Or you mean vsyscall area? If yes, then in criu we don't dump vsyscall zone. > On restore we don't touch vsyscall either but for vdso there are two cases vsyscalls are almost gone now :) > > - if there were no kernel change on vdso contents we simply use vdso provided > by the kernel at the moment of criu startup > > - if vdso has been changed and looks different from one saved in image during > checkpoint, we map it from image but then patch (push jmp instruction) so > when application calls for some of vdso function it jumps into vdso code > saved in image and then jumps into vdso mapped by the kernel (ie kind of > proxy calls) This force us to do own Elf parsing inside criu to calculate > proper offsets. Yuck :) --Andy -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org