From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A174C11F69 for ; Thu, 1 Jul 2021 00:44:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EC5CC61469 for ; Thu, 1 Jul 2021 00:44:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC5CC61469 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 49A176B0083; Wed, 30 Jun 2021 20:44:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 44A756B0085; Wed, 30 Jun 2021 20:44:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2EB9A8D01D0; Wed, 30 Jun 2021 20:44:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0251.hostedemail.com [216.40.44.251]) by kanga.kvack.org (Postfix) with ESMTP id 0C9E16B0083 for ; Wed, 30 Jun 2021 20:44:51 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id BFD7325F4F for ; Thu, 1 Jul 2021 00:44:50 +0000 (UTC) X-FDA: 78312173940.23.7D01058 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf16.hostedemail.com (Postfix) with ESMTP id 78E19F00008E for ; Thu, 1 Jul 2021 00:44:50 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 82CFC61481 for ; Thu, 1 Jul 2021 00:44:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625100289; bh=KzOU5etl1m1d6bSza+N7XM/HsZQCAVW9hItb7YjwLWk=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=N2RgWghdU3Wjk0w7uX34y3R7WCDtq6wpIcfVtTGOZXgg6StM2NPvRnOVHTSNDlBxf rLUFaJmoWYpkTESon4nh0mWN4lstECAf+OSKCyl+G+4ApLdrrfJazkMQM+lPjq3beA xaRpKBvwpLwK3elynEhze4gxmm7tf1TQvVwWqAPX2emNoka+Mu40/V2chhbSCXfqr2 46s0mLAHxuIBFCE9VojFiGnj0AudiNgly5D6P1UixxT0FudQCStax9hewXysweFeYk Hz+LC1sI9x3Sd36i8ckMri6r37To/8Lc576JaFjf7hpsXfqtTEHtCTF9xE4ivzy3Rr lmpyfJ4RBQiPQ== Received: by mail-ej1-f43.google.com with SMTP id gt10so6002065ejc.5 for ; Wed, 30 Jun 2021 17:44:49 -0700 (PDT) X-Gm-Message-State: AOAM531MeCaNr/iry00Sp3S5XaKHkGOJH45TgHbZxuURzSw4+dDwyXWh efWQ0xFzHibU4aFeHUsu7LSoWhj7SCynlxWlpGX2Dg== X-Google-Smtp-Source: ABdhPJzAb4C5+RtXDup6dhfGpilzWVw9K1ZS6+rN2ZPScS4npWvUVa7PsUSb5+URoJ6pBUECpl3Clp6njJO4GDxxVmc= X-Received: by 2002:a17:907:1c98:: with SMTP id nb24mr17429770ejc.316.1625100287892; Wed, 30 Jun 2021 17:44:47 -0700 (PDT) MIME-Version: 1.0 References: <20210623192822.3072029-1-surenb@google.com> In-Reply-To: From: Andy Lutomirski Date: Wed, 30 Jun 2021 17:44:36 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/1] mm: introduce process_reap system call To: Johannes Weiner Cc: Suren Baghdasaryan , Andy Lutomirski , Andrew Morton , Michal Hocko , Michal Hocko , David Rientjes , Matthew Wilcox , Roman Gushchin , Rik van Riel , Minchan Kim , Christian Brauner , Christoph Hellwig , Oleg Nesterov , David Hildenbrand , Jann Horn , Shakeel Butt , Tim Murray , Linux API , Linux-MM , LKML , Android Kernel Team Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=N2RgWghd; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf16.hostedemail.com: domain of luto@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=luto@kernel.org X-Rspamd-Server: rspam02 X-Stat-Signature: pgydwewzikdjnfftzdxc6yrajr5dqsgd X-Rspamd-Queue-Id: 78E19F00008E X-HE-Tag: 1625100290-442594 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 30, 2021 at 2:45 PM Johannes Weiner wrote: > > On Wed, Jun 30, 2021 at 11:51:36AM -0700, Suren Baghdasaryan wrote: > > On Wed, Jun 30, 2021 at 11:26 AM Andy Lutomirski wrote: > > > Also, please consider removing all mention of the word "reap" from the > > > user API. For better or for worse, "reap" in UNIX refers to what > > > happens when a dead task gets wait()ed. I sincerely wish I could go > > > back in time and gently encourage whomever invented that particular > > > abomination to change their mind, but my time machine doesn't work. > > > > I see. Thanks for the note. How about process_mem_release() and > > replacing reap with release everywhere? > > I don't quite understand the objection. This syscall works on tasks > that are at the end of their life, right? Isn't something like > process_mreap() establishing exactly the mental link we want here? > Release is less descriptive for what this thing is to be used for. For better or for worse, "reap" means to make a zombie pid go away. >From the description, this new operation takes a dying process (not necessarily a zombie yet) and aggressively frees its memory. This is a different optioneration. How about "free_dying_process_memory"?