From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8312DC43466 for ; Sat, 19 Sep 2020 16:23:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0809121582 for ; Sat, 19 Sep 2020 16:23:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="YUs5z6A+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0809121582 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 78BCE6B005A; Sat, 19 Sep 2020 12:23:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 761116B005C; Sat, 19 Sep 2020 12:23:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 678A06B005D; Sat, 19 Sep 2020 12:23:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0028.hostedemail.com [216.40.44.28]) by kanga.kvack.org (Postfix) with ESMTP id 52F6C6B005A for ; Sat, 19 Sep 2020 12:23:38 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 25651180AD804 for ; Sat, 19 Sep 2020 16:23:38 +0000 (UTC) X-FDA: 77280331716.21.rail68_050bc3727135 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin21.hostedemail.com (Postfix) with ESMTP id F37F6180442C4 for ; Sat, 19 Sep 2020 16:23:37 +0000 (UTC) X-HE-Tag: rail68_050bc3727135 X-Filterd-Recvd-Size: 3612 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf25.hostedemail.com (Postfix) with ESMTP for ; Sat, 19 Sep 2020 16:23:37 +0000 (UTC) Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 15E7E2344C for ; Sat, 19 Sep 2020 16:23:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600532616; bh=yIMDaLtf/+YFizwPnR8klP42GqyYZ5ElGRoZQu6X97M=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=YUs5z6A+jbyOjViAggfd75LfVJAXVlL6S70XXy/bSyZscAbDzqAWG4OVuiRPoKllX 8iDAYtkYLMWVWSGiZALQNnGWPtgEG54QgPP0UeehdM25bePxbkLBmtaA7MbAPhserV gTh/eYz4pD8V9OCDj3Y0DZjZnifKA2vn2zkFrfDg= Received: by mail-wm1-f54.google.com with SMTP id q9so8095930wmj.2 for ; Sat, 19 Sep 2020 09:23:36 -0700 (PDT) X-Gm-Message-State: AOAM53178TLeVVClOZYyQFBklqLx5/Tuh6rczAF22dGm5jP9w0W6K1fJ whK3LoyeE9SvIZWGtvD04rzCn7aPCHNAbsuyt+optA== X-Google-Smtp-Source: ABdhPJwlQQiwz+pgI03nF2aOSUVgWBn9X9k20I0J0W3TutdYI4/0CQ+JWWhM7EREU/GlWxV9KL8iEAPcgKTxRTyI700= X-Received: by 2002:a1c:7e15:: with SMTP id z21mr21042180wmc.21.1600532614589; Sat, 19 Sep 2020 09:23:34 -0700 (PDT) MIME-Version: 1.0 References: <20200918132439.1475479-1-arnd@arndb.de> <20200918132439.1475479-2-arnd@arndb.de> <20200919053514.GI30063@infradead.org> In-Reply-To: <20200919053514.GI30063@infradead.org> From: Andy Lutomirski Date: Sat, 19 Sep 2020 09:23:22 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/4] x86: add __X32_COND_SYSCALL() macro To: Christoph Hellwig Cc: Arnd Bergmann , Alexander Viro , Eric Biederman , Andrew Morton , LKML , linux-arm-kernel , linux-arch , Linux-MM , kexec@lists.infradead.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , Andy Lutomirski , Christoph Hellwig , Brian Gerst Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 18, 2020 at 10:35 PM Christoph Hellwig wrote: > > On Fri, Sep 18, 2020 at 03:24:36PM +0200, Arnd Bergmann wrote: > > sys_move_pages() is an optional syscall, and once we remove > > the compat version of it in favor of the native one with an > > in_compat_syscall() check, the x32 syscall table refers to > > a __x32_sys_move_pages symbol that may not exist when the > > syscall is disabled. > > > > Change the COND_SYSCALL() definition on x86 to also include > > the redirection for x32. > > > > Signed-off-by: Arnd Bergmann > > Adding the x86 maintainers and Brian Gerst. Brian proposed another > problem to the mess that most of the compat syscall handlers used by > x32 here: > > https://lkml.org/lkml/2020/6/16/664 > > hpa didn't particularly like it, but with your and my pending series > we'll soon use more native than compat syscalls for x32, so something > will need to change.. I'm fine with either solution.