linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andy Lutomirski <luto@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Andy Lutomirski <luto@kernel.org>, Ingo Molnar <mingo@kernel.org>,
	Borislav Petkov <bp@alien8.de>, Brian Gerst <brgerst@gmail.com>,
	Denys Vlasenko <dvlasenk@redhat.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Josh Poimboeuf <jpoimboe@redhat.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Rik van Riel <riel@redhat.com>,
	Daniel Gruss <daniel.gruss@iaik.tugraz.at>,
	Hugh Dickins <hughd@google.com>, Kees Cook <keescook@google.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	michael.schwarz@iaik.tugraz.at, moritz.lipp@iaik.tugraz.at,
	richard.fellner@student.tugraz.at
Subject: Re: [PATCH 2/5] x86/mm/kaiser: Add a banner
Date: Mon, 27 Nov 2017 19:36:40 -0800	[thread overview]
Message-ID: <CALCETrV-vk-49HkOXi6EW0zxzDrCj2DM4N2i33AuX-vGNb0SHg@mail.gmail.com> (raw)
In-Reply-To: <20171127223405.231444600@infradead.org>

On Mon, Nov 27, 2017 at 2:31 PM, Peter Zijlstra <peterz@infradead.org> wrote:
> So we can more easily see if the shiny got enabled.
>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> ---
>  arch/x86/mm/kaiser.c |    2 ++
>  1 file changed, 2 insertions(+)
>
> --- a/arch/x86/mm/kaiser.c
> +++ b/arch/x86/mm/kaiser.c
> @@ -425,6 +425,8 @@ void __init kaiser_init(void)
>         if (!kaiser_enabled)
>                 return;
>
> +       printk("All your KAISER are belong to us\n");
> +

All your incomprehensible academic names are belong to us.

On a serious note, can we please banish the name KAISER from all the
user-facing bits?  No one should be setting a boot option that has a
name based on an academic project called "Kernel Address Isolation to
have Side-channels Efficiently Removed".  We're not efficiently
removing side channels.  The side channels are still very much there.
Heck, the series as currently presented doesn't even rescue kASLR.  It
could*, if we were to finish the work that I mostly started and
completely banish all the normal kernel mappings from the shadow**
tables.  We're rather inefficiently (and partially!) mitigating the
fact that certain CPU designers have had their heads up their
collective arses for *years* and have failed to pay attention to
numerous academic papers documenting that fact.

Let's call the user facing bits "separate user pagetables".  If we
want to make it conditioned on a future cpu cap called
X86_BUG_REALLY_DUMB_SIDE_CHANNELS, great, assuming a better CPU ever
shows up.  But please let's not make users look up WTF "KAISER" means.

* No one ever documented the %*!& side channels AFAIK, so everything
we're talking about here is mostly speculation.

** The word "shadow" needs to die, too.  I know what shadow page
tables are, and they have *nothing* to do with KAISER.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2017-11-28  3:37 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-27 22:31 [PATCH 0/5] KAISER fixlets Peter Zijlstra
2017-11-27 22:31 ` [PATCH 1/5] x86/mm/kaiser: Alternative ESPFIX Peter Zijlstra
2017-11-27 22:39   ` Peter Zijlstra
2017-11-27 22:41   ` Dave Hansen
2017-11-27 22:31 ` [PATCH 2/5] x86/mm/kaiser: Add a banner Peter Zijlstra
2017-11-28  3:36   ` Andy Lutomirski [this message]
2017-11-28  5:03     ` Josh Poimboeuf
2017-11-28  5:23       ` Andy Lutomirski
2017-11-28 12:54     ` Borislav Petkov
2017-11-27 22:31 ` [PATCH 3/5] x86/mm/kaiser: Revert ("Map the entry stack variables") Peter Zijlstra
2017-11-27 22:31 ` [PATCH 4/5] x86/mm/kaiser: Remove superfluous SWITCH_TO_KERNEL Peter Zijlstra
2017-11-27 22:47   ` Dave Hansen
2017-11-27 22:53     ` Peter Zijlstra
2017-11-27 22:31 ` [PATCH 5/5] x86/mm/kaiser: Disable the SYSCALL-64 trampoline along with KAISER Peter Zijlstra
2017-11-27 22:53   ` Dave Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALCETrV-vk-49HkOXi6EW0zxzDrCj2DM4N2i33AuX-vGNb0SHg@mail.gmail.com \
    --to=luto@kernel.org \
    --cc=bp@alien8.de \
    --cc=brgerst@gmail.com \
    --cc=daniel.gruss@iaik.tugraz.at \
    --cc=dave.hansen@linux.intel.com \
    --cc=dvlasenk@redhat.com \
    --cc=hpa@zytor.com \
    --cc=hughd@google.com \
    --cc=jpoimboe@redhat.com \
    --cc=keescook@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=michael.schwarz@iaik.tugraz.at \
    --cc=mingo@kernel.org \
    --cc=moritz.lipp@iaik.tugraz.at \
    --cc=peterz@infradead.org \
    --cc=richard.fellner@student.tugraz.at \
    --cc=riel@redhat.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox