From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f174.google.com (mail-ob0-f174.google.com [209.85.214.174]) by kanga.kvack.org (Postfix) with ESMTP id 09CC86B0253 for ; Tue, 22 Sep 2015 14:03:46 -0400 (EDT) Received: by obbda8 with SMTP id da8so14300054obb.1 for ; Tue, 22 Sep 2015 11:03:45 -0700 (PDT) Received: from mail-ob0-f174.google.com (mail-ob0-f174.google.com. [209.85.214.174]) by mx.google.com with ESMTPS id p187si1704861oih.136.2015.09.22.11.03.45 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Sep 2015 11:03:45 -0700 (PDT) Received: by obbda8 with SMTP id da8so14299769obb.1 for ; Tue, 22 Sep 2015 11:03:45 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1442903021-3893-1-git-send-email-mingo@kernel.org> <1442903021-3893-2-git-send-email-mingo@kernel.org> From: Andy Lutomirski Date: Tue, 22 Sep 2015 11:03:25 -0700 Message-ID: Subject: Re: [PATCH 01/11] x86/mm/pat: Don't free PGD entries on memory unmap Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Linus Torvalds Cc: Ingo Molnar , Linux Kernel Mailing List , linux-mm , Andrew Morton , Denys Vlasenko , Brian Gerst , Peter Zijlstra , Borislav Petkov , "H. Peter Anvin" , Oleg Nesterov , Waiman Long , Thomas Gleixner On Tue, Sep 22, 2015 at 10:41 AM, Linus Torvalds wrote: > On Mon, Sep 21, 2015 at 11:23 PM, Ingo Molnar wrote: >> >> This complicates PGD management, so don't do this. We can keep the >> PGD mapped and the PUD table all clear - it's only a single 4K page >> per 512 GB of memory mapped. > > I'm ok with this just from a "it removes code" standpoint. That said, > some of the other patches here make me go "hmm". I'll answer them > separately. > If we want to get rid of vmalloc faults, then this patch makes it much more obvious that it can be done without hurting performance. > Linus -- Andy Lutomirski AMA Capital Management, LLC -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org