Re: [PATCH v6 1/4] x86: Clean up extable entry format (and free up a bit)

[Andy Lutomirski <luto@amacapital.net>]

On Mon, Jan 4, 2016 at 3:02 PM, Borislav Petkov <bp@alien8.de> wrote:
> On Mon, Jan 04, 2016 at 02:29:09PM -0800, Andy Lutomirski wrote:
>> Josh will argue with you if he sees that :)
>
> Except Josh doesn't need allyesconfigs. tinyconfig's __ex_table is 2K.

If we do the make-it-bigger approach, we get a really nice
simplification.  Screw the whole 'class' idea -- just store an offset
to a handler.

bool extable_handler_default(struct pt_regs *regs, unsigned int fault,
unsigned long error_code, unsigned long info)
{
    if (fault == X86_TRAP_MC)
        return false;

    ...
}

bool extable_handler_mc_copy(struct pt_regs *regs, unsigned int fault,
unsigned long error_code, unsigned long info);
bool extable_handler_getput_ex(struct pt_regs *regs, unsigned int
fault, unsigned long error_code, unsigned long info);

and then shove ".long extable_handler_whatever - ." into the extable entry.

Major bonus points to whoever can figure out how to make
extable_handler_iret work -- the current implementation of that is a
real turd.  (Hint: it's not clear to me that it's even possible
without preserving at least part of the asm special case.)

--Andy

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>