From: Andy Lutomirski <luto@amacapital.net>
To: Dmitry Safonov <dsafonov@virtuozzo.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Dmitry Safonov <0x7f454c46@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@suse.de>,
X86 ML <x86@kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCHv2 2/5] x86/mm: introduce mmap_{,legacy}_base
Date: Tue, 17 Jan 2017 12:27:00 -0800 [thread overview]
Message-ID: <CALCETrUHLpsrB0M3rkrxw8R=6Dto5gFz+enP=W3C6WPDTa36GA@mail.gmail.com> (raw)
In-Reply-To: <20170116123310.22697-3-dsafonov@virtuozzo.com>
On Mon, Jan 16, 2017 at 4:33 AM, Dmitry Safonov <dsafonov@virtuozzo.com> wrote:
> In the following patch they will be used to compute:
> - mmap_base in compat sys_mmap() in native 64-bit binary
> and vice-versa
> - mmap_base for native sys_mmap() in compat x32/ia32-bit binary.
I may be wrong here, but I suspect that you're repeating something
that I consider to be a mistake that's all over the x86 code.
Specifically, you're distinguishing "native" from "compat" instead of
"32-bit" from "64-bit". If you did the latter, then you wouldn't need
the "native" case to work differently on 32-bit kernels vs 64-bit
kernels, I think. Would making this change make your code simpler?
The x86 signal code is the worst offender IMO.
--Andy
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-01-17 20:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-16 12:33 [PATCHv2 0/5] Fix compatible mmap() return pointer over 4Gb Dmitry Safonov
2017-01-16 12:33 ` [PATCHv2 1/5] x86/mm: split arch_mmap_rnd() on compat/native versions Dmitry Safonov
2017-01-16 12:33 ` [PATCHv2 2/5] x86/mm: introduce mmap_{,legacy}_base Dmitry Safonov
2017-01-16 14:28 ` kbuild test robot
2017-01-17 20:27 ` Andy Lutomirski [this message]
2017-01-18 11:26 ` Dmitry Safonov
2017-01-16 12:33 ` [PATCHv2 3/5] x86/mm: fix native mmap() in compat bins and vice-versa Dmitry Safonov
2017-01-16 13:31 ` kbuild test robot
2017-01-16 14:59 ` kbuild test robot
2017-01-17 20:29 ` Andy Lutomirski
2017-01-18 11:33 ` Dmitry Safonov
2017-01-16 12:33 ` [PATCHv2 4/5] x86/mm: for MAP_32BIT check in_compat_syscall() instead TIF_ADDR32 Dmitry Safonov
2017-01-17 20:30 ` Andy Lutomirski
2017-01-18 11:39 ` Dmitry Safonov
2017-01-16 12:33 ` [PATCHv2 5/5] selftests/x86: add test to check compat mmap() return addr Dmitry Safonov
2017-01-17 20:31 ` [PATCHv2 0/5] Fix compatible mmap() return pointer over 4Gb Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALCETrUHLpsrB0M3rkrxw8R=6Dto5gFz+enP=W3C6WPDTa36GA@mail.gmail.com' \
--to=luto@amacapital.net \
--cc=0x7f454c46@gmail.com \
--cc=bp@suse.de \
--cc=dsafonov@virtuozzo.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox