From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f70.google.com (mail-oi0-f70.google.com [209.85.218.70]) by kanga.kvack.org (Postfix) with ESMTP id 1593E6B007E for ; Thu, 16 Jun 2016 13:21:47 -0400 (EDT) Received: by mail-oi0-f70.google.com with SMTP id a64so92659608oii.1 for ; Thu, 16 Jun 2016 10:21:47 -0700 (PDT) Received: from mail-oi0-x232.google.com (mail-oi0-x232.google.com. [2607:f8b0:4003:c06::232]) by mx.google.com with ESMTPS id 66si3279766oie.249.2016.06.16.10.21.46 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Jun 2016 10:21:46 -0700 (PDT) Received: by mail-oi0-x232.google.com with SMTP id d132so79922106oig.1 for ; Thu, 16 Jun 2016 10:21:46 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20160616111053.GA13143@esperanza> References: <24279d4009c821de64109055665429fad2a7bff7.1466036668.git.luto@kernel.org> <20160616111053.GA13143@esperanza> From: Andy Lutomirski Date: Thu, 16 Jun 2016 10:21:26 -0700 Message-ID: Subject: Re: [PATCH 04/13] mm: Track NR_KERNEL_STACK in pages instead of number of stacks Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Vladimir Davydov Cc: Andy Lutomirski , "linux-kernel@vger.kernel.org" , X86 ML , Borislav Petkov , Nadav Amit , Kees Cook , Brian Gerst , "kernel-hardening@lists.openwall.com" , Linus Torvalds , Josh Poimboeuf , Johannes Weiner , Michal Hocko , "linux-mm@kvack.org" On Thu, Jun 16, 2016 at 4:10 AM, Vladimir Davydov wrote: > On Wed, Jun 15, 2016 at 05:28:26PM -0700, Andy Lutomirski wrote: > ... >> @@ -225,7 +225,8 @@ static void account_kernel_stack(struct thread_info *ti, int account) >> { >> struct zone *zone = page_zone(virt_to_page(ti)); >> >> - mod_zone_page_state(zone, NR_KERNEL_STACK, account); >> + mod_zone_page_state(zone, NR_KERNEL_STACK, >> + THREAD_SIZE / PAGE_SIZE * account); > > It won't work if THREAD_SIZE < PAGE_SIZE. Is there an arch with such a > thread size, anyway? If no, we should probably drop thread_info_cache. On a quick grep, I can't find any. I'll add a BUILD_BUG_ON for now. --Andy -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org