From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAEC9C6FD18 for ; Tue, 28 Mar 2023 16:37:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 00D4E6B0071; Tue, 28 Mar 2023 12:37:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EFFDC6B0072; Tue, 28 Mar 2023 12:37:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC7DE6B0074; Tue, 28 Mar 2023 12:37:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C66D46B0071 for ; Tue, 28 Mar 2023 12:37:58 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 91D8280A8B for ; Tue, 28 Mar 2023 16:37:58 +0000 (UTC) X-FDA: 80618863836.26.53D230D Received: from mail-ua1-f49.google.com (mail-ua1-f49.google.com [209.85.222.49]) by imf02.hostedemail.com (Postfix) with ESMTP id D012B80025 for ; Tue, 28 Mar 2023 16:37:54 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=aV1GpKIO; spf=pass (imf02.hostedemail.com: domain of zalbassam@google.com designates 209.85.222.49 as permitted sender) smtp.mailfrom=zalbassam@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680021474; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sAgqfmy3+Sdexvx3MtTk8w4OkaEeTrCc0NuiY1qiHGo=; b=f1m04d3FsCIlgHrbtvhrW2KvbPA/FFl58Eg2lEKJR1smJGky/zIdhp3pdGRKUiTSUgroPj l5yzEcL8OzWHpkTubeJlv2tAxawtmqdcKfaQ3ArQsKnxayglpzbZEcFr7N4tyQSSqYkHp9 vaMcNm50e3d7dX6uGbiPaMSQf+dj0vA= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=aV1GpKIO; spf=pass (imf02.hostedemail.com: domain of zalbassam@google.com designates 209.85.222.49 as permitted sender) smtp.mailfrom=zalbassam@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680021474; a=rsa-sha256; cv=none; b=7M2PSVgiNWwMX+NKUOA5GnV9qAe/dTke9s9Z6RDyMVSnuRU1WmX66bhv8aiVeH8h40NVVV U5e7ZmbU4golLJX2V7560MnUdJDZB1wA2NBOX4fW+wtdqQM8zIT9w3AGInUVwD4+m6vyM1 dcmppwyQO6ZFtpj0SXM99L76gXHc45U= Received: by mail-ua1-f49.google.com with SMTP id 89so9365953uao.0 for ; Tue, 28 Mar 2023 09:37:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1680021474; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=sAgqfmy3+Sdexvx3MtTk8w4OkaEeTrCc0NuiY1qiHGo=; b=aV1GpKIOxu9YUFKPITfmnlrbtURER60HjoFgLTP2d/dB+QwSLaf6KHXNKkOe1QgYJ/ PHr15fkkmSOGDcSOK9useKgPkkzomFv1UXp95rWNhExc2EGkzLn2HDlK4jgXhV8jlMy2 f3wWaZVGMMjgXBZy7Hpx9E3xt08/IttYYa6Q3ORrQrodgQ09N0Jmt0mQA2q4hs9MF9hO PpiwqD6r7C1eqoLCvtnXTYQBuwz6Qmyaf6hVb+BFBdmvrzo03cfhoE49B/fFrdgRNX3N zx/RRVARXJUnQKHQ0AIlibO5UbGhPJ1rPYgGLyyH6gLZ/61TSJ+2mEZguyIw9WRPkGk2 Xn0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680021474; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sAgqfmy3+Sdexvx3MtTk8w4OkaEeTrCc0NuiY1qiHGo=; b=3ZBdukztb1XibCpjmXy9k3tb0a5BBHGNmN+IW3u5RlmSzg1YPBukwciH4C9yUE6gxh UbTQzRZg5BfB8vwFkZ73MvOoHY57k1lKZfPez8l93LfgkUDljOnAZYzO9W/rkG7FYehH aTBL0oIUfmD6VFobgZ4Gz8B1GRnVmDD2HA2637dGwvG1z2jEBhEPJOun+BIC9hz6J4os Ksx24aJG3YoNR8V39EH6Dyf2KEynuGcT33rfCZ9G6TFnCB5h5mE+l1j64YlGOFKvo/Pg gElnxL8PHd522207cjjG/y0PIUNvZf7iIMRshOBQOjypDE7DqEHD2UbWfVv5W746tFwk RlKg== X-Gm-Message-State: AAQBX9eE0Bj6K3wFqYRHGRWYQG3dbFSR2NdZ/pDxYQ161a8pjTf9gHGS afrD0tM2T1G21A46Z7jYL2cejM4bi2J6b0O3DgGppg== X-Google-Smtp-Source: AKy350Yt+tNqzzmeb5s50dpmAcB50sxxAS+/O4PEQZqs8OpCwgLX/yhM4sXU4TfO+/MEwUteGCYQjtBe3CxRNzqbMxg= X-Received: by 2002:a05:6130:c91:b0:68a:a9d:13f5 with SMTP id ch17-20020a0561300c9100b0068a0a9d13f5mr11175613uab.1.1680021473774; Tue, 28 Mar 2023 09:37:53 -0700 (PDT) MIME-Version: 1.0 References: <202303281539.zzI4vpw1-lkp@intel.com> <20230328122138.GA1275@willie-the-truck> <86o7ocx51a.wl-maz@kernel.org> In-Reply-To: <86o7ocx51a.wl-maz@kernel.org> From: Zaid Al-Bassam Date: Tue, 28 Mar 2023 12:37:42 -0400 Message-ID: Subject: Re: [linux-next:master 6577/7309] drivers/perf/arm_pmuv3.c:44:2: error: use of undeclared identifier 'PERF_MAP_ALL_UNSUPPORTED' To: Marc Zyngier Cc: Arnd Bergmann , Will Deacon , kernel test robot , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: D012B80025 X-Stat-Signature: zii9iabhawbd5ea7km96kjp3qj4c9ng8 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1680021474-751465 X-HE-Meta: U2FsdGVkX197KRXgdQYQmz/MIxFUfo+q5nzt2e7Wfso+ZHfGE5q1q/O0nSn0yVpiOuB35E4plcZhyudXwnNn9yShnu3FF7MMEmuIUspr8WHDVj+redg8fQZhOj8xKJwGgcozhYBrKIGQpzActjAYaY9CJM5sojkfiP8RhOAkIcvxkz8+uWkiV/aXEzZoR/9SBuwBFpnpn/uxmw8nC1xUIzHQ875VwH1dK2w3QM8Px83A0pOuSSvoFLmNwcnhVcoKnAaP7ZpRGCTG1ng77zVDJasT7CgB4WlGey8zCQgyeE5c5wKMh87bPEwbFJSWTC/rZ7pRczFzyYnqbHajSTsitaTphsua5LB0+BLGdgEL7TFcPQV0z7QTIt2g6cN4Ry+BmJ7zqDf03UMqrA6FLDUtcHKJ1ESidQUBiWLTjmRh5pdRSBn8YsjNeMbhayRWsy6m4RSnX7odsJICPPvIfmPsvwbYZlgpCC5sGLTMVica2QiVEBjW/U9Oi6uNWFeykhcr1gQ0xTfP8Gw3Vs5ng+XlNQITH5aMYZX+kXIaYERxrgeEEIdh5W1423C4qUDCiHGT2mzRUnSLyHFY8Gy2XN041wwPQtAwX3HokEC4eCjnsvhx/M3NSvsFmTd3wqOS7M6euSuXKebM2t90AWPdCYE/w2DAQR73VJcgfcicEP+ioDC29lJHzltHl03HqmtZKVgImivJbxi40Sj2fHHHNZL0wpQ5EQoh3kla4yRFbNngqu07UB08Ao406U3w+jd/XsBJNw9JYWUgQcO+jOA7nj/+b5ZLm0pX6CggGhI/G7w1zO7LGfmWKNHC1UEwP00AbPs7SVNUbBZrDbEXA9WUcXZBSqsiD9woMHkvQS0wjgMFTtaBHBrNBIoRSipgRmFGS6AXCi9fjZI1pm9K+SEvFgrmE3HHybfzNgG4I9Dt/P/gLkDKUsrpsBPQdX3y1dsJrIVp4H/AlpBx+ONiLv1lUmF bOqKNghL mvPWvS5wOP75H7VDEzedVcliXSfQ9i3UPJ6MFV2c5vDIGlMhFAR5Xb2SCoGXTMQ8aO0XOQc1kdKIk3J17OcD6/rlfpRR6rc1HCFHjb/DK0SDgMwyIVR9H3wZKHEG5BqoM6u14lC+DT1K0lpvZy8l9V7K4uLPwMh8doadnJzScWVSAN6uYNGJD1HrPW4+SKYJdLzF3HcLIVyh9goOIgn/bIl7TMLvYVaEKEoQT8mbyh8GMpfNsJ7HtFHCMO37Kg8i5mEgRRB/ElvfyCRi78swYs4tQVomd2ibrA4fppr/7hhwTMfU8FfwzJMPzwgVoENoKSnTWj0DqiTCVbgQRTbD4I96B+BuQDNQh1svx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Thank you Marc. Arnd, Do you want to change your patch to drop [1], or should I create a new patch? Btw, Thank you for the patch. [1] https://git.kernel.org/pub/scm/linux/kernel/git/will/linux.git/commit/?= id=3D3b16f6268e66 Zaid On Tue, Mar 28, 2023 at 11:35=E2=80=AFAM Marc Zyngier wrot= e: > > On Tue, 28 Mar 2023 16:29:07 +0100, > "Arnd Bergmann" wrote: > > > > On Tue, Mar 28, 2023, at 14:21, Will Deacon wrote: > > > On Tue, Mar 28, 2023 at 04:01:49PM +0800, kernel test robot wrote: > > > > > I think the Kconfig warning is relevant here: > > > > > >> Kconfig warnings: (for reference only) > > >> WARNING: unmet direct dependencies detected for ARM_PMUV3 > > >> Depends on [n]: PERF_EVENTS [=3Dy] && HW_PERF_EVENTS [=3Dn] && (A= RM [=3Dy] && CPU_V7 [=3Dy] || ARM64) > > >> Selected by [y]: > > >> - ARCH_VIRT [=3Dy] && ARCH_MULTI_V7 [=3Dy] && PERF_EVENTS [=3Dy] > > > > > > Since we're selecting an option which has its own dependencies. I thi= nk > > > the easiest bet is to invert the linkage so that PMUV3 has a dependen= cy > > > on ARCH_VIRT for 32-bit Arm (diff below). > > > > > > Marc, Zaid -- what do you think? > > > > I think dropping the 'select' is best, as this is still a user-visible > > option. How about this instead: > > > > --- a/drivers/perf/Kconfig > > +++ b/drivers/perf/Kconfig > > @@ -103,7 +103,7 @@ config ARM_SMMU_V3_PMU > > config ARM_PMUV3 > > depends on HW_PERF_EVENTS && ((ARM && CPU_V7) || ARM64) > > bool "ARM PMUv3 support" if !ARM64 > > - default ARM64 > > + default ARM64 || ARCH_VIRT > > help > > Say y if you want to use the ARM performance monitor unit (PM= U) > > version 3. The PMUv3 is the CPU performance monitors on ARMv8 > > > > This way, it's still enabled by default for most people, but > > there is no dependency problem and it's also possible to > > turn it off. > > [removing my old self from the Cc list] > > Either way work for me. Or even drop that patch altogether and let > people select PMUv3 if they really want it. This is extremely niche > anyway, and most people won't care. > > Thanks, > > M. > > -- > Without deviation from the norm, progress is not possible.