From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1403C4724C for ; Fri, 1 May 2020 18:42:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 850BD21775 for ; Fri, 1 May 2020 18:42:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Sqk3ZNvO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 850BD21775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 206498E0005; Fri, 1 May 2020 14:42:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B5848E0001; Fri, 1 May 2020 14:42:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A5AE8E0005; Fri, 1 May 2020 14:42:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0068.hostedemail.com [216.40.44.68]) by kanga.kvack.org (Postfix) with ESMTP id E96058E0001 for ; Fri, 1 May 2020 14:42:40 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id B60BD4DCD for ; Fri, 1 May 2020 18:42:40 +0000 (UTC) X-FDA: 76769021280.13.lead46_518c33820ee4a X-HE-Tag: lead46_518c33820ee4a X-Filterd-Recvd-Size: 4227 Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com [209.85.210.68]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Fri, 1 May 2020 18:42:40 +0000 (UTC) Received: by mail-ot1-f68.google.com with SMTP id j26so3322395ots.0 for ; Fri, 01 May 2020 11:42:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yq7Ibs47iQ7Lo5VGMp7gRZ6yUxyqVA2i9kts0jwiLrg=; b=Sqk3ZNvO90q24WbyfeYjeqHXxER0SZRc5xSI5RM5Nuv9B3ZrYEi33jQuT1hGlipWhW hvfe10Z7MjuWVqIgFIGCh1vX61lDdIWshuPxlhpxYvSGgIykaDH4wYq9CcG9PYvJCxnG Qod+n3wh9PZsgmkcNsHVm4KLG8FyyBIFO8o+o+M0pbZrNFM0eWtfAF6okflgipvcQ1k0 ZpKOab+w3go1VnlFI2C/NWHJFgBePuy+8oTNmaHzdoaXKkj+5vcaptuIxg4ethg4nCCg oe12HiqThde5msD1xr4IG5FgmGjSqY+lbxjSPwdLZoqN9ONczywqxt+3yssPl4cyaexa 9RFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yq7Ibs47iQ7Lo5VGMp7gRZ6yUxyqVA2i9kts0jwiLrg=; b=kENizGny2YzJnD8jQi1gdnSrZhjiQHVc3Y5KP08SOldbhaScOLTgWB3oevjbVDxEuY hMCRHgF94/e0yY4cRYzjRrEGdfJE4hJ+at3TaVDJA9ss5yx0/UBorEQrzhU0Zmer0y0q m2+0sG35N6i6KpfQ82n3dnyyYwhCCYlTg/VdRyvA84yA+OBCegLpixodtwbg/oXBo3FD 86iKZQCJ1mcVwgkDcLFPQgetdNrUFRrBTe+G2+XYpei2Mu8lEYQK8lKFcHmOp0GFXhcO +Ibw2eJojFTb81Zv7UOaPNWnin/5NI1Ywjp2bsoEI+zn+7qbifrSo2mUGQqzK+HhFJMr CzIw== X-Gm-Message-State: AGi0PuZguSgSG53YrDpP8RRceH9f1l8LmjqNNQZvCqaG+hWIUDvu8hj3 DmYCMbcy7/wPz9DX0zY2Tv74FV4BPH2L7OBjk7s03w== X-Google-Smtp-Source: APiQypL+VkyGnMilOhi+kaL79AKLY56zEToU7HIKl+3eFaVpJsUVoYecvtEHrqDQsSqZiNr1DTrBBFivrPw2tyNZtok= X-Received: by 2002:a05:6830:1589:: with SMTP id i9mr4948265otr.102.1588358559590; Fri, 01 May 2020 11:42:39 -0700 (PDT) MIME-Version: 1.0 References: <20200501073949.120396-1-john.stultz@linaro.org> <20200501073949.120396-3-john.stultz@linaro.org> <20200501104810.v6oa2yhawr4iki67@DESKTOP-E1NTVVP.localdomain> In-Reply-To: <20200501104810.v6oa2yhawr4iki67@DESKTOP-E1NTVVP.localdomain> From: John Stultz Date: Fri, 1 May 2020 11:42:28 -0700 Message-ID: Subject: Re: [RFC][PATCH 2/4] mm: cma: Add dma_heap flag to cma structure To: Brian Starkey Cc: lkml , Rob Herring , Sumit Semwal , "Andrew F. Davis" , Benjamin Gaignard , Liam Mark , Pratik Patel , Laura Abbott , Chenbo Feng , Alistair Strachan , Sandeep Patil , Hridya Valsaraju , Christoph Hellwig , Marek Szyprowski , Robin Murphy , Andrew Morton , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , dri-devel , linux-mm , nd Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 1, 2020 at 3:48 AM Brian Starkey wrote: > On Fri, May 01, 2020 at 07:39:47AM +0000, John Stultz wrote: > > +bool cma_dma_heap_enabled(struct cma *cma) > > +{ > > + return !!cma->dma_heap; > > Stylistic thing, but I don't think the !! is really necessary. It's > already a bool anyway. Yea, I was using a bit field earlier and then moved to a bool for simplicity and left this. I saw it as soon as I sent the patch, so it's already fixed up. > > @@ -157,6 +167,7 @@ static int __init cma_init_reserved_areas(void) > > } > > core_initcall(cma_init_reserved_areas); > > > > + > > nit: spurious newline Yep. Same. The things you only see once the mail is sent. :) Thanks so much for the review though! -john