From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C25A8C3DA59 for ; Sat, 20 Jul 2024 17:27:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 02D826B0083; Sat, 20 Jul 2024 13:27:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F1FBF6B0085; Sat, 20 Jul 2024 13:27:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E0DAC6B0088; Sat, 20 Jul 2024 13:27:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C38D46B0083 for ; Sat, 20 Jul 2024 13:27:35 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2A65880E06 for ; Sat, 20 Jul 2024 17:27:35 +0000 (UTC) X-FDA: 82360812870.26.1B890D2 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf06.hostedemail.com (Postfix) with ESMTP id C15DE180002 for ; Sat, 20 Jul 2024 17:27:32 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ptJaJ1d1; spf=pass (imf06.hostedemail.com: domain of fdmanana@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=fdmanana@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721496432; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=en41coNvzk4dpk9alJFUPmBFQcFLsq1zjfEDwyf5NPc=; b=3kG0dggFSPQVFHOYtB8tuZEXkKEHJquKxov+VxThZ89bSO3PwypMUWnv1l5luUrw5lvL3t pkozp+FlCEQY+IQ1y9QjvR9j9V9pPDIfbwjSFxG3vXkQatEhLRRKpdnGMDtbSbFWB4qC0p m4aRrSn9/JFOQl4x04SPmUfZIhwRIq0= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ptJaJ1d1; spf=pass (imf06.hostedemail.com: domain of fdmanana@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=fdmanana@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721496432; a=rsa-sha256; cv=none; b=GqA2CFTtuwC+0ZeUOaK8IsR4Yrgz0pPO+CEm/G4a/+yy/KSti0n4212tT5W4Vt6fAse818 pRAxk+cwssQMh5tk0EVB81vdQX6LVSaKPKnjLMSUsC/C48WeD51HGppERmnER8hOREDmaQ Z+v1NKRCw8l/HFIWfkrozMoWPFylEsk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 7425ECE09CD for ; Sat, 20 Jul 2024 17:27:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5C42C4AF0E for ; Sat, 20 Jul 2024 17:27:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721496447; bh=UTJTDTaY+qnqubzTCRfxofaQ3C7yFMD+fihOtl72oSY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ptJaJ1d1OBSxvNAk3kdqNa7OThSg2NQIFMwJq92asDC59lMZSROiLrtiIm6blivNM +X88gNfYS+EK+G/l6JkIqzW3CIuVcdraFKpvz6Bt4Ss1VzjxioVi2JG888qt37h56G GY4slK6OnGvx9Z8TgNAn3mU31hCkjmn1jexSWRUXCNKm2eo38knv1s9CCGMVL5ovS7 Mj29Nrw9WWVjwEmK2GTMSSCNBjYQeHY/IuVmEWKL5QOanu4boT7C0xzoKPa/npKH80 dNz0w0sVlMGIDDir4WF4Zr3m/NeK0Ipg74Bqc0jhIfrO6RUmTVtqJK8iBcXA+jhl4Z yWRFyRyQHFdcQ== Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-58b0beaf703so1848375a12.2 for ; Sat, 20 Jul 2024 10:27:27 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCVht73QnpTVj6Yr/Q1Us3osNweCxcDEp3+HUVTkKNnWEr3h9w6avUcHuY5Ar26gGXoy7KIkmqsPxqc6ZDtaSGNzRuc= X-Gm-Message-State: AOJu0Yzn7NMsNr3K6gCM4inwxvqRPFG6C97BWUlOEiidHSrfyT+/FpAT kF2ve/o143Razx/s9/IkffHWutDF0Hb+7v7lJhgZ7aFEtfVDJcTse9JG/4yojHxgEHLptdjRlK2 dsMUX/BibxUpf9HEprX973jpgP9I= X-Google-Smtp-Source: AGHT+IEfX4vbO7ZsYz7RPnPZl97yq+vWxd0um0lpMgys0EZt9R5flB9TwEyRmSHmLaRcjtfJ+paLO00KOA+4GdDEjP4= X-Received: by 2002:a17:906:448f:b0:a77:cdaa:88ab with SMTP id a640c23a62f3a-a7a01119884mr741609766b.15.1721496446233; Sat, 20 Jul 2024 10:27:26 -0700 (PDT) MIME-Version: 1.0 References: <20240720083538.2999155-1-yangerkun@huawei.com> In-Reply-To: <20240720083538.2999155-1-yangerkun@huawei.com> From: Filipe Manana Date: Sat, 20 Jul 2024 18:26:49 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] generic/736: don't run it on tmpfs To: Yang Erkun Cc: zlang@kernel.org, fstests@vger.kernel.org, linux-mm@kvack.org, hughd@google.com, akpm@linux-foundation.org, linux-btrfs Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: C15DE180002 X-Stat-Signature: dw6yqqxwhj1oqjjc8uthmfkhoep4nqog X-HE-Tag: 1721496452-749079 X-HE-Meta: U2FsdGVkX18dSzCPj3ivogjl+rZISDxbslD6IqKvL0HDipcQ8B6XCF3PsTjbMwK/2QP4V9x9N4TN9uaJX5Z9ezoFua0IqKresRCTycW2yjhAbUGI7zApkMcWjWbdkW+1RpfBSzsBtDAuYdW8Lt7GyCTKqIYZ6+I/XOfFyjCJysyHsfpVOkPfL8+JebyuIHyIenMV5MFaCJWDfn1Zqdd2dFIkmw4a0c4l0RU94qv+bFj1XkuS8E+4DQ1+WiXeR65xAXSYfhL7YhViZFnMzMo7gi/P8D6L/USzJZx5Ct0oV6j71S0hMqSpeVviIM8Ps9Kx1wRjQhmSjpcX4Je472uQkp2+piYbdK2TNPExhGK2p2UGuOCoTVw8TiMzqIjHHqT8QOBtjvRyL7a/cgtgp485pj77l6F+uqNix6mFUuXwH6qRkH78k3ecaOEFMDNZpwwE7xz8PG9MZK1NtT/C9S1yAKCR/rp+Nlun+UniSHb6Tk8wkjA3p5GwY0XA9lRqZEIKESPgzdRX99MhvM9kz+8MMGBi+QM2JeMJDOyWGKIk5mTGH3ZZdOdYVCjM+bhQpHv05jaYqv8wY3e5j7sfrqjWwDDEsiDcE0rG9zv+2TK3YyzBnYW/46IxTCOw45VgOtH3xqrf9kTwO9bE0ohFtMW2lkMB+6tOptWytUX4Vxw0cEeWPlQWEf6mUoqfMrvfMJbNQNFdkzXn1631G6wbuKjX7AcjgFLAoZNvpedzGmO8wE2w1jnBH26Woaq8JD9mWxE8etwIwJmRAGouwoQcs4kP/OhE+d+nffbZgaVbO47EJgkqlIgY+hFK1D1o3TGojaO9ONlkCMG6VSQAqxO9FZR0B6XKY2y25JUI8f6J+sVDJDFPZeVj6HvXOtfFgC1KrzuvCcMXp9hZTpK8zcg9NDS+7fZUsizGfZWWXp/qkZXxIFY1PK/eC5ZloHmGWeu/kmTizlf91B29DUj20aO6Nyk MAvKXZqF W89QZpzzNIMFd5dg3VGiglwk6Yw91dnQ3yCbq62dexttW+HN+9Edd2thgRiF/pb+UPnDHtWsChJVOOHbnd3No/TYFOfBuC521mHq33V8fHLG0HxJZoGBtuv0aMkrHXrv7jNxKEKwgmun8jQVWqF/AOLM7OadNF0AvrjlTC3SFfL45Cox7Ws42JmCBxWbMMxRXVqAq7NjMyTbDheVtFHlxIIKtiemzBErnd/m6Il07dpUEfuIVCV7LglhNddPukTbTosvBVQvs3il3+TLj80hpj1trAm3JVzcG8eCTeKRsPF9Jy/lk/nUzZ3J/oFP7wejk8ujZZA9Cz6ZVO2GgdZWf5eYd9JTsJoDOrxx66Nl8Q9TnqQnLClp2yhVqEcA2uw5AIXgaTaIDQKbbEQ4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000272, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Jul 20, 2024 at 9:38=E2=80=AFAM Yang Erkun w= rote: > > We use offset_readdir for tmpfs, and every we call rename, the offset > for the parent dir will increase by 1. So for tmpfs we will always > fail since the infinite readdir. Having an infinite readdir sounds like a bug, or at least an inconvenience and surprising for users. We had that problem in btrfs which affected users/applications, see: https://lore.kernel.org/linux-btrfs/2c8c55ec-04c6-e0dc-9c5c-8c7924778c35@la= ndley.net/ which was surprising for them since every other filesystem they used/tested didn't have that problem. Why not fix tmpfs? Thanks. > > Signed-off-by: Yang Erkun > --- > tests/generic/736 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/generic/736 b/tests/generic/736 > index d2432a82..9fafa8df 100755 > --- a/tests/generic/736 > +++ b/tests/generic/736 > @@ -18,7 +18,7 @@ _cleanup() > rm -fr $target_dir > } > > -_supported_fs generic > +_supported_fs generic ^tmpfs > _require_test > _require_test_program readdir-while-renames > > -- > 2.39.2 > >