From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C5D2C433FE for ; Thu, 17 Nov 2022 00:09:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B23106B0072; Wed, 16 Nov 2022 19:09:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AD32F6B0073; Wed, 16 Nov 2022 19:09:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 974806B0074; Wed, 16 Nov 2022 19:09:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 88AFA6B0072 for ; Wed, 16 Nov 2022 19:09:31 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 581DBA06B4 for ; Thu, 17 Nov 2022 00:09:31 +0000 (UTC) X-FDA: 80141000142.14.A54C30D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf30.hostedemail.com (Postfix) with ESMTP id E56148000D for ; Thu, 17 Nov 2022 00:09:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668643769; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FGjq0MdMU6XWazmOAjCNlqGiqXJDB81vgEM83tHinGY=; b=a3tjhDpgkOxYc4FWOltgbDgf23kbfYsawlvp813/OVlSsguQCGZL+4ZFhH4NKJvsg2p+DB ZuxWOTXruxl6bXxv9cudJr9XolP6XtTrHRC/gSDEqbgfe/rYcMtdkMgBSalcBcs0poMfT+ c3Z0LrE02XTxbweW9OsOYifAO3Fr4bc= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-29-zFVPEWvDPpmz_gA-ecdbuA-1; Wed, 16 Nov 2022 19:09:27 -0500 X-MC-Unique: zFVPEWvDPpmz_gA-ecdbuA-1 Received: by mail-qv1-f69.google.com with SMTP id mo15-20020a056214330f00b004b96d712bccso222751qvb.22 for ; Wed, 16 Nov 2022 16:09:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FGjq0MdMU6XWazmOAjCNlqGiqXJDB81vgEM83tHinGY=; b=6ZCqid/+KQ12gz1zvXT+MCxck3R47sJ3uUaCVA3A1nSJ7ABZ42RqoYX4fKbwln64VJ VtYx72vrEzH3MBpkZGUgMAdBVE2Zsziq0fZV4k+ebOJ2zYmAoPjC4KLedIcA6lW9RajY QGiKK6Bq/0EYvi5craRmJwvGITTUwh+7Hq7qgkYv+yPaspZeDTR05jzn6kH2kiW4k6XU 9Ym/K1dB+f9uw7hjvBbUHFzikQIIxxCcvvZ0v2AtHQs51ZWIjD8tr2bTpNWsHDr/wmg2 VHyItFBXB+n408GjIxKG4nJFlwSTxbt7XLKre3LrZj3skydnryMe+IJwgNe/qvyG1zoE rbNA== X-Gm-Message-State: ANoB5pnh7ZYIGEaOrFIOhKlSFF5KyA3ppiLDYh3n4oBn5iDQM6tMLO5C lXuGs+qA2cnMMSSDLPDDfTA7VRVdgfzc1VIC4OEbZ7aSWic0xWQk94yDsb2/ZbZIHhEZNPgkBd9 +a1z9KmVNCsuCgNBUZoSRaxzuaCk= X-Received: by 2002:a05:622a:5c96:b0:3a5:2bae:77e9 with SMTP id ge22-20020a05622a5c9600b003a52bae77e9mr300028qtb.318.1668643767343; Wed, 16 Nov 2022 16:09:27 -0800 (PST) X-Google-Smtp-Source: AA0mqf4ov2n9Lo9ecO1GZcp5uHhq7ULv4L0Ef33nCtNCj0ho5JAlvqEedlDWpgx4aEwos7q3kx/r/4ljpKY4GshriVw= X-Received: by 2002:a05:622a:5c96:b0:3a5:2bae:77e9 with SMTP id ge22-20020a05622a5c9600b003a52bae77e9mr300004qtb.318.1668643767050; Wed, 16 Nov 2022 16:09:27 -0800 (PST) MIME-Version: 1.0 References: <20221028132640.2791026-1-jsavitz@redhat.com> <20221108163124.a54f932f8f79f9c1d6e63903@linux-foundation.org> In-Reply-To: <20221108163124.a54f932f8f79f9c1d6e63903@linux-foundation.org> From: Joel Savitz Date: Wed, 16 Nov 2022 20:09:11 -0400 Message-ID: Subject: Re: [PATCH linux-next] selftests/vm: calculate variables in correct order To: Andrew Morton Cc: linux-kernel@vger.kernel.org, Shuah Khan , David Hildenbrand , Nico Pache , linux-mm@kvack.org, linux-kselftest@vger.kernel.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000fdfa1805ed9f6602" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668643770; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FGjq0MdMU6XWazmOAjCNlqGiqXJDB81vgEM83tHinGY=; b=ozEQMoNFG5dv/C6X4FBzd8G/aLB8+V9P77v2+Nma1muxTUOCNRvmNb/rT0A1kWPwx2Zzly 73PIWhFITSWoauX/SnoJKE9Tfov9FGo88Yrx+wELLgOPS/MMiOjhHMxUZOzgk6d/SDgc/x vaaY5d1TNd0XGF11HeUFYr6aPcOI+cw= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=a3tjhDpg; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of jsavitz@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=jsavitz@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668643770; a=rsa-sha256; cv=none; b=1H+1oyXpAyxnXCCMaRdiWfBJBCyAmqdXVFqyG9iSElUM1v9T+/eex1D3LIKaKX0n+Q7Dr7 sjZENMgtlFyiwYuH2H904QoQHCMx2nR0gmv5dT7LGG1zKaCa7o3gp58UvabC61miAXyxqc H3TGvs4+LYPtkrXv3YX/B9UkRBmxFz0= X-Rspam-User: X-Stat-Signature: jtdr9sjty8ks7ug9f1cqy6rjkpimjjhi X-Rspamd-Queue-Id: E56148000D Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=a3tjhDpg; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of jsavitz@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=jsavitz@redhat.com X-Rspamd-Server: rspam07 X-HE-Tag: 1668643769-890997 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --000000000000fdfa1805ed9f6602 Content-Type: text/plain; charset="UTF-8" On Tue, Nov 8, 2022 at 8:31 PM Andrew Morton wrote: > On Fri, 28 Oct 2022 09:26:40 -0400 Joel Savitz wrote: > > > commit b5ba705c2608 ("selftests/vm: enable running select groups of > tests") > > unintentionally reversed the ordering of some of the lines of > > run_vmtests.sh that calculate values based on system configuration. > > Importantly, $hpgsize_MB is determined from $hpgsize_KB, but this later > > value is not read from /proc/meminfo until later, causing userfaultfd > > tests to incorrectly fail since $half_ufd_size_MB will always be 0. > > > > Switch these statements around into proper order to fix the invocation > > of the userfaultfd tests that use $half_ufd_size_MB. > > Does this fix address the failure in > https://lkml.kernel.org/r/202211021026.61b267d1-yujie.liu@intel.com? > > Thanks. > > I have tried to reproduce this failure on a couple of different systems before and after the application of this commit but I haven't had any success in doing so. I suspect that there was some sort of hugepage configuration issue on the test system but I'd have to look into it more to be sure. However, I noticed that on the mm-everything branch, the hugepage-mmap test fails: # ./run_vmtests.sh -t "hugetlb" running: ./hugepage-mmap ----------------------- running ./hugepage-mmap ----------------------- Open failed: No such file or directory [FAIL] ... It appears this is due to commit 0796c7b8be84 ("selftests/vm: drop mnt point for hugetlb in run_vmtests.sh") as the test still replies on the ./huge mountpoint removed in that commit. The test passes before that patchset is applied. Additionally, I just noticed an extraneous 'echo "running: $1"' line in run_test(), the effects of which are seen above, and I have just sent a patch to remove it. Joel --000000000000fdfa1805ed9f6602 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, Nov 8, 2022 at 8:31 PM Andrew Mor= ton <akpm@linux-foundation.= org> wrote:
On Fri, 28 Oct 2022 09:26:40 -0400 Joel Savit= z <jsavitz@redha= t.com> wrote:

> commit b5ba705c2608 ("selftests/vm: enable running select groups = of tests")
> unintentionally reversed the ordering of some of the lines of
> run_vmtests.sh that calculate values based on system configuration. > Importantly, $hpgsize_MB is determined from $hpgsize_KB, but this late= r
> value is not read from /proc/meminfo until later, causing userfaultfd<= br> > tests to incorrectly fail since $half_ufd_size_MB will always be 0. >
> Switch these statements around into proper order to fix the invocation=
> of the userfaultfd tests that use $half_ufd_size_MB.

Does this fix address the failure in
https://lkml.kernel.org/r/2022110= 21026.61b267d1-yujie.liu@intel.com?

Thanks.


I have tried to reproduce this failure= on a couple of different systems before and after the application of this = commit but I haven't had any success in doing so. I suspect that there = was some sort of hugepage configuration issue on the test system but I'= d have to look into it more to be sure.

However, I= noticed that on the mm-everything branch, the hugepage-mmap test fails:

# ./run_vmtests.sh -t "hugetlb"
running= : ./hugepage-mmap
-----------------------
running ./hugepage-mmap
= -----------------------
Open failed: No such file or directory
[FAIL]=
...

It appears this is due to commi= t 0796c7b8be84 ("selftests/vm: drop mnt point for hugetlb in run_vmtes= ts.sh")
as the test still replies on the ./huge mountpoint r= emoved in that commit. The test passes before that patchset is applied.

Additionally, I just noticed an extraneous 'echo = "running: $1"' line in run_test(), the effects of which are s= een above, and I have just sent a patch to remove it.

<= div>Joel
--000000000000fdfa1805ed9f6602--