From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABFFCC43334 for ; Wed, 6 Jul 2022 18:53:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E33F6B0072; Wed, 6 Jul 2022 14:53:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 292F06B0073; Wed, 6 Jul 2022 14:53:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 15B4A6B0074; Wed, 6 Jul 2022 14:53:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 033A86B0072 for ; Wed, 6 Jul 2022 14:53:33 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id D0004603F4 for ; Wed, 6 Jul 2022 18:53:32 +0000 (UTC) X-FDA: 79657573464.12.FE37AB9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 34117A0031 for ; Wed, 6 Jul 2022 18:53:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657133611; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vpKqPCC+dq82KAEepp5QL1jPT12BGJMMiKq0ETkXQgI=; b=ivb4/9gfTcW/ufl+w3CCLqpb1aweipn6RPAvhcy82X0get7z+OL+/ieNE+Bp8TB+SIyYoY tVQ/uEC4vCMCOXnhuXrzAZkuJgDre5fkpRC1rMjtE1ixUvTigU1Iz8csGpg3wB0P54bsyI xIN/sdQHomnzA87SEbOrzOjRhC71Boo= Received: from mail-yw1-f200.google.com (mail-yw1-f200.google.com [209.85.128.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-377-T60FgpTqOGK2EFWzZzGOLQ-1; Wed, 06 Jul 2022 14:53:30 -0400 X-MC-Unique: T60FgpTqOGK2EFWzZzGOLQ-1 Received: by mail-yw1-f200.google.com with SMTP id 00721157ae682-31c9f68d48cso58001997b3.0 for ; Wed, 06 Jul 2022 11:53:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vpKqPCC+dq82KAEepp5QL1jPT12BGJMMiKq0ETkXQgI=; b=jY0Np+g7X+37+jhMZLjk1mKMrWq+XeoOBSPhJNoFa5F9daQL8vHoitCKlYbQ2/oqvI fCLDjH46kfkv4kThcj/jzOk8CZgA2sWAQfq7vf1DAisWKn9m1zp36vPMuWJUD/8BIJ0s KEF0TpUBagcGeIhhzxPPbeE8b3EHlbkmPdasH8QeddIfE4fUSxd085kzgbxfhoL91qF1 HyGoonMMmUJoxBOkd5Z6OlLIbQxEJYH+PBQPt47mlKnckR4bXD6AJBKPN8KO3SgOUKqn oan0Q5Nez16Si2W7KsK77Pnt3zdnwNiOhTr3iPjvxq1V1HbMdAeqAsHw0TewVv2KbLCx 8iBQ== X-Gm-Message-State: AJIora/W0410jbXXnPvtXf5iTbv95F4PORoJmzCvZeOV7BIZn9vIHztR wBMCtaXC3t371wlS6q1Sx1dpoNJ3ZEClv+8t9IGlLld4EW6x9Ia6Sd1zYMRehboyZk8ftBsS4Uf N0dYEN1aao62fby2hw7had5tOSag= X-Received: by 2002:a81:315:0:b0:317:6789:a0c1 with SMTP id 21-20020a810315000000b003176789a0c1mr50398781ywd.378.1657133610006; Wed, 06 Jul 2022 11:53:30 -0700 (PDT) X-Google-Smtp-Source: AGRyM1ukESutasOwQQv+z1C+dhV56B10wsDX/hCRqFQDRXmQvGdZRZ/ZCWAmPTwBAQNixjzF7EcmG5m3Mb5/SjaYnJQ= X-Received: by 2002:a81:315:0:b0:317:6789:a0c1 with SMTP id 21-20020a810315000000b003176789a0c1mr50398765ywd.378.1657133609825; Wed, 06 Jul 2022 11:53:29 -0700 (PDT) MIME-Version: 1.0 References: <20220705185605.3889110-1-jsavitz@redhat.com> <20220705133456.d5572b2e36ebb36188369988@linux-foundation.org> <20220706115031.3c312d9268bf87287be0b8f9@linux-foundation.org> In-Reply-To: <20220706115031.3c312d9268bf87287be0b8f9@linux-foundation.org> From: Joel Savitz Date: Wed, 6 Jul 2022 14:53:14 -0400 Message-ID: Subject: Re: [PATCH] selftests/vm: enable running select groups of tests To: Andrew Morton Cc: Nico Pache , LKML , Shuah Khan , Linux MM , linux-kselftest@vger.kernel.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657133612; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vpKqPCC+dq82KAEepp5QL1jPT12BGJMMiKq0ETkXQgI=; b=nV4fzrM0jeOShrd5l4tzq5PYM2XafxoGZXpIpkWNaU39YMb560EqI3/rtFHs1t83TFgBIq MmyThQzwAiH7IrphxyPypEVLDBGRnFk0wu0CltmfDmmt6RT7o4/W0/m87s1SswmBpTLqUW e/UqcymkgD3OCLevWwBUgnE5CXcq50I= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="ivb4/9gf"; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf25.hostedemail.com: domain of jsavitz@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=jsavitz@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657133612; a=rsa-sha256; cv=none; b=3LSmQzLjaJVJVNGC0TIP9+sj1WovivkXwcS8EkX7QmWDaXxdxdyxFKXqmXVGA07uC/JU5K 9VSP+u59oavwP0myhQv5B6aLth3By2KQnPcxC/kcnGIX2BIyi3fTuj2fWmGWM9Bi1bPPtw tTJ3HguS+AU5Lj6+ZgxAwqZGduGbx5E= X-Rspamd-Server: rspam11 X-Rspam-User: X-Stat-Signature: h134b3zz35t3744enunymup3tbx9hubf X-Rspamd-Queue-Id: 34117A0031 Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="ivb4/9gf"; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf25.hostedemail.com: domain of jsavitz@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=jsavitz@redhat.com X-HE-Tag: 1657133611-792670 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Thanks for the feedback. Will rework and send v2. Best, Joel Savitz On Wed, Jul 6, 2022 at 2:50 PM Andrew Morton wrote: > > On Wed, 6 Jul 2022 14:38:03 -0400 Nico Pache wrote: > > > On Tue, Jul 5, 2022 at 4:35 PM Andrew Morton wrote: > > > > > > On Tue, 5 Jul 2022 14:56:05 -0400 Joel Savitz wrote: > > > > > > > Add the ability to run one or more groups of vm tests (specified > > > > by the environment variable TEST_ITEMS). Preserve existing default > > > > behavior of running all tests when TEST_ITEMS is empty or "default". > > > > > Hi Andrew, > > > > > What is the reason for this? What's the use case? > > > > The current design of vm selftests is all-or-none. We'd like to be > > able to selectively run these tests (We settled for selective groups > > of tests rather than individual tests). > > > > The main reason for doing this is our efforts to expand RedHats MM CI > > testing. There are two use cases for these changes that relate to our > > reasoning: > > 1) Our current CI has overlapping tests between LTP and vm selftests, > > so we'd like a way to prevent running the same test in two places. > > 2) We'd like the ability to skip a test if it is determined to be > > unstable or requires certain hardware requirements. > > > > By adding this functionality we are really expanding what we are able > > to do with the stock vm-selftests. > > OK, please let's get this info into the changelog - it's the most > important part. > > > > And why via the environment rather than via commandline args? > > Just a design choice I suppose. I'm sure Joel would be willing to > > implement it as a cmdline arg if you'd prefer that approach. > > I think that would be best. >