From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84DD7C433FE for ; Thu, 17 Nov 2022 06:30:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB3CC6B0075; Thu, 17 Nov 2022 01:30:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D64068E0003; Thu, 17 Nov 2022 01:30:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B905B8E0002; Thu, 17 Nov 2022 01:30:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A33446B0075 for ; Thu, 17 Nov 2022 01:30:42 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7BDD11208DA for ; Thu, 17 Nov 2022 06:30:42 +0000 (UTC) X-FDA: 80141960724.26.7F76FE2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id BDC2CC000D for ; Thu, 17 Nov 2022 06:30:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668666641; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=77jIXkhrtwqKo94Wqd6nfY0jOcIj75IUYbToBjS3apo=; b=WWU1RpARVrD6uUtA+Z7kSccVQx+mBbhZPiTe5qWDWe8mjGwbNrsTqcwgpUNqjr5hzwqlQU 3V9sqLmNvsKFINufAfjaWcNPv9kZFHEU7VSfBqcYZ6odBzG/37vHEZYsf9WaJgzl4UFSf9 dhfqgqp7yn4fLyPQwjhZdzLUI0thphw= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-122-epLOBGxpPM2WN-3_gsUH4A-1; Thu, 17 Nov 2022 01:30:39 -0500 X-MC-Unique: epLOBGxpPM2WN-3_gsUH4A-1 Received: by mail-qv1-f69.google.com with SMTP id x5-20020ad44585000000b004bb6c687f47so888832qvu.3 for ; Wed, 16 Nov 2022 22:30:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=77jIXkhrtwqKo94Wqd6nfY0jOcIj75IUYbToBjS3apo=; b=zwJu2PBGhcYFw3Csl2J0wzAzQzcvW1nNE725ChJnyd7erjsZZzx1h8njh8jaNyJ8ei rRrgsvL5FkGQod46lXgDa0SZcOiLUV8nuvsj3NEQoSqlzWHlrFGBYgF545bUPIUvtcwZ b41dIHM885z+Viqs4m+oR2+uRC5W80JoQYHsqFBPa8Gn4ipIpeeSxSRRF3F6O4Rq8IwF O73yOv6Yzd6qLQGlNj0ncFzVAGzvOKnIHVPwsUj6AxE00M5CzozLehpt7aZAtfXKf/+u 8qRRZEEg0pCK2t7KN1rqSpEnB2gdw4fJa83VZwgJoviMWBomhS1vZaY+y5Sz+OmhfPc7 W3Tw== X-Gm-Message-State: ANoB5pk2SQK3zr5dUHoLhX0uNipYwld8iWvYktzSpRWWOW1xk3D5MR1a bK0mUsyYfQxpR25SAeZ2g7TMeg4HlTnh5Cx0oZevso+H3z5v4soZKFrtA42fwozKvwJAZWx9GVq D+xfze+e9pKykbWlBAH2f6xWzcJM= X-Received: by 2002:a05:6214:5bc2:b0:4c6:5a5f:3068 with SMTP id lr2-20020a0562145bc200b004c65a5f3068mr1218587qvb.118.1668666639152; Wed, 16 Nov 2022 22:30:39 -0800 (PST) X-Google-Smtp-Source: AA0mqf6C0NFFwpUf6eJNDIZ7Qj/qK3H0M5BCwZM/qzII1WUKiMwE5KDMGj+97/7zqhN2WQwm0YJgcpGI4ay2jU99BPM= X-Received: by 2002:a05:6214:5bc2:b0:4c6:5a5f:3068 with SMTP id lr2-20020a0562145bc200b004c65a5f3068mr1218566qvb.118.1668666638872; Wed, 16 Nov 2022 22:30:38 -0800 (PST) MIME-Version: 1.0 References: <20221028132640.2791026-1-jsavitz@redhat.com> <20221108163124.a54f932f8f79f9c1d6e63903@linux-foundation.org> In-Reply-To: From: Joel Savitz Date: Thu, 17 Nov 2022 02:30:23 -0400 Message-ID: Subject: Re: [PATCH linux-next] selftests/vm: calculate variables in correct order To: Andrew Morton Cc: linux-kernel@vger.kernel.org, Shuah Khan , David Hildenbrand , Nico Pache , linux-mm@kvack.org, linux-kselftest@vger.kernel.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668666642; a=rsa-sha256; cv=none; b=TFUVVsm+lffe0WLEJVmbl02pxdxwjAbml4CKbcnjmgbULubR6zrkdq306TFCaj9ixIFa1O tjnXi28Igt3dIpzcJyPZeXAM24WPuOjZQIKkEd0CvcodjMFfs5SqYvBXrXNeOAPpzFTJ/q UCvOfYF4D/XWKprSocXWrO25K+vQc1E= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WWU1RpAR; spf=pass (imf10.hostedemail.com: domain of jsavitz@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=jsavitz@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668666642; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=77jIXkhrtwqKo94Wqd6nfY0jOcIj75IUYbToBjS3apo=; b=PgY6bZ0bGTQtD2w7K3+UvaNWQIHgRwqLM9R9pFZgvefOkcmehBIDvkj3U3LY7gv7rZ7N/7 ecmEXr0B7z3G+eF1TK4fPVxQczQWfz1dhsMv0H01b/yyY9FrIsNSqCT7OXq7URnAeZzdc+ te8nMQiLqEs5cLSp1Ua5H+ry2ILq8SE= X-Stat-Signature: imbjj13wcrb6ss3j18t1dgd66eyaywec X-Rspamd-Queue-Id: BDC2CC000D Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WWU1RpAR; spf=pass (imf10.hostedemail.com: domain of jsavitz@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=jsavitz@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam04 X-Rspam-User: X-HE-Tag: 1668666641-143292 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 16, 2022 at 8:09 PM Joel Savitz wrote: > > On Tue, Nov 8, 2022 at 8:31 PM Andrew Morton = wrote: >> >> On Fri, 28 Oct 2022 09:26:40 -0400 Joel Savitz wrot= e: >> >> > commit b5ba705c2608 ("selftests/vm: enable running select groups of te= sts") >> > unintentionally reversed the ordering of some of the lines of >> > run_vmtests.sh that calculate values based on system configuration. >> > Importantly, $hpgsize_MB is determined from $hpgsize_KB, but this late= r >> > value is not read from /proc/meminfo until later, causing userfaultfd >> > tests to incorrectly fail since $half_ufd_size_MB will always be 0. >> > >> > Switch these statements around into proper order to fix the invocation >> > of the userfaultfd tests that use $half_ufd_size_MB. >> >> Does this fix address the failure in >> https://lkml.kernel.org/r/202211021026.61b267d1-yujie.liu@intel.com? >> >> Thanks. >> > > I have tried to reproduce this failure on a couple of different systems b= efore and after the application of this commit but I haven't had any succes= s in doing so. I suspect that there was some sort of hugepage configuration= issue on the test system but I'd have to look into it more to be sure. > > However, I noticed that on the mm-everything branch, the hugepage-mmap te= st fails: > > # ./run_vmtests.sh -t "hugetlb" > running: ./hugepage-mmap > ----------------------- > running ./hugepage-mmap > ----------------------- > Open failed: No such file or directory > [FAIL] > ... > > It appears this is due to commit 0796c7b8be84 ("selftests/vm: drop mnt po= int for hugetlb in run_vmtests.sh") > as the test still replies on the ./huge mountpoint removed in that commit= . The test passes before that patchset is applied. > > Additionally, I just noticed an extraneous 'echo "running: $1"' line in r= un_test(), the effects of which are seen above, and I have just sent a patc= h to remove it. > > Joel Resending this reply since it appears a bit of HTML slipped into the last reply and it got rejected by the lists.