From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f47.google.com (mail-pa0-f47.google.com [209.85.220.47]) by kanga.kvack.org (Postfix) with ESMTP id 0F96E6B0037 for ; Fri, 11 Oct 2013 05:42:02 -0400 (EDT) Received: by mail-pa0-f47.google.com with SMTP id kp14so4108044pab.34 for ; Fri, 11 Oct 2013 02:42:02 -0700 (PDT) Received: by mail-ie0-f181.google.com with SMTP id tp5so7443913ieb.26 for ; Fri, 11 Oct 2013 02:42:00 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1381483536.2736.4.camel@AMDC1943> References: <1381159541-13981-1-git-send-email-k.kozlowski@samsung.com> <20131007150338.1fdee18b536bb1d9fe41a07b@linux-foundation.org> <1381220000.16135.10.camel@AMDC1943> <20131008130853.96139b79a0a4d3aaacc79ed2@linux-foundation.org> <20131009144045.GA5406@variantweb.net> <525602E3.3080501@oracle.com> <20131010022627.GA8535@variantweb.net> <1381483536.2736.4.camel@AMDC1943> Date: Fri, 11 Oct 2013 17:42:00 +0800 Message-ID: Subject: Re: [PATCH] frontswap: enable call to invalidate area on swapoff From: Weijie Yang Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Krzysztof Kozlowski Cc: Seth Jennings , Bob Liu , Seth Jennings , Andrew Morton , linux-mm@kvack.org, Konrad Rzeszutek Wilk , linux-kernel@vger.kernel.org, Shaohua Li , Minchan Kim On Fri, Oct 11, 2013 at 5:25 PM, Krzysztof Kozlowski wrote: > On Fri, 2013-10-11 at 10:23 +0800, Weijie Yang wrote: >> I am sorry to interrupt this topic, but I found an tiny issue near that: >> >> we can not "set_blocksize(bdev, p->old_block_size);" at the end of swapoff() >> because swap_info p may be reused by concurrent swapon called >> I think we need to save the p->old_block_size in a local var and use it instead > I confirm the race here (I was able to trigger it on the same swap type). > > >> to Krzysztof : would you please add this in your patch? >> Thanks > I think it should be another patch as this is not related with > frontswap. I'll send new one and add you as Reported-by. Is it OK with > you? All right. > > Best regards, > Krzysztof > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org