From: Weijie Yang <weijie.yang.kh@gmail.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Seth Jennings <sjennings@variantweb.net>,
Bob Liu <bob.liu@oracle.com>,
Seth Jennings <spartacus06@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
linux-kernel@vger.kernel.org, Shaohua Li <shli@fusionio.com>,
Minchan Kim <minchan@kernel.org>
Subject: Re: [PATCH] frontswap: enable call to invalidate area on swapoff
Date: Fri, 11 Oct 2013 17:42:00 +0800 [thread overview]
Message-ID: <CAL1ERfOzgbodgi5vfWFxzUu88UWoS8PFiJGUrHnvcn_=s-fLAQ@mail.gmail.com> (raw)
In-Reply-To: <1381483536.2736.4.camel@AMDC1943>
On Fri, Oct 11, 2013 at 5:25 PM, Krzysztof Kozlowski
<k.kozlowski@samsung.com> wrote:
> On Fri, 2013-10-11 at 10:23 +0800, Weijie Yang wrote:
>> I am sorry to interrupt this topic, but I found an tiny issue near that:
>>
>> we can not "set_blocksize(bdev, p->old_block_size);" at the end of swapoff()
>> because swap_info p may be reused by concurrent swapon called
>> I think we need to save the p->old_block_size in a local var and use it instead
> I confirm the race here (I was able to trigger it on the same swap type).
>
>
>> to Krzysztof : would you please add this in your patch?
>> Thanks
> I think it should be another patch as this is not related with
> frontswap. I'll send new one and add you as Reported-by. Is it OK with
> you?
All right.
>
> Best regards,
> Krzysztof
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2013-10-11 9:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-07 15:25 Krzysztof Kozlowski
2013-10-07 15:37 ` Seth Jennings
2013-10-07 22:03 ` Andrew Morton
2013-10-08 8:13 ` Krzysztof Kozlowski
2013-10-08 20:08 ` Andrew Morton
2013-10-09 7:50 ` Bob Liu
2013-10-09 14:40 ` Seth Jennings
2013-10-10 1:29 ` Bob Liu
2013-10-10 2:26 ` Seth Jennings
2013-10-11 2:23 ` Weijie Yang
2013-10-11 9:25 ` Krzysztof Kozlowski
2013-10-11 9:42 ` Weijie Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL1ERfOzgbodgi5vfWFxzUu88UWoS8PFiJGUrHnvcn_=s-fLAQ@mail.gmail.com' \
--to=weijie.yang.kh@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bob.liu@oracle.com \
--cc=k.kozlowski@samsung.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=shli@fusionio.com \
--cc=sjennings@variantweb.net \
--cc=spartacus06@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox