From: Weijie Yang <weijie.yang.kh@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Weijie Yang <weijie.yang@samsung.com>,
kamezawa.hiroyu@jp.fujitsu.com, Minchan Kim <minchan@kernel.org>,
mgorman@suse.de, mina86@mina86.com,
linux-kernel <linux-kernel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>,
isimatu.yasuaki@jp.fujitsu.com
Subject: Re: [PATCH 1/2] mm: page_isolation: check pfn validity before access
Date: Wed, 12 Nov 2014 10:10:36 +0800 [thread overview]
Message-ID: <CAL1ERfO5GNanwLkL36b11NDUTptzGrxVF=rN913bHjS9wFNWKQ@mail.gmail.com> (raw)
In-Reply-To: <20141111142344.b4eb11c6e3c240d345fdd995@linux-foundation.org>
On Wed, Nov 12, 2014 at 6:23 AM, Andrew Morton
<akpm@linux-foundation.org> wrote:
> On Thu, 06 Nov 2014 16:08:02 +0800 Weijie Yang <weijie.yang@samsung.com> wrote:
>
>> In the undo path of start_isolate_page_range(), we need to check
>> the pfn validity before access its page, or it will trigger an
>> addressing exception if there is hole in the zone.
>>
>
> There is not enough information in the chagnelog for me to decide how
> to handle the patch. 3.19? 3.18? 3.18+stable?
>
> When fixing bugs, please remember to fully explain the end-user impact
> of the bug. Under what circumstances does it occur?
I'm sorry to disturb you. This issue is found by code-review not a test-trigger.
In "CONFIG_HOLES_IN_ZONE" environment, there is a certain chance that
it would casue an addressing exception when start_isolate_page_range() fails,
this could affect CMA, hugepage and memory-hotplug function.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-11-12 2:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 8:08 Weijie Yang
2014-11-06 12:31 ` Michal Nazarewicz
2014-11-11 22:23 ` Andrew Morton
2014-11-12 2:10 ` Weijie Yang [this message]
2014-11-12 2:02 ` Yasuaki Ishimatsu
2014-11-12 19:34 ` Michal Hocko
2014-11-13 1:46 ` Weijie Yang
2014-11-13 13:10 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL1ERfO5GNanwLkL36b11NDUTptzGrxVF=rN913bHjS9wFNWKQ@mail.gmail.com' \
--to=weijie.yang.kh@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mina86@mina86.com \
--cc=minchan@kernel.org \
--cc=weijie.yang@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox