From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qa0-f42.google.com (mail-qa0-f42.google.com [209.85.216.42]) by kanga.kvack.org (Postfix) with ESMTP id C42606B0031 for ; Wed, 20 Nov 2013 22:12:59 -0500 (EST) Received: by mail-qa0-f42.google.com with SMTP id k4so2399285qaq.15 for ; Wed, 20 Nov 2013 19:12:59 -0800 (PST) Received: from mail-qc0-x22d.google.com (mail-qc0-x22d.google.com [2607:f8b0:400d:c01::22d]) by mx.google.com with ESMTPS id pe8si18248831qeb.52.2013.11.20.19.12.58 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 20 Nov 2013 19:12:59 -0800 (PST) Received: by mail-qc0-f173.google.com with SMTP id l4so948712qcv.32 for ; Wed, 20 Nov 2013 19:12:58 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <1384965522-5788-1-git-send-email-ddstreet@ieee.org> <20131120173347.GA2369@hp530> Date: Thu, 21 Nov 2013 11:12:58 +0800 Message-ID: Subject: Re: [PATCH] mm/zswap: change params from hidden to ro From: Weijie Yang Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Dan Streetman Cc: Vladimir Murzin , linux-mm@kvack.org, Seth Jennings , linux-kernel , Bob Liu , Minchan Kim , Weijie Yang On Thu, Nov 21, 2013 at 1:52 AM, Dan Streetman wrote: > On Wed, Nov 20, 2013 at 12:33 PM, Vladimir Murzin wrote: >> Hi Dan! >> >> On Wed, Nov 20, 2013 at 11:38:42AM -0500, Dan Streetman wrote: >>> The "compressor" and "enabled" params are currently hidden, >>> this changes them to read-only, so userspace can tell if >>> zswap is enabled or not and see what compressor is in use. >> >> Could you elaborate more why this pice of information is necessary for >> userspace? > > For anyone interested in zswap, it's handy to be able to tell if it's > enabled or not ;-) Technically people can check to see if the zswap > debug files are in /sys/kernel/debug/zswap, but I think the actual > "enabled" param is more obvious. And the compressor param is really > the only way anyone from userspace can see what compressor's being > used; that's helpful to know for anyone that might want to be using a > non-default compressor. > > And of course, eventually we'll want to make the params writable, so > the compressor can be changed dynamically, and zswap can be enabled or > disabled dynamically (or at least enabled after boot). Please do not make them writable. There is no requirement to do that, and it will make zswap more complex. > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org