From: Weijie Yang <weijie.yang.kh@gmail.com>
To: Bob Liu <bob.liu@oracle.com>
Cc: Seth Jennings <sjenning@linux.vnet.ibm.com>,
Weijie Yang <weijie.yang@samsung.com>,
minchan@kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] mm/zswap: avoid unnecessary page scanning
Date: Mon, 23 Sep 2013 14:07:59 +0800 [thread overview]
Message-ID: <CAL1ERfM7Xzbi5UNqwNnMtg=aeeTABL8ad9h7XL4VVSR_iVRxTA@mail.gmail.com> (raw)
In-Reply-To: <523FA230.3020902@oracle.com>
On Mon, Sep 23, 2013 at 10:06 AM, Bob Liu <bob.liu@oracle.com> wrote:
>
> On 09/10/2013 12:29 AM, Seth Jennings wrote:
>> On Fri, Sep 06, 2013 at 01:16:45PM +0800, Weijie Yang wrote:
>>> add SetPageReclaim before __swap_writepage so that page can be moved to the
>>> tail of the inactive list, which can avoid unnecessary page scanning as this
>>> page was reclaimed by swap subsystem before.
>>>
>>> Signed-off-by: Weijie Yang <weijie.yang@samsung.com>
>>
>> Acked-by: Seth Jennings <sjenning@linux.vnet.ibm.com>
>>
>
> Below is a reply from Mel in original thread "[PATCHv11 3/4] zswap: add
> to mm/"
> ------------------
>> + /* start writeback */
>> + SetPageReclaim(page);
>> + __swap_writepage(page, &wbc, end_swap_bio_write);
>> + page_cache_release(page);
>> + zswap_written_back_pages++;
>> +
>
> SetPageReclaim? Why?. If the page is under writeback then why do you not
> mark it as that? Do not free pages that are currently under writeback
> obviously. It's likely that it was PageWriteback you wanted in zbud.c too.
> --------------------
Thanks for reminding this.
The purpose of using this flag in PATCHv11 and this patch is different.
In PATCHv11, it was repurposed to protect zbud page against free,
and now it is replaced with zhdr->under_reclaim.
In this patch, this flag is for its original purpose(to be reclaimed asap)
> --
> Regards,
> -Bob
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2013-09-23 6:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 5:16 Weijie Yang
2013-09-06 6:31 ` Bob Liu
2013-09-09 16:29 ` Seth Jennings
2013-09-23 2:06 ` Bob Liu
2013-09-23 6:07 ` Weijie Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL1ERfM7Xzbi5UNqwNnMtg=aeeTABL8ad9h7XL4VVSR_iVRxTA@mail.gmail.com' \
--to=weijie.yang.kh@gmail.com \
--cc=bob.liu@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=sjenning@linux.vnet.ibm.com \
--cc=weijie.yang@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox