From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00199C433DB for ; Wed, 24 Feb 2021 20:43:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 799C160202 for ; Wed, 24 Feb 2021 20:43:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 799C160202 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F048B6B0005; Wed, 24 Feb 2021 15:43:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EB4206B0006; Wed, 24 Feb 2021 15:43:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA3916B006C; Wed, 24 Feb 2021 15:43:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0170.hostedemail.com [216.40.44.170]) by kanga.kvack.org (Postfix) with ESMTP id BCB5C6B0005 for ; Wed, 24 Feb 2021 15:43:06 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 7D64D80D4BB1 for ; Wed, 24 Feb 2021 20:43:06 +0000 (UTC) X-FDA: 77854335972.11.8D1DE2C Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) by imf30.hostedemail.com (Postfix) with ESMTP id 002F5E000114 for ; Wed, 24 Feb 2021 20:43:05 +0000 (UTC) Received: by mail-lj1-f170.google.com with SMTP id y7so3982409lji.7 for ; Wed, 24 Feb 2021 12:43:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kUcixlqqh382EoF6yE8w5wUEo1WOb6Ugj55K/oEgGAk=; b=r0nF8Qi510naWddB/oNL37c1s+cZaUhZwYsw5KFaoO/MaaOnqvCAK16/8cY2QYf038 nN1Yr9wp0oqDnSjYAuMN235COpJK8oM2RaXtV7yjgM8kpTa4uqyd/Y5IKCHzHGEKeOwe AmkW59ZkupiOznxCzgdzbiVKvEBif2gmVrNsEBKsentDaAvharBV3dRIy7JUNFkO4n7/ IepyKtGWqe+w1JnuULu5hTLj1WhrObo1o8JntkO014I50Bqg4Hq971Qk+lTPfeUP5fBq nqylw3hvkan8LpEZPgFpa8DI1LsGI2xMK4adDVszO1NXdar6AuzETavylkioMVZRHHHT 3ixQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kUcixlqqh382EoF6yE8w5wUEo1WOb6Ugj55K/oEgGAk=; b=JN8wwgc3wvT+VWhppjpTEOJXeMP6zPKt7ZX66nTM0/n14MJIn3EwPn5K0nIXZbPifr teqLGk9968cyhFF+L+JNoH0dCrK7GG2QqHI0c7R//mFooH6a4wYkObupBXm+TsbnWJW2 b/ZWGjQFJ8o5F6MVdrWska7oeb/SE2G4tMvsCtDLxLPFmgWew6t4GWByvGNBvKG4nv4N WkRlNlAIMXCY3hArCrlxCKGPgoh5E2yKtwRwPtMkUICxdAiuOM+K7vjTJIgbWsVg2ed2 myXRg4HqhxuMAtrp+ZSvW2TwpfCD/dyF1nqx+zTRdLz+NzUtXAA8m61mUDGT5HutWuLL edGg== X-Gm-Message-State: AOAM530sHkLLydHUztcHW/EfyKEwjaFOcap2tfNg2+6Sf/cz5JyakmCa huiwR/walIZJauDu1lE9XNiqqPtgyLFj7V0lizQ/Dw== X-Google-Smtp-Source: ABdhPJwfiVjxSit6gUYs0pcDZNn5vQKD0ms+8SCVgGG5EZdeP0AxXX3Vz/uqMQP3F6oTGOeTiQL7GFgxZP+nBAunRd4= X-Received: by 2002:a05:651c:2042:: with SMTP id t2mr19750955ljo.233.1614199383238; Wed, 24 Feb 2021 12:43:03 -0800 (PST) MIME-Version: 1.0 References: <202102242016.MJskK6hp-lkp@intel.com> <97716bb9-6aca-d7e6-e390-1b9d3a0b99a8@infradead.org> In-Reply-To: <97716bb9-6aca-d7e6-e390-1b9d3a0b99a8@infradead.org> From: Nick Desaulniers Date: Wed, 24 Feb 2021 12:42:51 -0800 Message-ID: Subject: Re: [linux-next:master 11942/12503] drivers/video/fbdev/aty/atyfb_base.c:180:6: warning: no previous prototype for function 'aty_st_lcd' To: Randy Dunlap Cc: kernel test robot , kbuild-all@lists.01.org, clang-built-linux , Linux Memory Management List , Daniel Vetter Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 1pjujzsymfqjaj9ghwwk6tsnofshz596 X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 002F5E000114 Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf30; identity=mailfrom; envelope-from=""; helo=mail-lj1-f170.google.com; client-ip=209.85.208.170 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614199385-312597 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 24, 2021 at 12:03 PM Randy Dunlap wrote: > > On 2/24/21 4:46 AM, kernel test robot wrote: > > Hi Randy, > > > > FYI, the error/warning still remains. > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > head: 577c283560fe8a81a23a95654c6d13e8412d22f1 > > commit: bfa5782b9caa26f93f42ad79804e1f75a1ce9f18 [11942/12503] fbdev: atyfb: add stubs for aty_{ld,st}_lcd() > > config: arm64-randconfig-r004-20210223 (attached as .config) > > compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project f14a14dd2564703db02f80c00db8ae492b594f77) > > reproduce (this is a W=1 build): > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > # install arm64 cross compiling tool for clang build > > # apt-get install binutils-aarch64-linux-gnu > > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=bfa5782b9caa26f93f42ad79804e1f75a1ce9f18 > > git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > > git fetch --no-tags linux-next master > > git checkout bfa5782b9caa26f93f42ad79804e1f75a1ce9f18 > > # save the attached .config to linux build tree > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 > > > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot > > > > All warnings (new ones prefixed by >>): > > > >>> drivers/video/fbdev/aty/atyfb_base.c:180:6: warning: no previous prototype for function 'aty_st_lcd' [-Wmissing-prototypes] > > void aty_st_lcd(int index, u32 val, const struct atyfb_par *par) > > ^ > > drivers/video/fbdev/aty/atyfb_base.c:180:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > > void aty_st_lcd(int index, u32 val, const struct atyfb_par *par) > > ^ > > static > >>> drivers/video/fbdev/aty/atyfb_base.c:183:5: warning: no previous prototype for function 'aty_ld_lcd' [-Wmissing-prototypes] > > u32 aty_ld_lcd(int index, const struct atyfb_par *par) > > ^ > > drivers/video/fbdev/aty/atyfb_base.c:183:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > > u32 aty_ld_lcd(int index, const struct atyfb_par *par) > > ^ > > static > > 2 warnings generated. > > > > These 2 functions are also used/usable (depending on CONFIG options) in > mach64_ct.c so they can't be static. > > AFAIK, we don't make functions have different qualifiers depending on > config options. Is there a shared header included by both mach64_ct.c and atyfb_base.c you could provide a declaration in, that way should the definition change we'd catch such a change in order to not break the callers? > > > > > vim +/aty_st_lcd +180 drivers/video/fbdev/aty/atyfb_base.c > > > > 163 > > 164 u32 aty_ld_lcd(int index, const struct atyfb_par *par) > > 165 { > > 166 if (M64_HAS(LT_LCD_REGS)) { > > 167 return aty_ld_le32(lt_lcd_regs[index], par); > > 168 } else { > > 169 unsigned long temp; > > 170 > > 171 /* write addr byte */ > > 172 temp = aty_ld_le32(LCD_INDEX, par); > > 173 aty_st_le32(LCD_INDEX, (temp & ~LCD_INDEX_MASK) | index, par); > > 174 /* read the register value */ > > 175 return aty_ld_le32(LCD_DATA, par); > > 176 } > > 177 } > > 178 #else /* defined(CONFIG_PMAC_BACKLIGHT) || defined(CONFIG_FB_ATY_BACKLIGHT) \ > > 179 defined(CONFIG_FB_ATY_GENERIC_LCD) */ > > > 180 void aty_st_lcd(int index, u32 val, const struct atyfb_par *par) > > 181 { } > > 182 > > > 183 u32 aty_ld_lcd(int index, const struct atyfb_par *par) > > 184 { > > 185 return 0; > > 186 } > > 187 #endif /* defined(CONFIG_PMAC_BACKLIGHT) || defined (CONFIG_FB_ATY_GENERIC_LCD) */ > > 188 > > > > --- > > > -- > ~Randy > > -- > You received this message because you are subscribed to the Google Groups "Clang Built Linux" group. > To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/97716bb9-6aca-d7e6-e390-1b9d3a0b99a8%40infradead.org. -- Thanks, ~Nick Desaulniers