From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.9 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC62BC2D0A8 for ; Mon, 28 Sep 2020 17:57:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2D23921548 for ; Mon, 28 Sep 2020 17:57:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="EpAhnTW8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2D23921548 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B43FB8E0003; Mon, 28 Sep 2020 13:57:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ACC848E0001; Mon, 28 Sep 2020 13:57:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BCC48E0003; Mon, 28 Sep 2020 13:57:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0137.hostedemail.com [216.40.44.137]) by kanga.kvack.org (Postfix) with ESMTP id 7F14E8E0001 for ; Mon, 28 Sep 2020 13:57:00 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 3F9A8181AE86C for ; Mon, 28 Sep 2020 17:57:00 +0000 (UTC) X-FDA: 77313226200.08.grape90_200809a27183 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin08.hostedemail.com (Postfix) with ESMTP id 1D5341819E773 for ; Mon, 28 Sep 2020 17:57:00 +0000 (UTC) X-HE-Tag: grape90_200809a27183 X-Filterd-Recvd-Size: 8729 Received: from mail-pj1-f66.google.com (mail-pj1-f66.google.com [209.85.216.66]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Mon, 28 Sep 2020 17:56:59 +0000 (UTC) Received: by mail-pj1-f66.google.com with SMTP id mm21so1109153pjb.4 for ; Mon, 28 Sep 2020 10:56:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+2E+AcVLP39Ffh1UN6mFPMMEjem7/dyE7I5dIaGI8zw=; b=EpAhnTW8NFufkRY7cLXCI0Yhas0kVNbaGQmzj+t/GfYxPqmY0r22HYaHBpkSy4u3M5 k3RocWdHA7UARgvzLyR/H69q+UsK0iXuFb/kXFUmhFLnc2ezEpufw2ZNCl53MFvvx1fU nk01aCbpyARRAJXPVojiZnCsr6MYht8LRZOWLFWQkbCuXCIi6WnsGScZVKr6+MGQ83CL bSFoieEscdrzZZnu3EmGtnwQnB7aRKbLNrLk1zTq3x41m9yTMQsu+cF9mDLkM3TEG080 HrOg3Ta/2y1ZAwNQ6CyqsBTQx9kGZkciS52d9b92CHksU5J2SWTmh09IMBHsohVUezds iFnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+2E+AcVLP39Ffh1UN6mFPMMEjem7/dyE7I5dIaGI8zw=; b=BMWw7M2kpdlZmhz2lPl39M93uKnITj6A/0ZUyYqMMaabeiyhkifomBxs/xd20fEnkS SwP1jjrixgNZZslYRMCjKHIfH8gljD9+RBCCwczH9f45bkuW7PeL6/cG9+i49FyBfGBj Xxu5VbvfZyhcAkjwcjGAzi/9X2nR38kTIUwMO2dboCJwMhBTtxNw+euyIxDB0G7E62EL q5RFgFho/EyE1JyyH93FhvJTv5tm2n1GgbTwjPX0Xx6Q0BhyWYMDyZ9zA8nkeBDygXz8 xIMZZPBn2WRSJVxQ2/fRMmvCz9SnB4pvuFeNlgtFwrOjwv3ZwyRqomC4VF5CTCyDoNBi IwBA== X-Gm-Message-State: AOAM531L83gMXWnkUULUzsali90ofrIbXeyLUs2nXJ/a1sB+YtEizCGs +H1ywk6aaB43IuClV9y5kHJ23hNgEdR/zVC40vVJ1g== X-Google-Smtp-Source: ABdhPJzOmr3n4/FqkOHr9LuESD4ckv/cn1ifRHeaNjybWSxYa6aKrYi1soTy2Z6acvUbhpS0XZnaeaUTgzmRywIuy6E= X-Received: by 2002:a17:90a:e517:: with SMTP id t23mr381798pjy.25.1601315818441; Mon, 28 Sep 2020 10:56:58 -0700 (PDT) MIME-Version: 1.0 References: <202009280455.Qidf5AqU%lkp@intel.com> In-Reply-To: From: Nick Desaulniers Date: Mon, 28 Sep 2020 10:56:46 -0700 Message-ID: Subject: Re: [linux-next:master 11080/11173] drivers/media/common/saa7146/saa7146_hlp.c:648:5: warning: stack frame size of 1072 bytes in function 'saa7146_enable_overlay' To: Marco Elver Cc: kernel test robot , George Popescu , kbuild-all@lists.01.org, clang-built-linux , David Brazdil , Andrew Morton , Linux Memory Management List Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Sep 28, 2020 at 12:03 AM 'Marco Elver' via Clang Built Linux wrote: > > On Sun, 27 Sep 2020 at 22:14, kernel test robot wrote: > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > head: 20dc779fdefc40bf7dd9736cea01704f29228fae > > commit: 2ce416ba162877d5cf267ac35548ea45eba84150 [11080/11173] ubsan: introduce CONFIG_UBSAN_LOCAL_BOUNDS for Clang > > config: powerpc-randconfig-r004-20200927 (attached as .config) ^ randconfig > > compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 6d374cf78c8a80a0bbfc7ce9bc80b3f183f44c80) > > reproduce (this is a W=1 build): > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > # install powerpc cross compiling tool for clang build > > # apt-get install binutils-powerpc-linux-gnu > > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=2ce416ba162877d5cf267ac35548ea45eba84150 > > git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > > git fetch --no-tags linux-next master > > git checkout 2ce416ba162877d5cf267ac35548ea45eba84150 > > # save the attached .config to linux build tree > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc > > > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot > > > > All warnings (new ones prefixed by >>): > > > > >> drivers/media/common/saa7146/saa7146_hlp.c:648:5: warning: stack frame size of 1072 bytes in function 'saa7146_enable_overlay' [-Wframe-larger-than=] > > int saa7146_enable_overlay(struct saa7146_fh *fh) > > ^ > > 1 warning generated. > > This warning must have existed before, because the UBSAN patch didn't > add any features, it just guarded them with extra Kconfig options. Likely. > > Also, this is with Clang 12, which is very much in development and > quite unstable. I wrote a tool that can help debug these: https://github.com/ClangBuiltLinux/frame-larger-than The compiler is quite unhelpful in the warning; but recompiling with debug info gives you info about stack slots and the size of those types. This is a randconfig, so always weird things get pulled in. Sometimes these are large stack allocations that should be heap allocated; sometimes it's KASAN enabled via randconfig. I noticed that KASAN+clang has pretty poor stack slot reuse, which triggers these often: https://github.com/ClangBuiltLinux/linux/issues/39 I didn't check this config to see if KASAN was set or not, but I wouldn't chalk it up to "clang 12 being unstable." > > > vim +/saa7146_enable_overlay +648 drivers/media/common/saa7146/saa7146_hlp.c > > > > ^1da177e4c3f41 drivers/media/common/saa7146_hlp.c Linus Torvalds 2005-04-16 647 > > ^1da177e4c3f41 drivers/media/common/saa7146_hlp.c Linus Torvalds 2005-04-16 @648 int saa7146_enable_overlay(struct saa7146_fh *fh) > > ^1da177e4c3f41 drivers/media/common/saa7146_hlp.c Linus Torvalds 2005-04-16 649 { > > ^1da177e4c3f41 drivers/media/common/saa7146_hlp.c Linus Torvalds 2005-04-16 650 struct saa7146_dev *dev = fh->dev; > > ^1da177e4c3f41 drivers/media/common/saa7146_hlp.c Linus Torvalds 2005-04-16 651 struct saa7146_vv *vv = dev->vv_data; > > ^1da177e4c3f41 drivers/media/common/saa7146_hlp.c Linus Torvalds 2005-04-16 652 > > 5da545ad08a3c6 drivers/media/common/saa7146_hlp.c Hans Verkuil 2012-05-01 653 saa7146_set_window(dev, vv->ov.win.w.width, vv->ov.win.w.height, vv->ov.win.field); > > 5da545ad08a3c6 drivers/media/common/saa7146_hlp.c Hans Verkuil 2012-05-01 654 saa7146_set_position(dev, vv->ov.win.w.left, vv->ov.win.w.top, vv->ov.win.w.height, vv->ov.win.field, vv->ov_fmt->pixelformat); > > ^1da177e4c3f41 drivers/media/common/saa7146_hlp.c Linus Torvalds 2005-04-16 655 saa7146_set_output_format(dev, vv->ov_fmt->trans); > > ^1da177e4c3f41 drivers/media/common/saa7146_hlp.c Linus Torvalds 2005-04-16 656 saa7146_set_clipping_rect(fh); > > ^1da177e4c3f41 drivers/media/common/saa7146_hlp.c Linus Torvalds 2005-04-16 657 > > ^1da177e4c3f41 drivers/media/common/saa7146_hlp.c Linus Torvalds 2005-04-16 658 /* enable video dma1 */ > > ^1da177e4c3f41 drivers/media/common/saa7146_hlp.c Linus Torvalds 2005-04-16 659 saa7146_write(dev, MC1, (MASK_06 | MASK_22)); > > ^1da177e4c3f41 drivers/media/common/saa7146_hlp.c Linus Torvalds 2005-04-16 660 return 0; > > ^1da177e4c3f41 drivers/media/common/saa7146_hlp.c Linus Torvalds 2005-04-16 661 } > > ^1da177e4c3f41 drivers/media/common/saa7146_hlp.c Linus Torvalds 2005-04-16 662 > > > > :::::: The code at line 648 was first introduced by commit > > :::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2 > > > > :::::: TO: Linus Torvalds > > :::::: CC: Linus Torvalds > > > > --- > > 0-DAY CI Kernel Test Service, Intel Corporation > > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org > > -- > You received this message because you are subscribed to the Google Groups "Clang Built Linux" group. > To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/CANpmjNNcRCipPdd0C0z-dxb1nfz35bkgAY6eJwGF8sYq%3D2wOqQ%40mail.gmail.com. -- Thanks, ~Nick Desaulniers