From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FEB2ECE587 for ; Tue, 1 Oct 2019 16:36:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3347A21855 for ; Tue, 1 Oct 2019 16:36:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="R3PPoTfk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3347A21855 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B8F3F8E0005; Tue, 1 Oct 2019 12:36:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B3E528E0001; Tue, 1 Oct 2019 12:36:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A53848E0005; Tue, 1 Oct 2019 12:36:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0004.hostedemail.com [216.40.44.4]) by kanga.kvack.org (Postfix) with ESMTP id 83A298E0001 for ; Tue, 1 Oct 2019 12:36:38 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 2CE6B180AD7C3 for ; Tue, 1 Oct 2019 16:36:38 +0000 (UTC) X-FDA: 75995769276.04.smile88_741223f1efe49 X-HE-Tag: smile88_741223f1efe49 X-Filterd-Recvd-Size: 4670 Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by imf36.hostedemail.com (Postfix) with ESMTP for ; Tue, 1 Oct 2019 16:36:37 +0000 (UTC) Received: by mail-pf1-f196.google.com with SMTP id 205so8400041pfw.2 for ; Tue, 01 Oct 2019 09:36:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AHMFw+xpbq6Flta24J2hzTDxt/C/G/wkt9n5+ff6Syg=; b=R3PPoTfkYjm55Usvkap+EtoXUf5HVNBlhI8mau+Mc5cS3RRZ3i3i4xcKmMlhslCnRk wKr/l+Q5TujIFf7DvN0yU8XV25ZAntQ5u07Ioac5iArFq2covqObD/FHRplQDhtCKzaz I369JfzpF9rzCwNJokHteHQFva3hWd+aSj941pR+DBaK676oi3sZCTTOrOFW2HDm2D3T iWIg1YBr/Ero51hEPo9rNXn1VhlMIfpVB5WVaHWXD0eAAwTkseCUOaoGpjnEckwIQIwE XE9q4CoZnGeeF8k5aEwyfwP6nS9x5VSJTFl6U+9Vagz+qqtlvojsx2qKaa0jZCiD35pG o77A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AHMFw+xpbq6Flta24J2hzTDxt/C/G/wkt9n5+ff6Syg=; b=ZERlkIjTUuGvjGFBJAL8hExrFMeeZDSPMEsZNauYI+FXyshAoU1FMQV3EuHGG0RKey aDrqtwnL3NnB+/RffbAR2c5HNFpVgnNrgayXRh7MELnK69XRLWlJY0TPrgLNdjnpKYD3 XZHsoTA6sFuoigahfI28IQjIvwVQ5VIzbdz0CBMOOYa2Rvj0Him1W9Ecs7B+zB/nj+mk zbXTs7Qv9rkoPARJ9vKZJELiUtnhHW+DZtlHYHo74bOSk2qQSSY4cWB1Pdy3bZ78PTNB fUmYvxuroa7oBTcil75vFJRKytppMvla8sOfAIqRXLmdELfxLmaqHABwl2UFwtW9Jr9/ YKzg== X-Gm-Message-State: APjAAAVWccjxmbiIgY7kUD/ZuiZHkg89K5XAql1wjwEfQ4iZkAkw3OQI gLD0lYo6DeGhduSvmd2QgPaEJR9pOYS3wimh8D+gMA== X-Google-Smtp-Source: APXvYqyko40OZ04X6xSuPAOAtRZAh3FOBHZRVF+R8vBkvFaLnxVIbcyNokxXCTUmztr0eLX5WJZn0HuNWs7rxTynnCQ= X-Received: by 2002:a63:7153:: with SMTP id b19mr30478989pgn.10.1569947795665; Tue, 01 Oct 2019 09:36:35 -0700 (PDT) MIME-Version: 1.0 References: <20191001142227.1227176-1-arnd@arndb.de> In-Reply-To: <20191001142227.1227176-1-arnd@arndb.de> From: Nick Desaulniers Date: Tue, 1 Oct 2019 09:36:24 -0700 Message-ID: Subject: Re: [PATCH] mm/memcontrol.c: fix another unused function warning To: Arnd Bergmann Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Qian Cai , Michal Hocko , Andrew Morton , Roman Gushchin , Shakeel Butt , Chris Down , Tejun Heo , cgroups@vger.kernel.org, Linux Memory Management List , LKML , clang-built-linux Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 1, 2019 at 7:22 AM Arnd Bergmann wrote: > > Removing the mem_cgroup_id_get() stub function introduced a new warning > of the same kind when CONFIG_MMU is disabled: > > mm/memcontrol.c:4929:13: error: unused function 'mem_cgroup_id_get_many' [-Werror,-Wunused-function] > > Address this using a __maybe_unused annotation. > > Note: alternatively, this could be moved into an #ifdef block. Marking it Hi Arnd, Thank you for the patch! I would prefer to move the definition to the correct set of #ifdef guards rather than __maybe_unused. Maybe move the definition of mem_cgroup_id_get_many() to just before __mem_cgroup_clear_mc()? I find __maybe_unused to be a code smell. > 'static inline' would not work here as that would still produce the > warning on clang, which only ignores unused inline functions declared > in header files instead of .c files. > > Fixes: 4d0e3230a56a ("mm/memcontrol.c: fix a -Wunused-function warning") > Signed-off-by: Arnd Bergmann > --- > mm/memcontrol.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index c313c49074ca..5f9f90e3cef8 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -4921,7 +4921,8 @@ static void mem_cgroup_id_remove(struct mem_cgroup *memcg) > } > } > > -static void mem_cgroup_id_get_many(struct mem_cgroup *memcg, unsigned int n) > +static void __maybe_unused > +mem_cgroup_id_get_many(struct mem_cgroup *memcg, unsigned int n) > { > refcount_add(n, &memcg->id.ref); > } > -- -- Thanks, ~Nick Desaulniers