From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D63DC77B78 for ; Wed, 26 Apr 2023 17:37:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D38E26B010D; Wed, 26 Apr 2023 13:37:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CE8E86B010E; Wed, 26 Apr 2023 13:37:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B89396B010F; Wed, 26 Apr 2023 13:37:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A5A2B6B010D for ; Wed, 26 Apr 2023 13:37:04 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 720E81401C5 for ; Wed, 26 Apr 2023 17:37:04 +0000 (UTC) X-FDA: 80724247968.26.E041EE7 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by imf02.hostedemail.com (Postfix) with ESMTP id 9C3278001D for ; Wed, 26 Apr 2023 17:37:02 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=Weuq5WqH; spf=pass (imf02.hostedemail.com: domain of ndesaulniers@google.com designates 209.85.210.171 as permitted sender) smtp.mailfrom=ndesaulniers@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682530622; a=rsa-sha256; cv=none; b=y8E0GWG6+/uxhX+HWbgRre5S8bxI401sS5T+5ulj+W5sJtxnyd3GX+BV639z0DyJABsqGP 8lwWyHOeVNRNjS9r/Oi4n1D9cX0P1+r+ZwR8vHpXU8Oc3hNExaujsWJnKqeKCpJZ8/kt0f RFu4LfM5d9NvlZXrzSlOF9UDTAppTAQ= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=Weuq5WqH; spf=pass (imf02.hostedemail.com: domain of ndesaulniers@google.com designates 209.85.210.171 as permitted sender) smtp.mailfrom=ndesaulniers@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682530622; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1/Rb0m7CpTZA7EE2udzmj88vBB5OZ6QKrKSNtnC7nH4=; b=gwha2PdXIBTcRyA3Wg5k8RTgLLtE+1jZQU8kaz87WhByQYx/EnYT2GEfG1jc1O7bQxr9RG M22F2T81d4VfvGLtnGX1ftF3FVgvR/uHp8EaYGHbTtVYpN9M1cEX5oOlioxw/Gc8mk9mE6 wUXwUeOP0LOOzcYk3SW6KaA84uKhEPk= Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-63b5465fb99so6169093b3a.1 for ; Wed, 26 Apr 2023 10:37:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1682530621; x=1685122621; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1/Rb0m7CpTZA7EE2udzmj88vBB5OZ6QKrKSNtnC7nH4=; b=Weuq5WqHFiUL4RDARreTMvbiUAaMRbPD+EEVph3Zbd3xvax84juabu0KGit5tpKg/j dxd8r2cseLt9QJC74CcGwiZKIG0B/nnAOAAnrvX3Az8NXY9KRJLwSyefrmKu/G9+vv6N MNATStoNZqzKIqpw+JKCFH/9K0dYNEKKmt1aJKaQvq5H1FY092hfw2xKC8cNhiBRqon3 GkCztoVMyPtsbP4QdJxEVzwIU9ejwWyyT6nJL1CXSk/Zqhs8DTlu9jwnzQ5OxYV5l08N QZwc6QnxXGMCl218E+woajNDcemj1SEgVQYuh76l7yRJOYxKKtIkmvIQYqKj7xbB4EyI p2dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682530621; x=1685122621; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1/Rb0m7CpTZA7EE2udzmj88vBB5OZ6QKrKSNtnC7nH4=; b=iDFLKKyZ3/g7FZh5ca1PZcrIRWsYWgsegZJULEnnaGlDeEUNBXmzPC0k4jipWmNrtx 45OtaGz3+yh/DdS47+cBqR7dR50MUfmlb4Ml9P1Tnodd80Zn70e3YUVovMdSk7Z+lnPj +UURDSgO2dPfx6DJFyACFNaQG47a6NFIjTNaMXhG6dw6AbP5IaPCE8qJjxv83zbludPg 8vf9Nvsi+aTPrqWxNMJGQwvf+xOPs+DcD6ZpJRLa0cxiI0evN6lokRCkqk5T0Vdkj7YE W9MOV3OLblZHky1X89ZdEvNeV6ASpS0VKL4bzXWQMX1LOHcbA9Yzle0Ebvf3d+B/qnCa 2CtQ== X-Gm-Message-State: AAQBX9c5L/gKymvdet8wSaFcE94O6LdWwIkWxc9g9gt0nk0DowBuagHP 37o5G0cZomFufQPvBfURilbFvZXfxYMcV2MIMKKZ7Q== X-Google-Smtp-Source: AKy350b3iJLSy/fIKD/j4Htqg1xcBHeNcouKeWnNU/8vNvaqVd7Tc+nYjFxmFYETyIOtBHY3vtqP+FuqvJLFVQR4b/U= X-Received: by 2002:a05:6a20:6a1b:b0:ef:205f:8184 with SMTP id p27-20020a056a206a1b00b000ef205f8184mr28568195pzk.13.1682530621379; Wed, 26 Apr 2023 10:37:01 -0700 (PDT) MIME-Version: 1.0 References: <20230425041838.GA150312@mit.edu> In-Reply-To: From: Nick Desaulniers Date: Wed, 26 Apr 2023 10:36:50 -0700 Message-ID: Subject: Re: [GIT PULL] ext4 changes for the 6.4 merge window To: Linus Torvalds Cc: "Theodore Ts'o" , Nathan Chancellor , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 9C3278001D X-Rspamd-Server: rspam01 X-Stat-Signature: eiz6nqenkqjrj34hc6a17eue9useu7qx X-HE-Tag: 1682530622-881703 X-HE-Meta: U2FsdGVkX1+dDt2wfC1AeBfgKUKkiVQt8vaa1XFac6WGnzbKLjv/zzwCMVHPEK5j0iBhezq2wESO+4XinzkgrqGzj6n7mEDQh+7t6ZkgKo1EIfjqYVONJnEMmB88vesIfLyvD+qDINr7IPM7Owch9sG0acwHDm6AE+95N0v7tMwpff2Ffdn4Xp6APlr+Xo1KqHAmPoSoxuc3Ph0N0onEDPaC5s677uNRYs1Ug63UcUiu1PrJ5gYQiAXn3SMBdwdAtlIoxMVu5RuxunfpovfRW6NB26m+ZTUNIYFs7WufRlEwiMgGf7fNwCKOCimbEhswdkKdHBEY4s6vLZmdhJuCdJRDgD8sTC7dfaxz4gWKqCLq3k/Nfy52b4sib9y/sTzgvuzIzFVHCh6lbOXOMJnWKlgtG9YZ9CZJ4b2cA8vLXx1b+abiQF0rKa4jndH1J9OOV3pTY5N1H1SnbfzsbqoykRnZs9hCTsNYDERs9PXuPS1k6bJzGljPtobbuBnsP7Z9dfMVXL1Q4hZ/gy/3kGlp3rwlS3vH6SFA/2uyHfi0oVaKnp3o52zrCfxIFmsH7Jgb7vuLCwdEPfomvD5DENpXsJSsgHz4UGiIb8K3jRMa3gW1dBsgG9sBGYPV6RsHdfgW+uS/kldqsN4+7A3yeNJvAjayn2xchrMBhkI7dgIFGQ1a7Fwaot1VtcNJvrFEkwmoNQpKscXp6kh280WDOzTJCp3XRV0QXBksbLcMhgqUenicZKPe9JiBbNPlNBJlAKOyP8jB25SNM7O/qVXML0NpLC09fYdVPP/EHWnLMH4J7945DoquIV93OobC82G30Sn13Ny6uG9wasFyAxdZnpLqTV2ndxNDKwBCH0n6ZKlRwAeq9w2mQCKgSH15GA25SK43zME7z4KALFBJHZ1WwJLLU09bZEE56pgGtYxu0vr61BxMwH1A2kjUq7b6zUZ8+tIRerHsSE2hnZmPmaOMptz NDgg5xSd XkcvSfPAjkg5PeV1OrXj2BSlBIXwMkRetM0vd+tKsDxKS0iVD+Xoi4awqjsRjtmjesT7jTiNLSVTc0/d2QzEKn080Oy3bF6dyR//aXSKpfJsewUb72KVtiNke2yKBSE1Of7F1aFohVVEaI4ppNjneI3YrDD1MYI67gMEvzlmJZUEvE1kAwYVjMvV/BCfu4okMzeYdJChinXFDedqg2MrGwoVlp5j7REJzWHRJM3+lD/k0gCEXH2deCP70w657mRMQm43riqTGjLLIbpH1/vJVoXl2/ZxL3fg4IyUfY7hNNnGLHJ9ahPWqNII9yz+172somoTS+HfxSTR8+h11y9dz37WhqJCTqJF+nmo4p8ABa1+gE/LUyBexa7ZbGFp72nXOloRB8oWVz9FgaLPlqFWvhAx3umTKCbmvwxCDKUjRklsqAGNdNKt5GztGX6Qz6aCTzpOz8oQGTdmPWfWzxHEZa6XlGFHRA5nv64BOhuzv1rQ1Ko0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 26, 2023 at 10:34=E2=80=AFAM Nick Desaulniers wrote: > > On Wed, Apr 26, 2023 at 10:03=E2=80=AFAM Linus Torvalds > wrote: > > > > On Mon, Apr 24, 2023 at 9:18=E2=80=AFPM Theodore Ts'o w= rote: > > > > > > Please note that after merging the mm and ext4 trees you will need to > > > apply the patch found here[1]. > > > > > > [1] https://lore.kernel.org/r/20230419120923.3152939-1-willy@infradea= d.org > > > > > > This is due to a patch in the mm tree, "mm: return an ERR_PTR from > > > __filemap_get_folio" changing that function to returning an ERR_PTR > > > instead of returning NULL on an error. > > > > Side note, itr would be wonderful if we could mark the places that > > return an error pointer as returning "nonnull", and catch things like > > this automatically at build time where people compare an error pointer > > to NULL. > > That's what clang's _Nonnull attribute does (with -Wnullability-extension= ). > https://godbolt.org/z/6jo1zbMd9 Ah sorry, I _thought_ that's how _Nonnull worked on return types. Let me dig some more and see how that's supposed to work... --=20 Thanks, ~Nick Desaulniers