From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0745C433EF for ; Thu, 18 Nov 2021 18:43:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5EFF061B62 for ; Thu, 18 Nov 2021 18:43:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5EFF061B62 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id C083D6B006C; Thu, 18 Nov 2021 13:43:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BB8206B0073; Thu, 18 Nov 2021 13:43:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A7FF16B0074; Thu, 18 Nov 2021 13:43:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0118.hostedemail.com [216.40.44.118]) by kanga.kvack.org (Postfix) with ESMTP id 9BCE46B006C for ; Thu, 18 Nov 2021 13:43:26 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 5DF9189123 for ; Thu, 18 Nov 2021 18:43:16 +0000 (UTC) X-FDA: 78822923592.23.B2362CF Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com [209.85.167.182]) by imf10.hostedemail.com (Postfix) with ESMTP id E89E56001ABD for ; Thu, 18 Nov 2021 18:43:14 +0000 (UTC) Received: by mail-oi1-f182.google.com with SMTP id 7so16175924oip.12 for ; Thu, 18 Nov 2021 10:43:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dsHgrt3f1EilcZuTcpPj1Uibbk6NZSW0KCEvWuPSgaA=; b=dfb4NHDvEkj3BC0fHWPSnJOucM9uBQPYun5TISX7bpUpB0jCAJwUVcP5N9FTAKhQe5 3bT/dFWcq+5RZJY8na+AdpyJt6bvMK3CAxHElXXCraHes83ilGYVcaIw0NRDLjZllGME 9rOj5iWZgQF1lvJ0+c/c2AgdOds4WnUYGL6/jE9MNLmiSKbBexf7yej741WRfqi/sHie 1ROChNXPDL1LLWq+RrR1gHEwwfTy1kh4+KGx1workcrW3ZpqK/gz5TTnrr2Y9dgVeLBo +bUq6ZnYvYiMFnye2VqGFtkt+RF8fWOG6fE8xtDUWqe6OgLEhg6tMN6/GcBDZOoGwx5d 8Csg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dsHgrt3f1EilcZuTcpPj1Uibbk6NZSW0KCEvWuPSgaA=; b=Nl287n3c1OVDMrwfmH9/btWR/l5mdib1+1sr22yJ7BYRXDUd0160esYh//7QxVPYXp baYUq+o0y3g+GzHPCZGDNO2RYfMGoFqOEfHLZvENRyOTQr+9kMmDeJ1jOwjKAas8NXCX kBBKw1fjEoTfbh+rEi7qlMzsCE36y9a+p9S59JSGzTgLCwq7LdWlV/GEkvFPbbS50v5f GFbLInBMMBrESaCCrD2r8E5V6UmRVkAZidEjHofGWgTrhKpAWIlDNn2tVCNRY711/rIV UTJQ4yfpZH4aPvBpcslTVfgIvwYluw0aGVK4cC6nu5ZP3gz2ftOWSMQjWrgjsGe+fcaM lM+A== X-Gm-Message-State: AOAM530AEF0GE99jFjzvlPHQY2qsKqNnRu9IzAZWpTzEC7zGS/yGjbUc qPNjHDtbqkQUhe7LQ5eQRe1xL1gFXjGTsNKh5MsJEQ== X-Google-Smtp-Source: ABdhPJw6w0Zi8W9bt5228Ldv0ZCK8SRbrpkPWfvrUH89RTZAP9oilxdXqZv6iwBHs+Ol+3+gMO/PVdwFbqZjbjRk+f4= X-Received: by 2002:a05:6808:3012:: with SMTP id ay18mr10076246oib.88.1637260994768; Thu, 18 Nov 2021 10:43:14 -0800 (PST) MIME-Version: 1.0 References: <20211118095852.616256-1-anders.roxell@linaro.org> <20211118095852.616256-2-anders.roxell@linaro.org> In-Reply-To: From: Nick Desaulniers Date: Thu, 18 Nov 2021 10:43:02 -0800 Message-ID: Subject: Re: [PATCH v3 2/2] selftests: clone3: simplify return logic in clone3_set_tid() To: Anders Roxell Cc: shuah@kernel.org, fenghua.yu@intel.com, reinette.chatre@intel.com, john.stultz@linaro.org, tglx@linutronix.de, akpm@linux-foundation.org, nathan@kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, llvm@lists.linux.dev, christian@brauner.io Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: o1if3ztjifu83yedz7hjg5u51fzg4pcn Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=dfb4NHDv; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf10.hostedemail.com: domain of ndesaulniers@google.com designates 209.85.167.182 as permitted sender) smtp.mailfrom=ndesaulniers@google.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: E89E56001ABD X-HE-Tag: 1637260994-312833 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000022, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 18, 2021 at 2:03 AM Anders Roxell wrote: > > On Thu, 18 Nov 2021 at 10:58, Anders Roxell wrote: > > > > Use ksft_exit_* and exit instead of using goto. > > > > I'm sorry, I should have added Nick to this patch, since he suggested it. > > Suggested-by: Nick Desaulniers > > Cheers, > Anders > > > Signed-off-by: Anders Roxell Thanks for the patch! Reviewed-by: Nick Desaulniers > > --- > > tools/testing/selftests/clone3/clone3_set_tid.c | 11 +++-------- > > 1 file changed, 3 insertions(+), 8 deletions(-) > > > > diff --git a/tools/testing/selftests/clone3/clone3_set_tid.c b/tools/testing/selftests/clone3/clone3_set_tid.c > > index a755fcd3af89..1b950c3c3b7c 100644 > > --- a/tools/testing/selftests/clone3/clone3_set_tid.c > > +++ b/tools/testing/selftests/clone3/clone3_set_tid.c > > @@ -250,7 +250,8 @@ int main(int argc, char *argv[]) > > * that all those tests are skipped as non-root. > > */ > > ksft_cnt.ksft_xskip += ksft_plan - ksft_test_num(); > > - goto out; > > + ksft_exit_skip( > > + "Please run the remaining tests as root - Exiting.\n"); > > } > > > > /* Find the current active PID */ > > @@ -371,9 +372,7 @@ int main(int argc, char *argv[]) > > close(pipe_2[1]); > > > > if (waitpid(ns_pid, &status, 0) < 0) { > > - ksft_print_msg("Child returned %s\n", strerror(errno)); > > - ret = -errno; > > - goto out; > > + ksft_exit_fail_msg("Child returned %s\n", strerror(errno)); > > } > > > > if (!WIFEXITED(status)) > > @@ -390,10 +389,6 @@ int main(int argc, char *argv[]) > > ksft_test_result_fail( > > "PIDs in all namespaces not as expected (%d,%d,%d)\n", > > ns3, ns2, ns1); > > -out: > > - ret = 0; > > > > - if (ret) > > - ksft_exit_fail(); > > ksft_exit_pass(); > > } > > -- > > 2.33.0 > > -- Thanks, ~Nick Desaulniers