From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCFFCC77B78 for ; Wed, 26 Apr 2023 17:44:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F8806B0113; Wed, 26 Apr 2023 13:44:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A8A06B0114; Wed, 26 Apr 2023 13:44:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 397D96B0115; Wed, 26 Apr 2023 13:44:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 286C06B0113 for ; Wed, 26 Apr 2023 13:44:08 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id F049012016A for ; Wed, 26 Apr 2023 17:44:07 +0000 (UTC) X-FDA: 80724265734.16.8AC390C Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by imf29.hostedemail.com (Postfix) with ESMTP id 2EB9412001C for ; Wed, 26 Apr 2023 17:44:05 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b="f2sJj/rm"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf29.hostedemail.com: domain of ndesaulniers@google.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=ndesaulniers@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682531046; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MkGjo2+2375PCfjVY7hF/s90ur+eiDatH//mQnrGyYw=; b=0cvUk6TcYBPJ9bCMkTbxeQA0PjwL9+rZmN1gYhyRIQCtdLdUtYhnlRFhBfj2t3zI+BxHEi LnhxaK9xiCYJAhmdXEdZUk36gj8CAleDVDrlazBCU/LXUONhvgfGKixDVfTTIOJVqBW+WC DJtCirxc0VDjb6Wwgg2cbjwXvv+dNd8= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b="f2sJj/rm"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf29.hostedemail.com: domain of ndesaulniers@google.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=ndesaulniers@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682531046; a=rsa-sha256; cv=none; b=jD3BtLkxEDTHUrY92gJ9g3iKNFMIIsVXpylXgLgQ90Jp9o1utul7+t7SeMJ1WZTDlmMc0l AGnL80b2NBXLWarG/MKGEf6eEnrcbhLHakelazdVVl/7vR/y0bgGIMAlVyFrMBp8/Rc74O TNM+bbkkWK6vtZ10mTAzu6+SBJRsat8= Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-24735727c83so5207326a91.3 for ; Wed, 26 Apr 2023 10:44:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1682531045; x=1685123045; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=MkGjo2+2375PCfjVY7hF/s90ur+eiDatH//mQnrGyYw=; b=f2sJj/rm0k1KK5yK8qzFmFUzb279bZdN0nIYZG6OD6iG4UNN2VQwb+cfdm4lkj7bJG XrRNVL9LYBWnA4ryeN1Zmk9j2n2cfykj+5MWvInqPF6YO/BHB49vuqmcFl0v/HTKVLV3 f22BOrCkICsU95Eiv9+MWfLfLu9rhyjznyceZUABoMNIRrlLP88VLhP577fQ6hmVsjCG FXgcZNp/UHwbv2wRb3x3p0qUG0SGANQXmMxtp1331J/cPRqiaQ62Pdq0I/bZT4WWFqt5 04jENzwN3OJBWkSTuB/bg3tXx0mobU6VLJ69w+oN5/xkysNjcnkioRNcKi3axedIlGSr v38Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682531045; x=1685123045; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MkGjo2+2375PCfjVY7hF/s90ur+eiDatH//mQnrGyYw=; b=DdV+aNl0B0ze0P5/4ImyCrk4vh+o7RRVECocWgR381oxkJd1hCLtlYTb0xp9dzzuL+ 2ePb3yMYE9kqs/M4WazJBIJExY6Q7nS1B3Tu5ZSEgut2QEfcVRPTXYpboGpZX5demtfu Iov//iFOPJijRirZOokVeWL/wany2l9rTkQ05XOjfqxTMRtRekZrkqUEkha/UGOFlGNT ayr4zDTbxUpqiCjEUGZd6juLxcaHj3f/9uvpUAXH2m2+YHr4H09TNDaUzJ3ybj+eqXS8 scQZlOhCF9+6pJ7xLvWZ/qxL4zLFVKDbbYkNK+BAJKGML9T/wjBkQoyNSnYaYOOd6AF5 7DrQ== X-Gm-Message-State: AAQBX9edcE1Gju8cjt7rjoB1NKgowUcrsSkxUdwXm+qzeOHoV72TA3Ud Zgc92ivMubsQxxG2eVegiYdmKUwflGbsZNlr1QSmEg== X-Google-Smtp-Source: AKy350a3QijOLOYirVJQ+LPQGzUuYKBvcHvFq+4/6XCgjnCKVtQVpBuWtiW0KPRC0FCky+dux08Zt0QjvknG4kh0Lvo= X-Received: by 2002:a17:90b:4a8b:b0:24b:b36f:8219 with SMTP id lp11-20020a17090b4a8b00b0024bb36f8219mr11315844pjb.13.1682531044886; Wed, 26 Apr 2023 10:44:04 -0700 (PDT) MIME-Version: 1.0 References: <20230425041838.GA150312@mit.edu> In-Reply-To: From: Nick Desaulniers Date: Wed, 26 Apr 2023 10:43:53 -0700 Message-ID: Subject: Re: [GIT PULL] ext4 changes for the 6.4 merge window To: Linus Torvalds Cc: "Theodore Ts'o" , Nathan Chancellor , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 2EB9412001C X-Stat-Signature: xyg4bi6nuaonzq99jszy1jqnyhoaf46o X-HE-Tag: 1682531045-105939 X-HE-Meta: U2FsdGVkX1+35rS3yiQU+SD/5X0uWcS0zyADTgolNkrcgXR8xWazQ5jVhMLHxgLYtJD756NkOcw4YDM10TM186CgDl10bNyImtBN2AII1CIXxF53nq8L7CjOSDIxdetea3vV5D28R+m8O1VPuXnb6D7+H4g58sQ4LJLMyaxEzWJ/pVwhW7JUlX2z1lDspka4cT5vg3X6EQ+6eT5WGoUzJRxSxtSOiM4iFo67xi/MoCqudI9sWGYpTSpHpjzYCjvWq93Pd0+6w60+ItkQlNACz1eshXX0yKfCvoIV6SR6WBiKhXNYMBPAcBqy4exfdvz8Hq6ji8wwReKvlZ/8iH+Cy8cgDJIkx3IKFRFpiseH+ZI0H7CQWBVzPb070kUpr9fJccIr9hogSdF+uE7jLmC5HcfDxD10xGfZTJXwbPNS7puZXOdBYP0mYAWKD5lBXhp3ZydkQUXvtbvUS3ZoBuKm090GTsUK5Qes38f7awVgBTM0jOfzb055F9CZg4nZDWlHq2DVCSbg6QgZ+augq8WSWdFg1EpZtFfG6T/bqGEpjFHUe03cJqlrm8uOyh2LGaTnwSO0ur74kEFM1dXRa7gaDEddJemzjkbt8Yv1c+cxnlNolQWK0H/D+GrrsysNodXSXOuDp55KlM5ohnPAtbfGvHLTDIUTa4b6DJjSaHjNvj4K77AEJi7VPigcn+/RJat4eFD/j0SPYRzjkY8I5q4fw2cz8ItogGlclIDyajWiXudUoDT+RNkvflArXwJxRw4Uk9Uv8iWqPXYjaON1ehX0jNLZbAPHRVAcGzsI4S4syvz+FMa0v8YYlEyCc1M1xlQDLIKvGVek7FGQ/Eo6C90AMzkg4uXKXiCVqulvGylDbgfEGBikhAHYa4GXhPh2KSeXBqohbpwuwesjWkYWCiG9Bo1g/9bEo+hMn3rnACbn0v9S6bl487rtlxGdKHIsyQL85kGvpsbPuPp2eCaY1Eu OwkGlTPB XBqQsmDdGjUmz5Ia5DOTpqx1MhkztzoXpO+stLFTtmUIu+A71hkOE3udw6AEMhQJSvuUi74ChMuhP5Tbb9nwX+e4l83JiDpLQpvZqFhbNuNjzaS5Fb69wuZlwQXpT9ceqMY7UOV+Rou7BxlvsH8XzC9CWOESTIyLcSJNP78JuHeQ+nLdZNyy7juekYZ/5EDdib49k6WEVAS2HZicQ/BKC/+cb/oYsh3ZmRKPieN60c64D25SazAnXwfMeMgSLxPCDnKoxj8wvuXMQ1OTSKAK0oLf8n3aGdtoGINPtxukScX+6AZuqkYAP+OT+daweQHlNzU55Qh8g2+jEd3xbUf6u9L0HjayW2VX0mqL8EptidAVj4AXu82753/s5U2QFBMe4dXcJQk7KsLKyp9mttOA0sakJagKadL7D8y4xfpEFM3v9iAAIlKjCPw37E00YGzQ70swR1hQitLWUdk84VJhcuKQpFYRzGuRrdh3A X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 26, 2023 at 10:36=E2=80=AFAM Nick Desaulniers wrote: > > On Wed, Apr 26, 2023 at 10:34=E2=80=AFAM Nick Desaulniers > wrote: > > > > On Wed, Apr 26, 2023 at 10:03=E2=80=AFAM Linus Torvalds > > wrote: > > > > > > On Mon, Apr 24, 2023 at 9:18=E2=80=AFPM Theodore Ts'o = wrote: > > > > > > > > Please note that after merging the mm and ext4 trees you will need = to > > > > apply the patch found here[1]. > > > > > > > > [1] https://lore.kernel.org/r/20230419120923.3152939-1-willy@infrad= ead.org > > > > > > > > This is due to a patch in the mm tree, "mm: return an ERR_PTR from > > > > __filemap_get_folio" changing that function to returning an ERR_PTR > > > > instead of returning NULL on an error. > > > > > > Side note, itr would be wonderful if we could mark the places that > > > return an error pointer as returning "nonnull", and catch things like > > > this automatically at build time where people compare an error pointe= r > > > to NULL. > > > > That's what clang's _Nonnull attribute does (with -Wnullability-extensi= on). > > https://godbolt.org/z/6jo1zbMd9 > > Ah sorry, I _thought_ that's how _Nonnull worked on return types. Let > me dig some more and see how that's supposed to work... I guess this is how I'd have expected _Nonnull to work on return types. https://godbolt.org/z/Yb7PdWv8q I'll check with the team to see if there's interest in expanding this check. Would be nice to have a GNU C __attribute__ syntax for this as well, for eventual portability. --=20 Thanks, ~Nick Desaulniers