From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12BB8C77B73 for ; Tue, 2 May 2023 14:35:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7183B6B007B; Tue, 2 May 2023 10:35:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C8A96B007D; Tue, 2 May 2023 10:35:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B7396B007E; Tue, 2 May 2023 10:35:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-oo1-f42.google.com (mail-oo1-f42.google.com [209.85.161.42]) by kanga.kvack.org (Postfix) with ESMTP id 3EF5D6B007B for ; Tue, 2 May 2023 10:35:31 -0400 (EDT) Received: by mail-oo1-f42.google.com with SMTP id 006d021491bc7-541b5cfa9d8so2073482eaf.0 for ; Tue, 02 May 2023 07:35:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1683038130; x=1685630130; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=r0vZEv/FmAjqR4OATKlbblWETdmbuJQmkbVqTAuStBc=; b=3ry20V3oDonFJe7vFzyD7m6gn+1DvZJJGHoX2lkccC7J7XNjd4/1nU6e8lehA81kOX WSmExy0PWSwHXwtdA3kCL5hBlalcybOtnfLu3HVtWLUa6YCzczg+/MO5w/H5wBIQN9tM kWLS0TJXSsiYyehS7tsGZUL6WNtrDr/BpkojwBfcZuYOBNjVWAalOVReUM13T/9h3mUD SqTh2m83AIa6K6ltf0hbS+Zd3JKxNXbnFxYb7XbCrdl+3gm+yFigKXrb0k2lsDvaXnM/ nw8200C6Nrz+xnGhiGtytD23FSXXuuGmOQCyV6xJKrVSr82UL6owkaAUss5TF5vmXD1g iLtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683038130; x=1685630130; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=r0vZEv/FmAjqR4OATKlbblWETdmbuJQmkbVqTAuStBc=; b=Rt3dDd2OXRbLPdrqTs+BiKmqMWR+u31RvepLNQnWHUKNcZc41/qzbikf5+rY4YnlWO M+sxpADjpryHIDJxGNDUCDmjX/h8mZw7U7HflQ8OWwxTypeIVsTxptoyI8HGVpCIv9Af 8RvroQX9u72IzzPs413C3DgdUeBntkxxtfUYv+93tmsl0F8dnVNL9CJkBqHmORgpDf3+ Ry06dx5Y1C7XiuwVvW7oTkAD9857pjHzVvQat3M9xFjKS+o+J2eM02ystjANEFIFiExH +004DDG1PdU5DIAjDuKN9pxSzKDdRrL2GJMaQNW3+lKRyGQ6k0cAXpPTOCbts4N7xP0W LMdg== X-Gm-Message-State: AC+VfDxcAVJvnYqzK0RR08dOQ1khsFM/JggtfF7FqG/b541CVojNKI1d 4g13NoAiuC3lcDEFMVN+kujiu/1wh7Nnsrt1V5MhExpEm4u21pnhH7o7Mg== X-Google-Smtp-Source: ACHHUZ7jIPANuM1sqTIbuiAlms9FW/dcjpUfPf8qR/hIGsTZHUlWNVU5LIbFTwoJV+QoEkulsThBRTy4qagbvX+vERw= X-Received: by 2002:a17:902:e744:b0:1a6:b23c:3bf2 with SMTP id p4-20020a170902e74400b001a6b23c3bf2mr18550422plf.10.1682980250619; Mon, 01 May 2023 15:30:50 -0700 (PDT) MIME-Version: 1.0 References: <20230215143306.2d563215@rorschach.local.home> In-Reply-To: From: Nick Desaulniers Date: Mon, 1 May 2023 15:30:38 -0700 Message-ID: Subject: Re: [PATCH v3 1/3] kasan: switch kunit tests to console tracepoints To: Peter Collingbourne Cc: Steven Rostedt , Marco Elver , andrey.konovalov@linux.dev, Andrew Morton , Andrey Konovalov , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov , Masami Hiramatsu , linux-trace-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 1, 2023 at 3:02=E2=80=AFPM Peter Collingbourne = wrote: > > On Thu, Feb 23, 2023 at 10:45=E2=80=AFPM Peter Collingbourne wrote: > > > > On Wed, Feb 15, 2023 at 11:33 AM Steven Rostedt w= rote: > > > > > > On Wed, 15 Feb 2023 09:57:40 +0100 > > > Marco Elver wrote: > > > > > > > Yes, you are right, and it's something I've wondered how to do bett= er > > > > as well. Let's try to consult tracing maintainers on what the right > > > > approach is. > > > > > > I have to go and revisit the config options for CONFIG_FTRACE and > > > CONFIG_TRACING, as they were added when this all started (back in > > > 2008), and the naming was rather all misnomers back then. > > > > > > "ftrace" is really for just the function tracing, but CONFIG_FTRACE > > > really should just be for the function tracing infrastructure, and > > > perhaps not even include trace events :-/ But at the time it was > > > created, it was for all the "tracers" (this was added before trace > > > events). > > > > It would be great to see this cleaned up. I found this aspect of how > > tracing works rather confusing. > > > > So do you think it makes sense for the KASAN tests to "select TRACING" > > for now if the code depends on the trace event infrastructure? > > Any thoughts? It looks like someone else got tripped up by this: > https://reviews.llvm.org/D144057 https://reviews.llvm.org/D144057#4311029 Peter, please triple check. --=20 Thanks, ~Nick Desaulniers