From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B74C5C433E0 for ; Mon, 22 Feb 2021 17:04:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 38CE664F00 for ; Mon, 22 Feb 2021 17:04:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 38CE664F00 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 93CA16B0006; Mon, 22 Feb 2021 12:04:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C5F86B006E; Mon, 22 Feb 2021 12:04:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B44C6B0072; Mon, 22 Feb 2021 12:04:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0075.hostedemail.com [216.40.44.75]) by kanga.kvack.org (Postfix) with ESMTP id 6291D6B0006 for ; Mon, 22 Feb 2021 12:04:54 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 2317B181AEF2A for ; Mon, 22 Feb 2021 17:04:54 +0000 (UTC) X-FDA: 77846528508.12.064375B Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) by imf20.hostedemail.com (Postfix) with ESMTP id 69E8CFB for ; Mon, 22 Feb 2021 17:04:52 +0000 (UTC) Received: by mail-ot1-f51.google.com with SMTP id k13so2126500otn.13 for ; Mon, 22 Feb 2021 09:04:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=z7OgXqZeLnUH8RQA8mRalhelxea7D0oLKL6AR8A4Y8M=; b=FwrRkU31K8YwULwksKEmq02zHpRMy3BSyw5XxNEbKlNtZGRrFIUdaux1GnV+ZLCW4D sN6C+AUMMxYW12F9BrVOa9u8XuO4PKdL4OsjqnLjvyYm41nH3FSuh843zkDdwGrB2z+y SRH+9lTUF18P0N3bq8jgRxQpXJiiV3F6ITB8MU+W2HgyJYm8wC5OoM7qQKtxO0guiF9z fhuHoP9Z3wLj1Nfbuquu9wtrsHb2+r2xLnYgaihxRTgtrrCS2KJvEE0D+I9N2QVKimbK 7NTJg8EKKH9tjrlSaqGEISqF10sfOPONDmFmgqALHRhC532divEevQG+9QTldFC8Bamv 6fTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=z7OgXqZeLnUH8RQA8mRalhelxea7D0oLKL6AR8A4Y8M=; b=pChrf3VaFCUF8/Fp5xWIWiKCC6hpip/TVdtMMvM5P3lJP8o69eZLCd9RnSgz3V+uIX GueGAqJwBS8qCJrsQ5OnpmajlPpivIyKOlZ0o2gW4nlPV6B2FgbH1FSy43bi8R8wooWa Og12R3CfT/FI1tynTQtjfiLLv5qnRs7klcT6S0aTHvleBojBO6qmcZmKj0+NrIFkAYmT kib4LmFbCL8mwgeAs+Qvc16egcKIPXx6xXY72Etx+jCIAtI1LBbh+OAMF17PIic234jb 7LtyBW5IIu+kn+6LBFUH7TeTlJ75CKljBoQsJbOGgWknYm53yn+/0X7MSHw84lDOMYHL AVBw== X-Gm-Message-State: AOAM530VSO7Cfvn6ZL+MTytd8MvcFfQdITrjEt2dbhWOz46n80CeITRo DqC2jkqwB6vZMIVDivQyJr+caFVuJibLELQiVXIGQg== X-Google-Smtp-Source: ABdhPJwLWt1IfYDfw+eooNasbvCERux3cYlEkam5/txPYyzRJ/DjlRMW0HvI90bb9J0eeL1sP1jlwc7vYvnil6AAu/s= X-Received: by 2002:a9d:5d1:: with SMTP id 75mr16969345otd.20.1614013491235; Mon, 22 Feb 2021 09:04:51 -0800 (PST) MIME-Version: 1.0 References: <20210215204909.3824509-1-willy@infradead.org> <20210219195509.GA59987@24bbad8f3778> <20210219205403.GX2858050@casper.infradead.org> In-Reply-To: <20210219205403.GX2858050@casper.infradead.org> From: Nick Desaulniers Date: Mon, 22 Feb 2021 09:04:40 -0800 Message-ID: Subject: Re: [PATCH] mm/gfp: Add kernel-doc for gfp_t To: Matthew Wilcox Cc: Nathan Chancellor , Andrew Morton , Linux Memory Management List , Mike Rapoport , clang-built-linux , Miguel Ojeda , Jonathan Corbet Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: yb1sto9m8cs8zudrkuomgnkm9hyi8ktm X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 69E8CFB Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf20; identity=mailfrom; envelope-from=""; helo=mail-ot1-f51.google.com; client-ip=209.85.210.51 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614013492-517061 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 19, 2021 at 12:55 PM Matthew Wilcox wrote: > > On Fri, Feb 19, 2021 at 12:55:09PM -0700, Nathan Chancellor wrote: > > On Mon, Feb 15, 2021 at 08:49:09PM +0000, Matthew Wilcox (Oracle) wrote: > > > The generated html will link to the definition of the gfp_t automatically > > > once we define it. Move the one-paragraph overview of GFP flags from the > > > documentation directory into gfp.h and pull gfp.h into the documentation. > > > > > > Signed-off-by: Matthew Wilcox (Oracle) > > > > This patch causes a clang warning in basically every file on linux-next > > now: > > > > include/linux/gfp.h:20:32: warning: redefinition of typedef 'gfp_t' is a C11 feature [-Wtypedef-redefinition] > > Seems like it's also a gnu89 feature. Is there a preprocessor define when using kernel doc that you could guard the redefinition with? See include/linux/phylink.h which uses: #if 0 /* For kernel-doc purposes only. */ to guard definitions for kernel-doc. -- Thanks, ~Nick Desaulniers