From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EF77EB64DB for ; Thu, 15 Jun 2023 21:02:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A29D6B0072; Thu, 15 Jun 2023 17:02:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4527F6B0074; Thu, 15 Jun 2023 17:02:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F3EC8E0001; Thu, 15 Jun 2023 17:02:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2031C6B0072 for ; Thu, 15 Jun 2023 17:02:12 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B7C001C8454 for ; Thu, 15 Jun 2023 21:02:11 +0000 (UTC) X-FDA: 80906204862.23.098D9EB Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) by imf21.hostedemail.com (Postfix) with ESMTP id B2E161C000B for ; Thu, 15 Jun 2023 21:02:08 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=r3+18zMp; spf=pass (imf21.hostedemail.com: domain of ndesaulniers@google.com designates 209.85.219.53 as permitted sender) smtp.mailfrom=ndesaulniers@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686862928; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gM071qijEG6vwQ8W2iWjOXAWrKZk2GbsTR59ysMJ+f0=; b=HiOpAmjoLMLaBNXGTZUWUXu3c9jV0xvihlzWGwATz9b1cUtwmVG5xmbC9L33K7Rw4MA2mZ jeZNhNBokIX3fIZzIzHcNpvDwe+JZnSlJ7dV1fMaoKkCX+rslyTcTEIcZ4TIMG6eqOzp9M UyPebpXWk2dVr3Gp61d3R1h0Nvn069o= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686862928; a=rsa-sha256; cv=none; b=S0pxH2i3eNeqrCtXn8G2WjcQacrK2cbPCI41gWZFvzFwaKgqPPhw2xk83ns+V9QxoiUcUp wu7iCktcCac6mMy6QYFKI346kFLcJOV1Cxaj1C+mi6TtbjZTrHrMhjDPW30kjUc48IBVJi pxe7I4Gm+vnqDMflmkyN3zW7yCLP8xE= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=r3+18zMp; spf=pass (imf21.hostedemail.com: domain of ndesaulniers@google.com designates 209.85.219.53 as permitted sender) smtp.mailfrom=ndesaulniers@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-qv1-f53.google.com with SMTP id 6a1803df08f44-62df53196edso1041326d6.3 for ; Thu, 15 Jun 2023 14:02:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1686862927; x=1689454927; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=gM071qijEG6vwQ8W2iWjOXAWrKZk2GbsTR59ysMJ+f0=; b=r3+18zMpdGu3FBIH/XR/CeWPIdLuk9aHwOyPzPMPD+aHBmCQpHV+CqHUcVxkyh3f56 fQ7+hwVRMsFfVJ6+fAgFxywc9Ey5lBpqCJ1GP/M6gvUqaPeqlGn+b+LTUfV+eWSTjehP AttQBBokUk9dBF//9b4mMJFpP/2IYaDEkFoGTV/xU2CUd5Kss+CHXPeuI2SnlPARzQjV 627F9+EcbOVoZxCvs6FMh/M6bErKb9BknEk6bpMOEacDUXg9U3FvnUNrB1OD8WsQ5mpN ftALbqUPSTzgQw4ZxwDtP2xWijGeHdmJZRHt9ceN4vbAImdo/Irw3ryRWU7EZjVnA/Lw osEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686862927; x=1689454927; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gM071qijEG6vwQ8W2iWjOXAWrKZk2GbsTR59ysMJ+f0=; b=Bfs1+NEAcGjdYihgwX0prxtTcQM2ZOzZgHM6MstC23w8vakpie+6AGxdSGTPjEhP9x ucPfHlw1xsVRAaeF6d5ulUpi1e1pSwfkBRf88iiS9Z3P6Je1qr3o9JApEtEc5Wtb0m1/ v/MrssIClufq59bqPKE5sCc/FxDd3cGgYfEtL4tCC/VHeXk+Ki8ZqLAixm6QAzLtXajS WVbO8C6st9gVkFirArrhpv/ieRcK5ywTwjvO6JBinJPy/pAb2FNY4Oj4gUzTs+ovLTFO KUw7NA/J3GzZJExE9/GLpBMy77BFu3dE08US5NAxx4l9iWdYQjgaSqS9OiFMJ4SgU77j s7Rg== X-Gm-Message-State: AC+VfDzUWKKuBpuXC4/bAO9qrMC1B6FCfasPD2S1ue75m4hSSp4Oftjs q/TrRVqR+LY7zP6oMxojzh/5h0FgYYyJHCCvExZPQA== X-Google-Smtp-Source: ACHHUZ4krPXQb/OSjDusqHVygPJ8Ls9dUMXR5x901QOHwbeTZhZdMqBueLHq0YUPgxe/cr08Jcvy1LCoC+5/N/PO2+Y= X-Received: by 2002:ad4:5d62:0:b0:62f:f23e:14fe with SMTP id fn2-20020ad45d62000000b0062ff23e14femr102715qvb.20.1686862927549; Thu, 15 Jun 2023 14:02:07 -0700 (PDT) MIME-Version: 1.0 References: <20230614-kselftest-mm-llvm-v1-1-180523f277d3@kernel.org> In-Reply-To: <20230614-kselftest-mm-llvm-v1-1-180523f277d3@kernel.org> From: Nick Desaulniers Date: Thu, 15 Jun 2023 17:01:56 -0400 Message-ID: Subject: Re: [PATCH] selftests/mm: Fix cross compilation with LLVM To: Mark Brown Cc: Andrew Morton , Shuah Khan , Paul Walmsley , Palmer Dabbelt , Albert Ou , Nathan Chancellor , Tom Rix , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 9frmy74fojce3jdim9id7kadwj34sc7x X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: B2E161C000B X-Rspam-User: X-HE-Tag: 1686862928-943450 X-HE-Meta: U2FsdGVkX193SfYvUJHAjY8iHbJY4gTsR2/jltGC0v7sC4b2l1KQPHSLynn3JB04RKhFselF2tsIk4OHXwb/EgoIZJoo60TikCuEvUIgklb3DiACm1iI/04tWTKU3EP7qflIeQFofzY3wK7yVfVr0LdCzjXinhOZR+arVrMUfWHeLPOBXDVb4BYbjqllxlQ8RK2nJR31NT295oV5OKKbq5ZMMg1xI6iQzF4JOEINjeDWXe8NKmQfz3xQ3D7GRipt4ObTuswn5603JD1ynr9UigBUEGhKt17OofPGD1HOzK3jbaaHipZ5eA3nJz14dH+nGJ44IkEz5Y0UR0UnAnDhbzYWDSjZR4KmVpWJ9DsfQtn4JwDi6ZbaIf/Y5a3p95tD0EsYzqhfYaNbdQwNKjHYfmobGrhz9NS0Nwf7by6RLW+ZKXVpZWOJIdCs57vWU7YKV8efc6IAWSHz6iE9UfoLoEncPSUhQea3nS1BV+YDAYElbV4vJMUNCbnLzUoFja+6sEC/Dip2ot9uIUk5SlaECs8Zj5DffrFQjW7vzGdxaMKqyl+AFziHP/X0xnfh7dWHyYK2HNHlHRlNkpb2o7JUqncFLezjCzlSe5qkPHc6sEAGkzgZqJ3tGhVSRLpu4Q8oTNMeOM5wKcMzEIDOSbalN12zHVZUaCldPrwfQ0Pf7LYyCGDoout7HZup8qq9H+QCYBq5rSrhxXxeiWEIcE7YEKlN+1jF1Qpv9+dMoMj1Sg5T0jnyWug4EjUmvMMzTWq8dih9dxYcJECx1lXkuxRuY7PDynl0yrgBJzMFkcFFKY1E4UEVOQZfEuPwn0l/1P/0Wu8PVK9o/9wjiw5692w+Rnk6CDKTG5g/iSpuwCjGQjp98+9LfrwccHwSBSrMzzGkaQZk70jOX0jZiWTVRA5LfR1dA7KZNbrQbPbqaxpS+88sbQiWn4dbHlsNRmVX+s9uF4yDgErQJoG/TPOqW9B mQFUoduc 0Vr39fQ915hAlnxCIvQ0q0wk0AYZSS5O9gkoWGUn2iYyoA1llnxykXfvEI368CWjUIkz9xnEKrRf+IKz7wSYGEBX6T7GMi+MESiejaos+bzu2BI3DkZEJ7vrHQcJHxYlEWmLojs9CRyQLhDlqhTiP3j4K+Ud8MfWCfhiY41y3/mt97vb28lNpa0haF8g/HNHA9zAEK0mPGnPKKJOdSQuv4yySAGM212nn5tt77b4cVQIl9V6npNqHxs42alRiq2N3BhGbTw1h+sQQ0aMzcIA07EkMRgKEZK/R3H2+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 14, 2023 at 5:19=E2=80=AFPM Mark Brown wro= te: > > Currently the MM selftests attempt to work out the target architecture by > using CROSS_COMPILE or otherwise querying the host machine, storing the > target architecture in a variable called MACHINE rather than the usual AR= CH > though as far as I can tell (including for x86_64) the value is the same = as > we would use for architecture. > > When cross compiling with LLVM we don't need a CROSS_COMPILE as LLVM can > support many target architectures in a single build so this logic does no= t > work, CROSS_COMPILE is not set and we end up selecting tests for the host > rather than target architecture. Fix this by using the more standard ARCH > to describe the architecture, taking it from the environment if specified= . > > Signed-off-by: Mark Brown Broonie, Thanks for the patch! What's the best way to test this? $ ARCH=3Darm64 make LLVM=3D1 -j128 -C tools/testing/selfte sts/mm/ Is what I would have guessed, but I get errors with or without this patch. Also, fwiw, b4 shows that you don't have a pgp key setup for broonie@kernel.org; I don't think it matters, but maybe it's a surprise to you if you thought you had set that up, $ b4 shazam https://lore.kernel.org/llvm/20230614-kselftest-mm-llvm-v1-1-18= 0523f277d3@kernel.org/ ... =E2=9C=97 No key: openpgp/broonie@kernel.org > --- > tools/testing/selftests/mm/Makefile | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selftest= s/mm/Makefile > index 23af4633f0f4..4f0c50c33ba7 100644 > --- a/tools/testing/selftests/mm/Makefile > +++ b/tools/testing/selftests/mm/Makefile > @@ -5,12 +5,15 @@ LOCAL_HDRS +=3D $(selfdir)/mm/local_config.h $(top_srcd= ir)/mm/gup_test.h > > include local_config.mk > > +ifeq ($(ARCH),) > + > ifeq ($(CROSS_COMPILE),) > uname_M :=3D $(shell uname -m 2>/dev/null || echo not) > else > uname_M :=3D $(shell echo $(CROSS_COMPILE) | grep -o '^[a-z0-9]\+') > endif > -MACHINE ?=3D $(shell echo $(uname_M) | sed -e 's/aarch64.*/arm64/' -e 's= /ppc64.*/ppc64/') > +ARCH ?=3D $(shell echo $(uname_M) | sed -e 's/aarch64.*/arm64/' -e 's/pp= c64.*/ppc64/') > +endif > > # Without this, failed build products remain, with up-to-date timestamps= , > # thus tricking Make (and you!) into believing that All Is Well, in subs= equent > @@ -65,7 +68,7 @@ TEST_GEN_PROGS +=3D ksm_tests > TEST_GEN_PROGS +=3D ksm_functional_tests > TEST_GEN_PROGS +=3D mdwe_test > > -ifeq ($(MACHINE),x86_64) > +ifeq ($(ARCH),x86_64) > CAN_BUILD_I386 :=3D $(shell ./../x86/check_cc.sh "$(CC)" ../x86/trivial_= 32bit_program.c -m32) > CAN_BUILD_X86_64 :=3D $(shell ./../x86/check_cc.sh "$(CC)" ../x86/trivia= l_64bit_program.c) > CAN_BUILD_WITH_NOPIE :=3D $(shell ./../x86/check_cc.sh "$(CC)" ../x86/tr= ivial_program.c -no-pie) > @@ -87,13 +90,13 @@ TEST_GEN_PROGS +=3D $(BINARIES_64) > endif > else > > -ifneq (,$(findstring $(MACHINE),ppc64)) > +ifneq (,$(findstring $(ARCH),ppc64)) > TEST_GEN_PROGS +=3D protection_keys > endif > > endif > > -ifneq (,$(filter $(MACHINE),arm64 ia64 mips64 parisc64 ppc64 riscv64 s39= 0x sparc64 x86_64)) > +ifneq (,$(filter $(ARCH),arm64 ia64 mips64 parisc64 ppc64 riscv64 s390x = sparc64 x86_64)) > TEST_GEN_PROGS +=3D va_high_addr_switch > TEST_GEN_PROGS +=3D virtual_address_range > TEST_GEN_PROGS +=3D write_to_hugetlbfs > @@ -112,7 +115,7 @@ $(TEST_GEN_PROGS): vm_util.c > $(OUTPUT)/uffd-stress: uffd-common.c > $(OUTPUT)/uffd-unit-tests: uffd-common.c > > -ifeq ($(MACHINE),x86_64) > +ifeq ($(ARCH),x86_64) > BINARIES_32 :=3D $(patsubst %,$(OUTPUT)/%,$(BINARIES_32)) > BINARIES_64 :=3D $(patsubst %,$(OUTPUT)/%,$(BINARIES_64)) > > > --- > base-commit: 858fd168a95c5b9669aac8db6c14a9aeab446375 > change-id: 20230614-kselftest-mm-llvm-a25a7daffa6f > > Best regards, > -- > Mark Brown > > --=20 Thanks, ~Nick Desaulniers