From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6BBBC27C79 for ; Thu, 20 Jun 2024 21:18:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2ED668D00E6; Thu, 20 Jun 2024 17:18:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 29B028D00D5; Thu, 20 Jun 2024 17:18:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 13BE48D00E6; Thu, 20 Jun 2024 17:18:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E37518D00D5 for ; Thu, 20 Jun 2024 17:18:03 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8CEAD160640 for ; Thu, 20 Jun 2024 21:18:03 +0000 (UTC) X-FDA: 82252529646.18.DCA84B8 Received: from mail-vs1-f44.google.com (mail-vs1-f44.google.com [209.85.217.44]) by imf22.hostedemail.com (Postfix) with ESMTP id C8857C001E for ; Thu, 20 Jun 2024 21:18:01 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=VL4iGnnZ; spf=pass (imf22.hostedemail.com: domain of ndesaulniers@google.com designates 209.85.217.44 as permitted sender) smtp.mailfrom=ndesaulniers@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718918277; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bWxCTNrmZRMZjk6xShuBA8spgETA5SXOSONvnp9DFsQ=; b=CAj5LA+VpmzcEgqfw3GcKbLML7Xni/T+hocz8eYSIwcwQinUsZnLLD1oXoFwDov8xrZFI3 T162inQBD6G+GNp03OCDn3FbeFprp3PS+M2I6lCS4KyrXSMpPhk5ITv9FmSTN7f4hBsJKh wi7+53xtU1KljUp4shWSkNVwCCMaEFM= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=VL4iGnnZ; spf=pass (imf22.hostedemail.com: domain of ndesaulniers@google.com designates 209.85.217.44 as permitted sender) smtp.mailfrom=ndesaulniers@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718918277; a=rsa-sha256; cv=none; b=MennjRVsxAKqJQe51uXxZB3cSCYKXOGsS5EGtA1Wp4ltmg3vkb5Q+cC1hec5Y7hshSwjGM kpOLUFLvCGCn2CK8fJHxoiwRXQqI6QQ6rOgIGTMUWzLtJImFae6rUXYKAu7E91/rAKiw/3 j83VQPUd9jIrc+elhjlc0YAPz+zMdok= Received: by mail-vs1-f44.google.com with SMTP id ada2fe7eead31-48c390a1054so499504137.0 for ; Thu, 20 Jun 2024 14:18:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1718918281; x=1719523081; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=bWxCTNrmZRMZjk6xShuBA8spgETA5SXOSONvnp9DFsQ=; b=VL4iGnnZDrkWv9yYfi8lQHdEEc7vRAtr0JTfxm2ePKBEb9dd8KuxL/iUSgGTjXnkCe 5zgfekZhH20YxepcavSZDFAFD0+VPgcjocA9z5BToglBpV48kTyujkFgt//2TMAtanbo 0KOJ4E2rNsNx3qf+4nmvtpojGb6rz9YUIaOHcQvW9EqWbcBZmFtjiE3sBu6poo4lx2in 4nwg8epVOsCPkXNEQvxqAS17Yj2Snwa7VTMTgEkrV32C/KzbVLAbFTiZrpKRECkVOIeg MdEf9qZcTWHzAg0CCcWEH40qRuvXJDMHPcxFC8hKH9BfXqlPdFhUxIPO1GC5s14efAat TKow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718918281; x=1719523081; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bWxCTNrmZRMZjk6xShuBA8spgETA5SXOSONvnp9DFsQ=; b=Vo2HqkupbGL/oENL7Lyo3lKAM9ryVOrRAWhYMRjI9EdRSVtV6KmWsHXrZ/rRd23/Di QgndY9PRCzMTPcvzL7/j2pOSmLCgqSo0xn9MFpTOqi6tKN0cjS5wokT1iKs/C3WK7q2z 5WFBkPeHRUHsvsghBRIakbrbotam3TM3d12AK1enBdbqJ6AbBuX23ceoW8A7swjQ80gU QHl6HvhjnPhQMPd8+gO5uBlUOFuwLtqpqCDj6nXYd6C0Q3nu/ts5PzXIS45zMf593e8v HQvr3wRwri7O5Ab8sdHxFmygw5DjeYsg4cwp6nksnqVURG4QbNzbluj2ijgVTK0bLrZO WI0Q== X-Forwarded-Encrypted: i=1; AJvYcCVPlJnd57fggFPUTCgL0ZAwZxEp20xT5ED1XjLZ2Sg7bZiMwV/d02uTrhPDFVMRvJqynar2ivydOUiXFg6L+kP2sVU= X-Gm-Message-State: AOJu0Yz7IDvZRGAezqDh6Ysf746qX6nbieb4UtQKqSOos4TiJ/e90TJ6 VuRlygJeLyb3uhmfoPOTdU3B2uFYd5IdTPFfzq20jQvZ+5g0G6u1HMAhjoxdcqmw/x/mjEkgfqT MnRjcGWroGeYXxBDd86m+JDjNJNZ1pnbcMAp0 X-Google-Smtp-Source: AGHT+IEsX/QziDSHpD5+IQeMjE9fk7Imgp53eZRaEY7Yos9IZHYlKmLr/4gvYJhwGwxb+PEgR0uRZi0fcBDysyzRuVM= X-Received: by 2002:a67:be0c:0:b0:48d:ab8c:5b66 with SMTP id ada2fe7eead31-48f130b7befmr7054249137.24.1718918280719; Thu, 20 Jun 2024 14:18:00 -0700 (PDT) MIME-Version: 1.0 References: <202406050622.SmOX6DL6-lkp@intel.com> <20240605061734.GD279426@thelio-3990X> In-Reply-To: <20240605061734.GD279426@thelio-3990X> From: Nick Desaulniers Date: Thu, 20 Jun 2024 14:17:45 -0700 Message-ID: Subject: Re: [linux-next:master 1323/3381] drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c:333:4: error: format specifies type 'unsigned char' but the argument has type 'int' To: Nathan Chancellor Cc: kernel test robot , Srinivasan Shanmugam , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Alex Deucher , Lijo Lazar Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: C8857C001E X-Stat-Signature: 981dgwjjchhg1dnih1xrj4smhpp6umdg X-HE-Tag: 1718918281-287829 X-HE-Meta: U2FsdGVkX180NnZLYhrebBKQZThM+fxnR08dp3OLcqU6C423ENc2tApohPbWa/NiMANOW87x8V0Iz0QTxD4Qn5BQb7FiTGUR0pEc1B3bMPj7EmtYgFYOXec4NRE3Q1q8FkJn8kuKGMb/z7ir9W4ouB3FxHWRXt9QOcbLvloz+cAUAC/23b63C934YDoihX2agBW7APis5rpwgLSis4ZnSJYLDXhsZCwFFtEmW6kxF1tiUhLMoze/EcEUwAVuSb3kAdmTmvfKJkEZVpmqSjAJzVk+GqMB6PX3GCS68s7asCxoYWWB96qVhZA3iyP+0+CczvrWOeUEdoxrY0HQSYz9yFy1hXbiFNdTKg+N0f7qIz+doz72QNQbOdB1BLBKmoY1lKylEiyQlBu9zWsy6iH2j8fF6s6df0aHUS2xUmSCg9ilTc+D0899H62RCzmF7vYraPo4DnZ5UjlM9rKoZXNsRpv1xhlg35kuVO6btz4ByVhJaz8QBJWTCVWVSSzD3CQXoumJgwbY2ryce4l4kxbIht6Anbava8XmluQ74NxFLA4GEbwm1jRkjdjBNvm40iZkq5PrMyObg54Agg+OAR21vgpReOfCbVxRu77w/ZbTYBEklUJH4nPv1UwzdDDCJSDOeDTHTBBQExiliCCG/OGiPS/cSkUeBf36VjfQu08WoCp+AsiTm2H0E8htKZtGCi2VnEx0HbnyP0Wdv8D6K2OiffNv10xitgDmjtgCqJX4ei8Zc+nEwM7v3UXkxxzJEqb6vhAPjYeuHoQUwtqPF29Icq1oy9pCvHCm2BzVTEbTiEuujpKsxgaCCUssAE5Pjp9a/ihGzilMw4gfCFcD14BrVFLUC1jtzzLXAOdxp5cGLc5d449Kd0ikm1AXZIZXPZwOToFokEwrLWeykw8NlAv3u5jWlXOopbafr1qg8cJsBV1oz/xniCPni0b9N0Yg5FHpaiJIbACiJ1mQGe6ZfbN kxQkMqDY jbOijx26nwMO6v2jxxQ3TTaBLNTDN5uhBSQJehSLpHq4ukwFQINLccN9HPhuWUTMs6VvffFOo7T5WkykGNt+VPy+CWVqV+wQyVkxO2zlBkUGMPRT4EysGovVDVitfDp2TMb9G8kc38rEkZJsRmQr2MRP78gz87UdOlWrzvcK6en8sTMj2R1jkUm4fZv6paaG6VBFstIIwY2rbAyinCuyYCMJIgKDetjcoyIFPkxAjQH72X2/10/8rS6g8c+4hMDnJB4qYym8FPt5wrYGetNS3utFr6GlzntZtO15EwYafSWSZH66bPZPEc48xq+2J37xFRrwrY8kp0zsmqJo7D6cFODhWOF3SqAIujNyluqsYCcf2+EiY56BRpxND/D5uMCakgZtm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000008, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 4, 2024 at 11:17=E2=80=AFPM Nathan Chancellor wrote: > > On Wed, Jun 05, 2024 at 06:23:57AM +0800, kernel test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next= .git master > > head: d97496ca23a2d4ee80b7302849404859d9058bcd > > commit: 0ea55445554209913a72eab86b60f5788776c4d6 [1323/3381] drm/amdgpu= : Fix snprintf usage in amdgpu_gfx_kiq_init_ring > > config: arm64-randconfig-003-20240605 (https://download.01.org/0day-ci/= archive/20240605/202406050622.SmOX6DL6-lkp@intel.com/config) > > compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f2= 8c006a5895fc0e329fe15fead81e37457cb1d1) > > reproduce (this is a W=3D1 build): (https://download.01.org/0day-ci/arc= hive/20240605/202406050622.SmOX6DL6-lkp@intel.com/reproduce) > > > > If you fix the issue in a separate patch/commit (i.e. not just a new ve= rsion of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot > > | Closes: https://lore.kernel.org/oe-kbuild-all/202406050622.SmOX6DL6-l= kp@intel.com/ > > > > All errors (new ones prefixed by >>): > > > > >> drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c:333:4: error: format specifi= es type 'unsigned char' but the argument has type 'int' [-Werror,-Wformat] > > xcc_id, ring->me, ring->pipe, ring->queue); > > ^~~~~~ > > >> drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c:333:12: error: format specif= ies type 'unsigned char' but the argument has type 'u32' (aka 'unsigned int= ') [-Werror,-Wformat] > > xcc_id, ring->me, ring->pipe, ring->queue); > > ^~~~~~~~ > > drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c:333:22: error: format specif= ies type 'unsigned char' but the argument has type 'u32' (aka 'unsigned int= ') [-Werror,-Wformat] > > xcc_id, ring->me, ring->pipe, ring->queue); > > ^~~~~~~~~~ > > drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c:333:34: error: format specif= ies type 'unsigned char' but the argument has type 'u32' (aka 'unsigned int= ') [-Werror,-Wformat] > > xcc_id, ring->me, ring->pipe, ring->queue); > > ^~~~~~~~~~~ > > 4 errors generated. > > For what it's worth, I think that we take care not to enable -Wformat > with clang versions older than 16 because of this issue, see commit > b0839b281c42 ("Makefile.extrawarn: re-enable -Wformat for clang; take > 2") for more information. However, now that I am looking at > scripts/Makefile.extrawarn, it appears that we only do that for a normal > build, not W=3D1? That seems like a potential oversight of that change bu= t > I am a little fuzzy on the conversation around that and I am not sure > Nick is around to answer that... Yeah, unless `-Wformat` was being set explicitly somewhere else when I wrote b0839b281c42 and has since been removed (-Wformat is part of -Wall), then it looks like my "old clang" workarounds is only for "not W=3D1 builds." That block just needs to be moved outside of the corresponding ifneq's else block. > > Cheers, > Nathan --=20 Thanks, ~Nick Desaulniers