From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3D65C433E0 for ; Fri, 12 Feb 2021 23:14:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 47D5364DEB for ; Fri, 12 Feb 2021 23:14:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 47D5364DEB Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BF9008D00AA; Fri, 12 Feb 2021 18:14:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BA8908D0060; Fri, 12 Feb 2021 18:14:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A70258D00AA; Fri, 12 Feb 2021 18:14:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0123.hostedemail.com [216.40.44.123]) by kanga.kvack.org (Postfix) with ESMTP id 925028D0060 for ; Fri, 12 Feb 2021 18:14:29 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5FF838248047 for ; Fri, 12 Feb 2021 23:14:29 +0000 (UTC) X-FDA: 77811171858.06.646C508 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by imf07.hostedemail.com (Postfix) with ESMTP id 20E7CA0000FC for ; Fri, 12 Feb 2021 23:14:27 +0000 (UTC) Received: by mail-lf1-f49.google.com with SMTP id u25so1827302lfc.2 for ; Fri, 12 Feb 2021 15:14:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qrO+Pjy//0+ajgwxZwykErc2u1IBcG+HE2tvS5qms/8=; b=d0uJRCz/1PucFr1yqpAD07HNdLWy1vUrgMFeCOeUQ8+rs+qs4zsD8xFH6FlJw4CRwt hmX0qVee0jGH3LBdpCXp2ldfsIgcSqaHohM8Vw2F+1GYf+2BMU4L2/lSX2K+Rwd/9YlB nxuV6dNRjcL0hYZ1p20j7NYpbAGnCI52ZUlO9ytbu5oAzmijISKGqcTEgBbMNoun8AY/ kFmWzYSda3BSVRMSS8xQAa45koN47lV/gGbTyR/A22ojS1/avR3+9ZR2yTqQ21FTli/u Q29MvtbYaJo+zbrIzRMRHCVqhUfwFoNxy7ozwVDJv+hcTEJNoURJZmZ110q/gOymZSV4 C5RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qrO+Pjy//0+ajgwxZwykErc2u1IBcG+HE2tvS5qms/8=; b=LxvTZDvssj3/1iMM9JazAknCD0XBH3a69+Vm2EjYebvg9wH98qaxp847pyKq3+9uD1 QAm3NHqb85+sgUxj3VlbPPVKSrtcih89W592R+eGdz8hpSQNcMH1BiGidGusssoW3qmL sbCt/9QNSVHtnjy/MDP7Xky36/xNWHG/4nqcZgs1hQ5OitGg6d09H4ZkM/hi7FbIoU4c CT6cjkgpXpgL5XCJY8n4NdTzJmH+s1FN+0vcBOc0PmUoxSAeatJIcjXi9HGZa067CmzN 2EX0eVXvgDjIF2lN+svk5PgPCSUoRnLVXMFNb8CcbHK29aUOEApHfja1maiItcTWlFNM 9TAw== X-Gm-Message-State: AOAM5308yAT2iWQtufk/2SPGS3p+ypC8aBWyn26n2znK8yQjEE2UJfzq RC+DvsSBr0qtQCORAoJY+tHyl1EKzPZCOZETZFxdIw== X-Google-Smtp-Source: ABdhPJzZZ6kI36dSdQGoUorM9cVQWBQbS1P+iraHrFJfAfpKvMmPMgStinZF4SDj9z3DHRMb4awkWYHp98La/AlGTHE= X-Received: by 2002:a19:4013:: with SMTP id n19mr2657395lfa.543.1613171667104; Fri, 12 Feb 2021 15:14:27 -0800 (PST) MIME-Version: 1.0 References: <202102130043.4UIBML4o-lkp@intel.com> <20210212230448.GG2766@breakpoint.cc> In-Reply-To: <20210212230448.GG2766@breakpoint.cc> From: Nick Desaulniers Date: Fri, 12 Feb 2021 15:14:15 -0800 Message-ID: Subject: Re: [linux-next:master 5178/10581] net/netfilter/nfnetlink_queue.c:601:36: warning: variable 'ctinfo' is uninitialized when used here To: Florian Westphal Cc: kernel test robot , kbuild-all@lists.01.org, clang-built-linux , Linux Memory Management List , Pablo Neira Ayuso Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 20E7CA0000FC X-Stat-Signature: q5opz5g99kiuhgtpaw4wqzedeq6xkey4 Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf07; identity=mailfrom; envelope-from=""; helo=mail-lf1-f49.google.com; client-ip=209.85.167.49 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1613171667-309376 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 12, 2021 at 3:04 PM Florian Westphal wrote: > > kernel test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > head: 671176b0016c80b3943cb5387312c886aba3308d > > commit: 83ace77f51175023c3757e2d08a92565f9b1c7f3 [5178/10581] netfilter: ctnetlink: remove get_ct indirection > > > >> net/netfilter/nfnetlink_queue.c:601:36: warning: variable 'ctinfo' is uninitialized when used here [-Wuninitialized] > > if (ct && nfnl_ct->build(skb, ct, ctinfo, NFQA_CT, NFQA_CT_INFO) < 0) > > ^~~~~~ > > net/netfilter/nfnetlink_queue.c:391:2: note: variable 'ctinfo' is declared here > > Looks like a false positive. > > ctinfo is uninitialized only if ct == NULL. > > The config even has "CONFIG_NF_CONNTRACK is no set" > so ct is always NULL. > > Could be "fixed" by adding aother ifdef but it would > add even more clutter to an huge function. Can you please just initialize the variable so that the tree can continue to build free of this warning? -- Thanks, ~Nick Desaulniers