From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FD7CC433DB for ; Wed, 27 Jan 2021 22:27:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CE7C964DD2 for ; Wed, 27 Jan 2021 22:27:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE7C964DD2 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F12616B0005; Wed, 27 Jan 2021 17:26:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EC4216B0006; Wed, 27 Jan 2021 17:26:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD8646B006E; Wed, 27 Jan 2021 17:26:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0219.hostedemail.com [216.40.44.219]) by kanga.kvack.org (Postfix) with ESMTP id C7AC66B0005 for ; Wed, 27 Jan 2021 17:26:59 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 872DB180AD820 for ; Wed, 27 Jan 2021 22:26:59 +0000 (UTC) X-FDA: 77752991358.30.knee67_13126202759a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id 75657180B3C8B for ; Wed, 27 Jan 2021 22:26:59 +0000 (UTC) X-HE-Tag: knee67_13126202759a X-Filterd-Recvd-Size: 6127 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by imf29.hostedemail.com (Postfix) with ESMTP for ; Wed, 27 Jan 2021 22:26:58 +0000 (UTC) Received: by mail-pf1-f170.google.com with SMTP id t29so2322882pfg.11 for ; Wed, 27 Jan 2021 14:26:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MMFtAtZNI0COZaqF8mB8/06frm5QBEITJpap0cTagq8=; b=CRXdKGJOGXXsOQpHtELIKR8umZ5rhCnWLRE36xgaT6dDVwCPEZjCeBR2Qsk7DeBK8t GWwKHGqh6cb6Fo5dOCjrFchI4QQ89+oaW5HAjc5xx3YuDcqPEcf6kdF6T98nxDSLUnkx fBgBERt0O3M9585mXFDborfe6U0cHo57JYy6hVW81eqgZGPWKR1An2L2yv9+paOg3CXH tCVrdAtbgv444EeewcZ6ba0aJYVoQ9S09DHAXWwLR1VEJ7UndfBlBjQT+Dcb1uaNW+wF TJmXQlSft7xyE1BlHvgn+w3v/p5eFlE74xEJHfRfIwJfNEGxjRThenG+fIFn+j0kj6qs dW+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MMFtAtZNI0COZaqF8mB8/06frm5QBEITJpap0cTagq8=; b=JwCnkMyGlV25cfkN5POWdw5MqEl2TMUle6oVkk4LO/l99K9Z0laXhfatW0Ft5Em/mr I4i8ITEJpUGIYhVIrc4HDbHdx5bPPL/s3UPMxsEj8ZKNyDMuJsBevarCXXaCjcCTZpwC eQsAWwMTi6cxc3fdldBIr5gkAaKaSuHVrIudKKtgyBjhP1WUj5Z7oKX9PMcJyEOL6Ku3 NbQ8vb/dYoOWpmuXs7xjzJEY9heDoSC2DqEO/5rdsxvUzybAmdk4NAwrGhDRg3BG+uFY qnY95xWJxjzGmnYsrGwBecMXawOpNJSPQxMJd5BfiTgzgr9qrc6HwyuDtzCDVRG8McDp AH5Q== X-Gm-Message-State: AOAM530KiJqlzjIYIFH33NZOh/6XpDQ54XaWOW/E0C36+I02LcII9pU2 9Pe4zD83G7qd+SNQPc6ov4pRCQa2gANekN3wCm9WMw== X-Google-Smtp-Source: ABdhPJzOWe2d9GCIKgOrAtd2j0dugg5j43ntl0uPF21manG+gGVrrjiRx873lNw4xwTd8k/hi0vONdzecQhgyBv8vSs= X-Received: by 2002:a63:7e10:: with SMTP id z16mr13557544pgc.263.1611786417749; Wed, 27 Jan 2021 14:26:57 -0800 (PST) MIME-Version: 1.0 References: <20210112205542.1375847-1-natechancellor@gmail.com> <202101130859.JSORPQUn-lkp@intel.com> <20210113013130.GA3446359@ubuntu-m3-large-x86> In-Reply-To: From: Nick Desaulniers Date: Wed, 27 Jan 2021 14:26:45 -0800 Message-ID: Subject: Re: [PATCH] ubsan: Implement __ubsan_handle_alignment_assumption To: Nathan Chancellor Cc: kernel test robot , Kees Cook , Andrew Morton , kbuild-all@lists.01.org, clang-built-linux , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 12, 2021 at 5:39 PM Nick Desaulniers wrote: > > On Tue, Jan 12, 2021 at 5:31 PM Nathan Chancellor > wrote: > > > > On Wed, Jan 13, 2021 at 08:39:52AM +0800, kernel test robot wrote: > > > Hi Nathan, > > > > > > I love your patch! Perhaps something to improve: > > > > > > [auto build test WARNING on 7c53f6b671f4aba70ff15e1b05148b10d58c2837] > > > > > > url: https://github.com/0day-ci/linux/commits/Nathan-Chancellor/ubsan-Implement-__ubsan_handle_alignment_assumption/20210113-055714 > > > base: 7c53f6b671f4aba70ff15e1b05148b10d58c2837 > > > config: arm64-randconfig-r031-20210112 (attached as .config) > > > compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 32bcfcda4e28375e5a85268d2acfabcfcc011abf) > > > reproduce (this is a W=1 build): > > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > > chmod +x ~/bin/make.cross > > > # install arm64 cross compiling tool for clang build > > > # apt-get install binutils-aarch64-linux-gnu > > > # https://github.com/0day-ci/linux/commit/775adad26a60878926c0ee6cd460a1375bbe51e6 > > > git remote add linux-review https://github.com/0day-ci/linux > > > git fetch --no-tags linux-review Nathan-Chancellor/ubsan-Implement-__ubsan_handle_alignment_assumption/20210113-055714 > > > git checkout 775adad26a60878926c0ee6cd460a1375bbe51e6 > > > # save the attached .config to linux build tree > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 > > > > > > If you fix the issue, kindly add following tag as appropriate > > > Reported-by: kernel test robot > > > > > > All warnings (new ones prefixed by >>): > > > > > > lib/ubsan.c:192:6: warning: no previous prototype for function '__ubsan_handle_add_overflow' [-Wmissing-prototypes] > > > void __ubsan_handle_add_overflow(void *data, > > > ^ > > > lib/ubsan.c:192:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > > > void __ubsan_handle_add_overflow(void *data, > > > ^ > > > static > > > lib/ubsan.c:200:6: warning: no previous prototype for function '__ubsan_handle_sub_overflow' [-Wmissing-prototypes] > > > void __ubsan_handle_sub_overflow(void *data, > > > ^ > > > lib/ubsan.c:200:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > > > void __ubsan_handle_sub_overflow(void *data, > > > ^ > > > > Given that these are compiler inserted functions, there is not much of a > > point to having prototypes to them. If people feel shutting these > > warnings up is worthwhile, we can just add the prototypes right above > > the function definition in a follow up patch. > > Same as stpcpy; it would be nice though. ;) If you would be so kind, I'd be happy to sign off on such a v3. > -- > Thanks, > ~Nick Desaulniers -- Thanks, ~Nick Desaulniers