From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f177.google.com (mail-ig0-f177.google.com [209.85.213.177]) by kanga.kvack.org (Postfix) with ESMTP id 1CCEA6B0038 for ; Thu, 8 Oct 2015 08:09:30 -0400 (EDT) Received: by igbkq10 with SMTP id kq10so13136361igb.0 for ; Thu, 08 Oct 2015 05:09:29 -0700 (PDT) Received: from mail-ig0-f173.google.com (mail-ig0-f173.google.com. [209.85.213.173]) by mx.google.com with ESMTPS id qq6si6486934igb.69.2015.10.08.05.09.28 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Oct 2015 05:09:29 -0700 (PDT) Received: by igbkq10 with SMTP id kq10so11059532igb.0 for ; Thu, 08 Oct 2015 05:09:26 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <56165228.8060201@gmail.com> References: <1442482692-6416-1-git-send-email-ryabinin.a.a@gmail.com> <20151007100411.GG3069@e104818-lin.cambridge.arm.com> <20151008111144.GC7275@leverpostej> <56165228.8060201@gmail.com> Date: Thu, 8 Oct 2015 14:09:26 +0200 Message-ID: Subject: Re: [PATCH v6 0/6] KASAN for arm64 From: Ard Biesheuvel Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Andrey Ryabinin Cc: Mark Rutland , Catalin Marinas , Will Deacon , "linux-arm-kernel@lists.infradead.org" , Yury , Alexey Klimov , Arnd Bergmann , "linux-mm@kvack.org" , Andrey Konovalov , Linus Walleij , LKML , David Keitel , Alexander Potapenko , Dmitry Vyukov , Mark Salter , "linux-efi@vger.kernel.org" On 8 October 2015 at 13:23, Andrey Ryabinin wrote: > On 10/08/2015 02:11 PM, Mark Rutland wrote: >> On Thu, Oct 08, 2015 at 01:36:09PM +0300, Andrey Ryabinin wrote: >>> 2015-10-07 13:04 GMT+03:00 Catalin Marinas : >>>> On Thu, Sep 17, 2015 at 12:38:06PM +0300, Andrey Ryabinin wrote: >>>>> As usual patches available in git >>>>> git://github.com/aryabinin/linux.git kasan/arm64v6 >>>>> >>>>> Changes since v5: >>>>> - Rebase on top of 4.3-rc1 >>>>> - Fixed EFI boot. >>>>> - Updated Doc/features/KASAN. >>>> >>>> I tried to merge these patches (apart from the x86 one which is already >>>> merged) but it still doesn't boot on Juno as an EFI application. >>>> >>> >>> 4.3-rc1 was ok and 4.3-rc4 is not. Break caused by 0ce3cc008ec04 >>> ("arm64/efi: Fix boot crash by not padding between EFI_MEMORY_RUNTIME >>> regions") >>> It introduced sort() call in efi_get_virtmap(). >>> sort() is generic kernel function and it's instrumented, so we crash >>> when KASAN tries to access shadow in sort(). >> >> I believe this is solved by Ard's stub isolation series [1,2], which >> will build a stub-specific copy of sort() and various other functions >> (see the arm-deps in [2]). >> >> So long as the stub is not built with ASAN, that should work. > > Thanks, this should help, as we already build the stub without ASAN instrumentation. > Indeed. I did not mention instrumentation in the commit log for those patches, but obviously, something like KASAN instrumentation cannot be tolerated in the stub since it makes assumptions about the memory layout -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org