From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 068ECCF0449 for ; Wed, 9 Oct 2024 10:09:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C7CC6B00D3; Wed, 9 Oct 2024 06:09:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 777B06B00D4; Wed, 9 Oct 2024 06:09:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5FC286B00D5; Wed, 9 Oct 2024 06:09:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3CC426B00D3 for ; Wed, 9 Oct 2024 06:09:29 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id F20C48113C for ; Wed, 9 Oct 2024 10:09:26 +0000 (UTC) X-FDA: 82653641616.05.D5F5B0D Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by imf23.hostedemail.com (Postfix) with ESMTP id ADA9E14001D for ; Wed, 9 Oct 2024 10:09:26 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=K+xTqKIn; spf=pass (imf23.hostedemail.com: domain of fdmanana@suse.com designates 209.85.167.47 as permitted sender) smtp.mailfrom=fdmanana@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728468386; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/JCN+MqNwKB+xq7DJqcu2c22e3shYGFUi85UwCEHpck=; b=sC+e1AGkmWHvVe/e/nJdnsHsBR/0MfzZyWKVOUlD4CGVk5KZm/SddD3ngt2MopAocbc6KC B6Tx2B9zyzGytDNlGYcrbpskYhODxG0NQBDDEdXjMXi+iYxxQakdo5owEE3iw/KrNFTLtS 7t2ur7TwE2CILtMWVYkyvUKFxhGTIPE= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=K+xTqKIn; spf=pass (imf23.hostedemail.com: domain of fdmanana@suse.com designates 209.85.167.47 as permitted sender) smtp.mailfrom=fdmanana@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728468386; a=rsa-sha256; cv=none; b=j+bzFqHoXPlVH2F7MCqtguWeom6uln6xXh8PUDrftS4XmmioaAAYeF+Tek+5vP0X4OUZZw WMXWkkhVOi534cNKBph81hAwGFyO/zTuvzT30TKBzJpF7BjFDAO2s0gX4HuZnlhbrUAEWq jgrfhSvXSCcp5PpzJ0CTGT/JjOjoQR4= Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-5398e7dda5fso6699940e87.0 for ; Wed, 09 Oct 2024 03:09:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1728468565; x=1729073365; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/JCN+MqNwKB+xq7DJqcu2c22e3shYGFUi85UwCEHpck=; b=K+xTqKInKg1bHVCmxkQO/E6lpPQ2FA+ucTFqgPM7zjwxBOQrapUi83lY4wfO2ajQlR BwAau5hU2Hc5WWA39qC8LSAgmRucIMNPxAUbL3Xy9CO4AhWWc9Br/CIrj3XtuLcm/Eaa Nzh74jnTZmrm8f5wJLmPLfBHHPxGzfM4ThsWK8bR5URMVbeaUsyM8oRQOq0SvAruFDAq QckUz1tsaH98UXFOIXBA4xwP6dweL+ktZK1tfeVyCL14QkFB3mUWK72pRDOoGO0X+iOZ ffmCGeA69mKu9OMqNt9vELsaH42OlfrbeqM8GAvR/rA3cZvL65+81tIpTKzE+yweQ/Wn XOgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728468565; x=1729073365; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/JCN+MqNwKB+xq7DJqcu2c22e3shYGFUi85UwCEHpck=; b=Q5bXYN2We61uve8EZp07hUK33NI0Uzfvjypd2D0redeQ8MqSTrlMZBfEd1nAjUAhTw TnOGAftk6HELqQpyKJGAhXighALLWj9I8LWPYEJVXzywC33m9zmjkAeZCPVM22BnioQD 53V2O7fTxSlXR50sECxDRZ6+FIZNnijydUVOXo1CwW05KdocscREjPp7eTPBWaN4+T3x oaHBd93ArxUVbO/lk1uEwVIE+a+x5XM+R+aZpGYRns1OtGbjDbhi2yQ8nG33Pek5yz/k GIHF2kLJXY9fEazKDnb9JymByHWBMdOuYTYSuKJG/YlevAqrJLfIn1zw8kVfRPGOe5L3 yCZQ== X-Forwarded-Encrypted: i=1; AJvYcCXbaWkUXLr/PJS2p8mbLptWXPpY0ZpQ5v+Vv2VnzvsJIDUOkuaurFtcv4nKQoi9ietYhHDCAHUQYQ==@kvack.org X-Gm-Message-State: AOJu0YwxAeo7AB0iS3SZv0PtoUmnx+ZDqP0FTlq5wIYoyJIwWOabgvu2 HU0bdMKyF/igJ4XtIThZC5HE/Le/T5auaNcSpPMQleIH7O8oIY7UX2cSAoS9D5kcXWi+Rhj+GKH MFaFXhMquw9jj1fb9nB63/gfV/X6SbdoH1YdNXQ== X-Google-Smtp-Source: AGHT+IFTR4aAdG0xRnbrM1o9GBPsFiAJ6nHLa2xX7thhMATNrBF1ULIeimPZZaeqCiGE8ZQokCDJj12FbT6MOOZiYvk= X-Received: by 2002:a05:6512:110e:b0:536:a275:9d61 with SMTP id 2adb3069b0e04-539c48c3883mr1055475e87.21.1728468564615; Wed, 09 Oct 2024 03:09:24 -0700 (PDT) MIME-Version: 1.0 References: <202410091038.SI34ZULQ-lkp@intel.com> In-Reply-To: <202410091038.SI34ZULQ-lkp@intel.com> From: Filipe Manana Date: Wed, 9 Oct 2024 11:09:13 +0100 Message-ID: Subject: Re: [linux-next:pending-fixes 207/319] fs/btrfs/qgroup.c:2014:6: error: use of undeclared identifier 'bytenr' To: kernel test robot Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , David Sterba , Qu Wenruo Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: ADA9E14001D X-Stat-Signature: 96d5xgt9ofsznezwuiaobfiennjcotj1 X-Rspam-User: X-HE-Tag: 1728468566-308648 X-HE-Meta: U2FsdGVkX18x2PWxKYoQPfIIck61ZH5V/mj803LGFR7L3Dz4GjDNiWM+RZh8RTjLJLWUQBsV+E++OsnxHa+rsyIL0CPkTzSxBQx7wR/sZgRxekSpqyNQlzjkdi1U3VNQUHXXGUZR1gwaOpROvu+mWoZ04qwzguKcME4RNCqB4F+SF3dTjfllyKOUj9Kl49/Ydnogc5qJ7JlGvr7IG7arm9jpZAGCk/5rMY9fq6IXqWOLkyyrrIlpWG17AQ3iITRMF1YM+CIwM+d/+IoZywyX5kDx5ZwucZb7vDqxF93XpUmTLuPdZN0u5nRKZybHl0xvXg0HlDfQAld8kLdeF8Lyy5txIBGPVCv2EZ6gWNpshei+I7MJVmIZjsdEUv5Szf9GrvB7roQzn2n+YEMjWwUjPv72ISDsPmv76EqRTS1sr770pYg3ylNeCqloCCvOzxx0jrWa5KvK+znjMoPHZZLDS3SDeilwm1OuQg9hE3PMAkdOkasEts+pJ3AG8mayKkK4TAcK6EjOjou5qkEQhPnCkjOBsT0v3Ju75gS0mDEu9sjkWRpehUlu4K+wClHNlwtEa66KlI+AdRuXe7mL1cfOmhOe3ot46n6hb1g7anlQOaK2vQaJ3LvtGSMcE9TSolqMkjlnRmDIhk18vYWBfja1X+Q/Bazrb6ZQ7YngA7EVuErHVSbOs07KkGBsK3AyhZg/xDBba4xSexatMGpSY2SrBBWcCpH8GZPUo4nrZqFTBtmSZ2+S+pATF+7d3qU4wKwJPlXumSa7Rv5yQeSTpVtMvh4gKUfB+8iRGiWleIwAn1cS5kpx6DS86pOtZ3q0y+yBei3KRs+rC0CIgkg5b5y/0Mv2JgnLkziKotfspRFPWlWa9F+5kBXVPQR/1lxtXPpfagD10JE+IQvfpla8jbEaVjfFxLZIPW1PasfLUi+ODo3R/xxBsQddZjLte0yoD5kaVmsSc2ag+nH7D9v5cyM cxbL4H3B IyYyfilRw9enw2GViB3b4xThrh9WGhLzPyFLsrS8Tq1/yizi1ta5BBNVGVZzivREWyMFRhsARA81GJLLfl0qe4rsVEBmzL/Tt/D55NOyEMhmCL8mNoMKXmjOGlM177nqojkvQOYCpBsQmVciYOqSrjaD56sUagEiz9Yo9OqJRxHXf4A0tD4xX/IxNI6oJajTl6bA5NiznS5Ieew5Mf1BNE0l56p83iXH2JxbZjnA5UO26BJZ0chv2DWfbZvupz/KvV7eIsjVVew3SLA/UXqqAdOdF+jADpqrwER3Y9TFRb6lstdXxR8HepjFB02OAGJa/WoLc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 9, 2024 at 3:55=E2=80=AFAM kernel test robot wr= ote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.g= it pending-fixes > head: 47fa0de9b07c6214b57458e965646a3e25656b69 > commit: 5c0ea18d992fffc948e087c0002560d747e6edd9 [207/319] btrfs: use sec= tor numbers as keys for the dirty extents xarray > config: arm-randconfig-002-20241009 (https://download.01.org/0day-ci/arch= ive/20241009/202410091038.SI34ZULQ-lkp@intel.com/config) > compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project 8dfd= cc7b7bf66834a761bd8de445840ef68e4d1a) > reproduce (this is a W=3D1 build): (https://download.01.org/0day-ci/archi= ve/20241009/202410091038.SI34ZULQ-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new vers= ion of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202410091038.SI34ZULQ-lkp= @intel.com/ > > All errors (new ones prefixed by >>): > > >> fs/btrfs/qgroup.c:2014:6: error: use of undeclared identifier 'bytenr' > if (bytenr >=3D MAX_LFS_FILESIZE) { Ah this should be record->bytenr. The issue is actually fixed in a later patch of the same patchset, where bytenr is a function argument. I can update the patch but then it will require updating the patches that come next from the same patchset and rebasing the for-next branch. And I see it's already in the next-fixes branch. David, how do you prefer to proceed here? Do you want me to fix this and resend the patchset? Thanks. > ^ > fs/btrfs/qgroup.c:2017:9: error: use of undeclared identifier 'bytenr' > bytenr); > ^ > 2 errors generated. > > > vim +/bytenr +2014 fs/btrfs/qgroup.c > > 1991 > 1992 /* > 1993 * Inform qgroup to trace one dirty extent, its info is recorded = in @record. > 1994 * So qgroup can account it at transaction committing time. > 1995 * > 1996 * No lock version, caller must acquire delayed ref lock and allo= cated memory, > 1997 * then call btrfs_qgroup_trace_extent_post() after exiting lock = context. > 1998 * > 1999 * Return 0 for success insert > 2000 * Return >0 for existing record, caller can free @record safely. > 2001 * Return <0 for insertion failure, caller can free @record safel= y. > 2002 */ > 2003 int btrfs_qgroup_trace_extent_nolock(struct btrfs_fs_info *fs_inf= o, > 2004 struct btrfs_delayed_ref_root *de= layed_refs, > 2005 struct btrfs_qgroup_extent_record= *record) > 2006 { > 2007 struct btrfs_qgroup_extent_record *existing, *ret; > 2008 const unsigned long index =3D (record->bytenr >> fs_info-= >sectorsize_bits); > 2009 > 2010 if (!btrfs_qgroup_full_accounting(fs_info)) > 2011 return 1; > 2012 > 2013 #if BITS_PER_LONG =3D=3D 32 > > 2014 if (bytenr >=3D MAX_LFS_FILESIZE) { > 2015 btrfs_err_rl(fs_info, > 2016 "qgroup record for extent at %llu is beyond 32bit page cache and = xarray index limit", > 2017 bytenr); > 2018 btrfs_err_32bit_limit(fs_info); > 2019 return -EOVERFLOW; > 2020 } > 2021 #endif > 2022 > 2023 lockdep_assert_held(&delayed_refs->lock); > 2024 trace_btrfs_qgroup_trace_extent(fs_info, record); > 2025 > 2026 xa_lock(&delayed_refs->dirty_extents); > 2027 existing =3D xa_load(&delayed_refs->dirty_extents, index)= ; > 2028 if (existing) { > 2029 if (record->data_rsv && !existing->data_rsv) { > 2030 existing->data_rsv =3D record->data_rsv; > 2031 existing->data_rsv_refroot =3D record->da= ta_rsv_refroot; > 2032 } > 2033 xa_unlock(&delayed_refs->dirty_extents); > 2034 return 1; > 2035 } > 2036 > 2037 ret =3D __xa_store(&delayed_refs->dirty_extents, index, r= ecord, GFP_ATOMIC); > 2038 xa_unlock(&delayed_refs->dirty_extents); > 2039 if (xa_is_err(ret)) { > 2040 qgroup_mark_inconsistent(fs_info); > 2041 return xa_err(ret); > 2042 } > 2043 > 2044 return 0; > 2045 } > 2046 > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests/wiki